From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 810B3A0093 for ; Thu, 28 May 2020 18:25:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79E621DC10; Thu, 28 May 2020 18:25:50 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id BBD511DC1D for ; Thu, 28 May 2020 18:25:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HkiqL+cyfb9NMJisDv23bodBf4y7h6sNfNxtIdDtDck=; b=hu7XplA+7b3L7wRzMyQ8vTsy+IgAeueea7lreKHipaUxEm63BydRpnBq6OWQEnup/8OnZy /L2Bpl01jMaQIw8aUpZoPXXBTIEF2cST2OBbzK1e1+fikBaOIkOo+obf/XRIWO5ZC6no1n he9hh9Ut1F803t8BFkzzFyH4F1527Rc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-b43aXSP-MRS4nzwoLscdcQ-1; Thu, 28 May 2020 12:25:43 -0400 X-MC-Unique: b43aXSP-MRS4nzwoLscdcQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14A281005512; Thu, 28 May 2020 16:25:42 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0499060C05; Thu, 28 May 2020 16:25:40 +0000 (UTC) From: Kevin Traynor To: Michal Krawczyk Cc: Igor Chauskin , Guy Tzalik , dpdk stable Date: Thu, 28 May 2020 17:22:53 +0100 Message-Id: <20200528162322.7863-66-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ena/base: fix documentation of functions' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/a1c41ac2eba79d42bba4c52f33126b2a45b91cc2 Thanks. Kevin. --- >From a1c41ac2eba79d42bba4c52f33126b2a45b91cc2 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Wed, 8 Apr 2020 10:29:01 +0200 Subject: [PATCH] net/ena/base: fix documentation of functions [ upstream commit b118993abd4cae7af3f8a66e0ad4fda1bee84c09 ] The documentation format was aligned and few typos were fixed. Fixes: 99ecfbf845b3 ("ena: import communication layer") Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/base/ena_com.h b/drivers/net/ena/base/ena_com.h index f58cd86a87..2e80ad563f 100644 --- a/drivers/net/ena/base/ena_com.h +++ b/drivers/net/ena/base/ena_com.h @@ -381,5 +381,5 @@ extern "C" { int ena_com_mmio_reg_read_request_init(struct ena_com_dev *ena_dev); -/* ena_com_set_mmio_read_mode - Enable/disable the mmio reg read mechanism +/* ena_com_set_mmio_read_mode - Enable/disable the indirect mmio reg read mechanism * @ena_dev: ENA communication layer struct * @readless_supported: readless mode (enable/disable) @@ -507,5 +507,5 @@ bool ena_com_get_ena_admin_polling_mode(struct ena_com_dev *ena_dev); * @ena_dev: ENA communication layer struct * - * This method go over the admin completion queue and wake up all the pending + * This method goes over the admin completion queue and wakes up all the pending * threads that wait on the commands wait event. * @@ -517,5 +517,5 @@ void ena_com_admin_q_comp_intr_handler(struct ena_com_dev *ena_dev); * @ena_dev: ENA communication layer struct * - * This method go over the async event notification queue and call the proper + * This method goes over the async event notification queue and calls the proper * aenq handler. */ @@ -534,5 +534,5 @@ void ena_com_abort_admin_commands(struct ena_com_dev *ena_dev); * @ena_dev: ENA communication layer struct * - * This method wait until all the outstanding admin commands will be completed. + * This method waits until all the outstanding admin commands are completed. */ void ena_com_wait_for_abort_completion(struct ena_com_dev *ena_dev); @@ -541,5 +541,5 @@ void ena_com_wait_for_abort_completion(struct ena_com_dev *ena_dev); * @ena_dev: ENA communication layer struct * - * This method validate the device parameters are the same as the saved + * This method verifies the device parameters are the same as the saved * parameters in ena_dev. * This method is useful after device reset, to validate the device mac address @@ -718,5 +718,5 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev); * Retrieve the hash control from the device. * - * @note, If the caller called ena_com_fill_hash_ctrl but didn't flash + * @note: If the caller called ena_com_fill_hash_ctrl but didn't flash * it to the device, the new configuration will be lost. * @@ -770,5 +770,5 @@ int ena_com_indirect_table_set(struct ena_com_dev *ena_dev); * Retrieve the RSS indirection table from the device. * - * @note: If the caller called ena_com_indirect_table_fill_entry but didn't flash + * @note: If the caller called ena_com_indirect_table_fill_entry but didn't flush * it to the device, the new configuration will be lost. * @@ -796,5 +796,5 @@ int ena_com_allocate_debug_area(struct ena_com_dev *ena_dev, * @ena_dev: ENA communication layer struct * - * Free the allocate debug area. + * Free the allocated debug area. */ void ena_com_delete_debug_area(struct ena_com_dev *ena_dev); @@ -803,5 +803,5 @@ void ena_com_delete_debug_area(struct ena_com_dev *ena_dev); * @ena_dev: ENA communication layer struct * - * Free the allocate host info. + * Free the allocated host info. */ void ena_com_delete_host_info(struct ena_com_dev *ena_dev); @@ -844,7 +844,7 @@ int ena_com_destroy_io_cq(struct ena_com_dev *ena_dev, * @cmd_comp_size: command completion size. - * Submit an admin command and then wait until the device will return a + * Submit an admin command and then wait until the device returns a * completion. - * The completion will be copyed into cmd_comp. + * The completion will be copied into cmd_comp. * * @return - 0 on success, negative value on failure. @@ -1028,5 +1028,5 @@ static inline void ena_com_calculate_interrupt_delay(struct ena_com_dev *ena_dev * @rx_delay_interval: Rx interval in usecs * @tx_delay_interval: Tx interval in usecs - * @unmask: unask enable/disable + * @unmask: unmask enable/disable * * Prepare interrupt update register with the supplied parameters. -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:13:02.515704682 +0100 +++ 0066-net-ena-base-fix-documentation-of-functions.patch 2020-05-28 17:12:59.144555427 +0100 @@ -1 +1 @@ -From b118993abd4cae7af3f8a66e0ad4fda1bee84c09 Mon Sep 17 00:00:00 2001 +From a1c41ac2eba79d42bba4c52f33126b2a45b91cc2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b118993abd4cae7af3f8a66e0ad4fda1bee84c09 ] + @@ -18 +20 @@ -index 07f63f44af..6c9943df79 100644 +index f58cd86a87..2e80ad563f 100644 @@ -21 +23 @@ -@@ -371,5 +371,5 @@ extern "C" { +@@ -381,5 +381,5 @@ extern "C" { @@ -28 +30 @@ -@@ -505,5 +505,5 @@ void ena_com_set_admin_auto_polling_mode(struct ena_com_dev *ena_dev, +@@ -507,5 +507,5 @@ bool ena_com_get_ena_admin_polling_mode(struct ena_com_dev *ena_dev); @@ -35 +37 @@ -@@ -515,5 +515,5 @@ void ena_com_admin_q_comp_intr_handler(struct ena_com_dev *ena_dev); +@@ -517,5 +517,5 @@ void ena_com_admin_q_comp_intr_handler(struct ena_com_dev *ena_dev); @@ -42 +44 @@ -@@ -532,5 +532,5 @@ void ena_com_abort_admin_commands(struct ena_com_dev *ena_dev); +@@ -534,5 +534,5 @@ void ena_com_abort_admin_commands(struct ena_com_dev *ena_dev); @@ -49 +51 @@ -@@ -539,5 +539,5 @@ void ena_com_wait_for_abort_completion(struct ena_com_dev *ena_dev); +@@ -541,5 +541,5 @@ void ena_com_wait_for_abort_completion(struct ena_com_dev *ena_dev); @@ -56 +58 @@ -@@ -716,5 +716,5 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev); +@@ -718,5 +718,5 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev); @@ -63 +65 @@ -@@ -768,5 +768,5 @@ int ena_com_indirect_table_set(struct ena_com_dev *ena_dev); +@@ -770,5 +770,5 @@ int ena_com_indirect_table_set(struct ena_com_dev *ena_dev); @@ -70 +72 @@ -@@ -794,5 +794,5 @@ int ena_com_allocate_debug_area(struct ena_com_dev *ena_dev, +@@ -796,5 +796,5 @@ int ena_com_allocate_debug_area(struct ena_com_dev *ena_dev, @@ -77 +79 @@ -@@ -801,5 +801,5 @@ void ena_com_delete_debug_area(struct ena_com_dev *ena_dev); +@@ -803,5 +803,5 @@ void ena_com_delete_debug_area(struct ena_com_dev *ena_dev); @@ -84 +86 @@ -@@ -842,7 +842,7 @@ int ena_com_destroy_io_cq(struct ena_com_dev *ena_dev, +@@ -844,7 +844,7 @@ int ena_com_destroy_io_cq(struct ena_com_dev *ena_dev, @@ -94 +96 @@ -@@ -933,5 +933,5 @@ static inline void ena_com_disable_adaptive_moderation(struct ena_com_dev *ena_d +@@ -1028,5 +1028,5 @@ static inline void ena_com_calculate_interrupt_delay(struct ena_com_dev *ena_dev