From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55747A0093 for ; Thu, 28 May 2020 18:24:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E00F1DC1A; Thu, 28 May 2020 18:24:29 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 401891DC1A for ; Thu, 28 May 2020 18:24:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=87CII3Q+VdF6rM8ZuSq9uYBUHwlAJjwZPAlBdgaf/3s=; b=gd0MB2aygHldty5qJNCJVxSwgW6FtQ782t/jXK8dxZsjXsiw/JCYFdH9UVbOghwMe3VpZ6 rb7bdz5JDEsq4W/MRxGAlZwrQ8nTMvmfIMPfeU15f+okuxXOjojKr5yOpyt6wzSHLbR+BY LP5eOqWaFbL3GO5lCGdpRXWiInrJyOo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-0W3IaXnNN5GIcThjjyfbOA-1; Thu, 28 May 2020 12:24:25 -0400 X-MC-Unique: 0W3IaXnNN5GIcThjjyfbOA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F4CC464; Thu, 28 May 2020 16:24:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A819619DD; Thu, 28 May 2020 16:24:22 +0000 (UTC) From: Kevin Traynor To: Harry van Haaren Cc: David Marchand , Aaron Conole , dpdk stable Date: Thu, 28 May 2020 17:21:54 +0100 Message-Id: <20200528162322.7863-7-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'service: fix crash on exit' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/a65c71f595a69de7371f5abc991458ccce9ad9cc Thanks. Kevin. --- >From a65c71f595a69de7371f5abc991458ccce9ad9cc Mon Sep 17 00:00:00 2001 From: Harry van Haaren Date: Wed, 11 Mar 2020 14:39:27 +0000 Subject: [PATCH] service: fix crash on exit [ upstream commit 33666b448f15687ceaf61eac405d945391fe7066 ] This commit releases all service cores from their role, returning them to ROLE_RTE on rte_service_finalize(). This fixes an issue relating to the service cores causing a race-condition on rte_eal_cleanup(), where the service core could still be executing while the main thread has already free-d the service memory, leading to a segfault. Fixes: da23f0aa87d8 ("service: fix memory leak with new function") Reported-by: David Marchand Reported-by: Aaron Conole Signed-off-by: David Marchand Signed-off-by: Harry van Haaren Acked-by: Aaron Conole --- lib/librte_eal/common/rte_service.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index 53dd6a7bbf..5e757fbd19 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -122,4 +122,7 @@ rte_service_finalize(void) return; + rte_service_lcore_reset_all(); + rte_eal_mp_wait_lcore(); + rte_free(rte_services); rte_free(lcore_states); -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:12:59.542387726 +0100 +++ 0007-service-fix-crash-on-exit.patch 2020-05-28 17:12:59.031557984 +0100 @@ -1 +1 @@ -From 33666b448f15687ceaf61eac405d945391fe7066 Mon Sep 17 00:00:00 2001 +From a65c71f595a69de7371f5abc991458ccce9ad9cc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 33666b448f15687ceaf61eac405d945391fe7066 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 7e537b8cd2..b0b78baabd 100644 +index 53dd6a7bbf..5e757fbd19 100644 @@ -30 +31 @@ -@@ -123,4 +123,7 @@ rte_service_finalize(void) +@@ -122,4 +122,7 @@ rte_service_finalize(void)