From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 292B0A0093 for ; Thu, 28 May 2020 18:26:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 230FC1DC27; Thu, 28 May 2020 18:26:02 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id ADE991DC10 for ; Thu, 28 May 2020 18:26:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XEM6tF7O+0qM1J3wjA20ZGsxtDUDs771HS61oNeOwg8=; b=f7sSEgZb3llPNsnZluiIq60witI93kmjSQjZVGE/ir5YVUP4zHaMOkDzaloFAn1c6XB/s3 qvTUO7ojHqi122mxi6csNMPleyzcEs2nVXB41Vp4UlYLtlQ2vVVnRLyfsNVfipGo/LgKCA MXnA6NkigEq4laXiKAWKF9NTKO7wDK4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-nt1nq_ZeMviIUH8jS9w2Bg-1; Thu, 28 May 2020 12:25:55 -0400 X-MC-Unique: nt1nq_ZeMviIUH8jS9w2Bg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC08AEC1A7; Thu, 28 May 2020 16:25:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3F7F60C05; Thu, 28 May 2020 16:25:53 +0000 (UTC) From: Kevin Traynor To: Xiaolong Ye Cc: Maxime Coquelin , dpdk stable Date: Thu, 28 May 2020 17:23:01 +0100 Message-Id: <20200528162322.7863-74-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/virtio: fix outdated comment' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/84edbc742b21efa742ee0f97fe4230b3f1d6c0ca Thanks. Kevin. --- >From 84edbc742b21efa742ee0f97fe4230b3f1d6c0ca Mon Sep 17 00:00:00 2001 From: Xiaolong Ye Date: Sat, 7 Mar 2020 21:22:34 +0800 Subject: [PATCH] net/virtio: fix outdated comment [ upstream commit f6ac14f13b040fb44db6ed4ab392865fb6648201 ] Fix comment that is no more correct as the code evolved. Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory") Signed-off-by: Xiaolong Ye Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 2d4c6c7fa9..be24677093 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -350,5 +350,5 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) if (!rte_is_power_of_2(vq_size)) { - PMD_INIT_LOG(ERR, "virtqueue size is not powerof 2"); + PMD_INIT_LOG(ERR, "virtqueue size is not power of 2"); return -EINVAL; } @@ -465,6 +465,6 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) } - /* For virtio_user case (that is when hw->dev is NULL), we use - * virtual address. And we need properly set _offset_, please see + /* For virtio_user case (that is when hw->virtio_user_dev is not NULL), + * we use virtual address. And we need properly set _offset_, please see * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information. */ -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:13:02.950121217 +0100 +++ 0074-net-virtio-fix-outdated-comment.patch 2020-05-28 17:12:59.157555133 +0100 @@ -1 +1 @@ -From f6ac14f13b040fb44db6ed4ab392865fb6648201 Mon Sep 17 00:00:00 2001 +From 84edbc742b21efa742ee0f97fe4230b3f1d6c0ca Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f6ac14f13b040fb44db6ed4ab392865fb6648201 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index f9d0ea70db..35203940a7 100644 +index 2d4c6c7fa9..be24677093 100644 @@ -21 +22 @@ -@@ -467,5 +467,5 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) +@@ -350,5 +350,5 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) @@ -23,3 +24,3 @@ - if (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) { -- PMD_INIT_LOG(ERR, "split virtqueue size is not powerof 2"); -+ PMD_INIT_LOG(ERR, "split virtqueue size is not power of 2"); + if (!rte_is_power_of_2(vq_size)) { +- PMD_INIT_LOG(ERR, "virtqueue size is not powerof 2"); ++ PMD_INIT_LOG(ERR, "virtqueue size is not power of 2"); @@ -28 +29 @@ -@@ -589,6 +589,6 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx) +@@ -465,6 +465,6 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)