From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78E64A0093 for ; Thu, 28 May 2020 18:24:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72DDE1D996; Thu, 28 May 2020 18:24:34 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id D52E81D996 for ; Thu, 28 May 2020 18:24:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590683071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mlDp5DFW+xoDOafzM7HJndvHMHowb9hmx9WSXwaidiA=; b=gPJzTfd0+BUdzVRfD/6WyF0H/J+0r1mKXXCRGuQM7m+nTkj/IfVbuFfNZB52k/38ElMCWi D2oaHHYfP1CNfSAA36GdlyUXc6FDwXRateXjjB+BqvV04A8Ars5lYOxQt1fNnPhOxiLINT O4QSMffNH8x8cdNrQy60c744cmzQXTI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-qh2beecPNmGWupvlmFAO_g-1; Thu, 28 May 2020 12:24:27 -0400 X-MC-Unique: qh2beecPNmGWupvlmFAO_g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C745481E22B; Thu, 28 May 2020 16:24:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3BBB60C05; Thu, 28 May 2020 16:24:25 +0000 (UTC) From: Kevin Traynor To: Qiming Yang Cc: Xiaolong Ye , dpdk stable Date: Thu, 28 May 2020 17:21:56 +0100 Message-Id: <20200528162322.7863-9-ktraynor@redhat.com> In-Reply-To: <20200528162322.7863-1-ktraynor@redhat.com> References: <20200528162322.7863-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: fix X722 performance' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/03/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/fdda793ae917cc74796239401676d5f673456fda Thanks. Kevin. --- >From fdda793ae917cc74796239401676d5f673456fda Mon Sep 17 00:00:00 2001 From: Qiming Yang Date: Tue, 3 Mar 2020 13:45:00 +0800 Subject: [PATCH] net/i40e: fix X722 performance [ upstream commit b4668579286c56fded2816602e104abbcf0b5adb ] Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch adds value as: Device-ID Value Comments 0x37D0 0x03030303 4x10G FPK This value is hardware specific. Fixes: 3320d4a240da ("net/i40e: workaround performance degradation") Signed-off-by: Qiming Yang Acked-by: Xiaolong Ye --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 040bedfad9..f312abed27 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -10277,4 +10277,5 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) }, + { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) }, -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-28 17:12:59.641465378 +0100 +++ 0009-net-i40e-fix-X722-performance.patch 2020-05-28 17:12:59.046557645 +0100 @@ -1 +1 @@ -From b4668579286c56fded2816602e104abbcf0b5adb Mon Sep 17 00:00:00 2001 +From fdda793ae917cc74796239401676d5f673456fda Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b4668579286c56fded2816602e104abbcf0b5adb ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 9fbda1c34c..c09b9b990c 100644 +index 040bedfad9..f312abed27 100644 @@ -28 +29 @@ -@@ -10505,4 +10505,5 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) +@@ -10277,4 +10277,5 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value)