From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE4EDA04A3 for ; Fri, 5 Jun 2020 20:26:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7BC91D510; Fri, 5 Jun 2020 20:26:06 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 2546F1D510 for ; Fri, 5 Jun 2020 20:26:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OuhTjcKVUbJFjy273yCQACxgvlaDIgtNPT8tY/2svy0=; b=S4AkhwgaZ7AuUPqbFoJw4rlMcf9zHmtcB9DNy/X5H5kUHekqfax3mGtQ18/e2NifXMjFBk WuApQIVdgXUo6OZQ5qwpI083+OmDym45x1z9IhL9AvNP17a0oGdofV66nrnW3lv32EKV/e 5v7FCIXsXiTUtr8vgw9d7NavKhAZErw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-1rQcDhTPPk-S2mPdfo7qmA-1; Fri, 05 Jun 2020 14:26:00 -0400 X-MC-Unique: 1rQcDhTPPk-S2mPdfo7qmA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1196EC1A5; Fri, 5 Jun 2020 18:25:59 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDDC8610F2; Fri, 5 Jun 2020 18:25:58 +0000 (UTC) From: Kevin Traynor To: Jasvinder Singh Cc: Cristian Dumitrescu , dpdk stable Date: Fri, 5 Jun 2020 19:24:10 +0100 Message-Id: <20200605182525.22483-13-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/softnic: fix memory leak for thread' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/55284b6b02af122f85940328ba8b17e21f719178 Thanks. Kevin. --- >From 55284b6b02af122f85940328ba8b17e21f719178 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Mon, 27 Apr 2020 18:13:20 +0100 Subject: [PATCH] net/softnic: fix memory leak for thread [ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ] For sending request messages to data plane threads, the caller invokes thread_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response. Coverity issue: 357717, 357772 Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- drivers/net/softnic/rte_eth_softnic_thread.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c index 4572adfa6a..e42784e4ca 100644 --- a/drivers/net/softnic/rte_eth_softnic_thread.c +++ b/drivers/net/softnic/rte_eth_softnic_thread.c @@ -268,6 +268,4 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic, /* Send request and wait for response */ rsp = thread_msg_send_recv(softnic, thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -356,6 +354,4 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic, /* Send request and wait for response */ rsp = thread_msg_send_recv(softnic, thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:51.653540402 +0100 +++ 0013-net-softnic-fix-memory-leak-for-thread.patch 2020-06-05 19:20:50.727042699 +0100 @@ -1 +1 @@ -From 22335d4348d4b4b615d5556947c0297e0fe5d79b Mon Sep 17 00:00:00 2001 +From 55284b6b02af122f85940328ba8b17e21f719178 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index d610b1617e..d61846e030 100644 +index 4572adfa6a..e42784e4ca 100644 @@ -25 +26 @@ -@@ -360,6 +360,4 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic, +@@ -268,6 +268,4 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic, @@ -32 +33 @@ -@@ -445,6 +443,4 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic, +@@ -356,6 +354,4 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic,