From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A18D1A04A3 for ; Fri, 5 Jun 2020 20:27:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6C491D564; Fri, 5 Jun 2020 20:27:36 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id D77E41D52B for ; Fri, 5 Jun 2020 20:27:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0YGXJs2EGPBj27PXPb9uf/3DsYOsNmOI/LPXrpBmPtc=; b=fdDiduPWAG9q5g7dNEUn5dAkSVIlcQ0SF4Q6Q+n9eyqTMIDjpLQ9qQwjDXGx1BhvWnpX6U BRJ5fWsCZD1E9rjTayx6HuIOYXtqxt4BP2BEXbcgb9NOrBlAPA9F8KAD6SFUBdg/xyHYiB SvGNRn0MWLBGG0sO+oBbIlCnWraNcB0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-iYk_dbDcMga8_HnhtV3BZQ-1; Fri, 05 Jun 2020 14:27:32 -0400 X-MC-Unique: iYk_dbDcMga8_HnhtV3BZQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7FE9C107ACCD; Fri, 5 Jun 2020 18:27:31 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D46760C47; Fri, 5 Jun 2020 18:27:30 +0000 (UTC) From: Kevin Traynor To: Ting Xu Cc: Ferruh Yigit , dpdk stable Date: Fri, 5 Jun 2020 19:25:00 +0100 Message-Id: <20200605182525.22483-63-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: fix DCB set' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/efcb7a83984c594d4a74b64ff73d989e58ce3fac Thanks. Kevin. --- >From efcb7a83984c594d4a74b64ff73d989e58ce3fac Mon Sep 17 00:00:00 2001 From: Ting Xu Date: Tue, 12 May 2020 10:13:56 +0000 Subject: [PATCH] app/testpmd: fix DCB set [ upstream commit 5139bc12b0d133fd99d0a0c07f0c5a31cff0ac39 ] When set DCB in testpmd, there is a segmentation fault. It is because the local variable rss_conf in get_eth_dcb_conf() is not cleared, so that the pointer member variable rss_key has a random address, which leads to an error in the following processing. This patch initialized the local variable rss_conf to avoid this situation. Fixes: ac7c491c3fec ("app/testpmd: fix DCB config") Signed-off-by: Ting Xu Reviewed-by: Ferruh Yigit --- app/test-pmd/testpmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index b68bc54e32..a32eae750c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2935,4 +2935,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf, ð_conf->tx_adv_conf.dcb_tx_conf; + memset(&rss_conf, 0, sizeof(struct rte_eth_rss_conf)); + rc = rte_eth_dev_rss_hash_conf_get(pid, &rss_conf); if (rc != 0) -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:54.260020473 +0100 +++ 0063-app-testpmd-fix-DCB-set.patch 2020-06-05 19:20:50.896038859 +0100 @@ -1 +1 @@ -From 5139bc12b0d133fd99d0a0c07f0c5a31cff0ac39 Mon Sep 17 00:00:00 2001 +From efcb7a83984c594d4a74b64ff73d989e58ce3fac Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5139bc12b0d133fd99d0a0c07f0c5a31cff0ac39 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index baccc3a495..4989d22ca8 100644 +index b68bc54e32..a32eae750c 100644 @@ -26 +27 @@ -@@ -3461,4 +3461,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf, +@@ -2935,4 +2935,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,