From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5778AA04A3 for ; Fri, 5 Jun 2020 20:25:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 501601D51B; Fri, 5 Jun 2020 20:25:53 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 7D8FB1D510 for ; Fri, 5 Jun 2020 20:25:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mtIqtT4nEGpS3hc/3KcN8qK/3WLfv8MzHUrLmb4/j9I=; b=QY9UoCiduin7b25wUp8qUIN/5SF+WdFQMhz3Lh1SPPeB/z8RfKNiXOeUzpRXdR51rBuuwf NF5xf7D0j08mHCST9hTVELdpk5BclnXChU5yMcsgohIHiNNImJn4Ce0VY1bOSpecLVZU1e TaNHK/tKe0Kg5H1igXqAHIYVAdL+dRU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-yLFJKYIdOaW7Rbc2cbmDeA-1; Fri, 05 Jun 2020 14:25:46 -0400 X-MC-Unique: yLFJKYIdOaW7Rbc2cbmDeA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25240801503; Fri, 5 Jun 2020 18:25:45 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C35E62501; Fri, 5 Jun 2020 18:25:44 +0000 (UTC) From: Kevin Traynor To: David Christensen Cc: dpdk stable Date: Fri, 5 Jun 2020 19:24:04 +0100 Message-Id: <20200605182525.22483-7-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal/ppc: fix build with gcc 9.3' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/7976550a663afd20a3cc64b8f4890770521c926c Thanks. Kevin. --- >From 7976550a663afd20a3cc64b8f4890770521c926c Mon Sep 17 00:00:00 2001 From: David Christensen Date: Mon, 4 May 2020 14:03:47 -0700 Subject: [PATCH] eal/ppc: fix build with gcc 9.3 [ upstream commit 67889d11306a6e531be8d2fe53bc216172b90f5d ] Building DPDK on Ubuntu 20.04 with GCC 9.3.0 results in a "subscript is outside array bounds" message in rte_memcpy function. The build error is caused by an interaction between __builtin_constant_p and "-Werror=array-bounds" as described in this bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90387 Modify the code to disable the array-bounds check for GCC versions 9.0 to 9.3. Signed-off-by: David Christensen --- lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h index 75f74897b3..b194564b55 100644 --- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h @@ -38,4 +38,5 @@ /*To include altivec.h, GCC version must >= 4.8 */ #include +#include "rte_common.h" #ifdef __cplusplus @@ -45,4 +46,9 @@ extern "C" { #include "generic/rte_memcpy.h" +#if (GCC_VERSION >= 90000 && GCC_VERSION < 90400) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Warray-bounds" +#endif + static inline void rte_mov16(uint8_t *dst, const uint8_t *src) @@ -220,4 +226,8 @@ rte_memcpy_func(void *dst, const void *src, size_t n) } +#if (GCC_VERSION >= 90000 && GCC_VERSION < 90400) +#pragma GCC diagnostic pop +#endif + #ifdef __cplusplus } -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:51.329987618 +0100 +++ 0007-eal-ppc-fix-build-with-gcc-9.3.patch 2020-06-05 19:20:50.707043153 +0100 @@ -1 +1 @@ -From 67889d11306a6e531be8d2fe53bc216172b90f5d Mon Sep 17 00:00:00 2001 +From 7976550a663afd20a3cc64b8f4890770521c926c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 67889d11306a6e531be8d2fe53bc216172b90f5d ] + @@ -16,2 +17,0 @@ -Cc: stable@dpdk.org - @@ -20 +20 @@ - lib/librte_eal/ppc/include/rte_memcpy.h | 10 ++++++++++ + lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h | 10 ++++++++++ @@ -23,7 +23,7 @@ -diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h b/lib/librte_eal/ppc/include/rte_memcpy.h -index d685b7b15b..c2a1f356d5 100644 ---- a/lib/librte_eal/ppc/include/rte_memcpy.h -+++ b/lib/librte_eal/ppc/include/rte_memcpy.h -@@ -11,4 +11,5 @@ - - #include "rte_altivec.h" +diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h +index 75f74897b3..b194564b55 100644 +--- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h ++++ b/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h +@@ -38,4 +38,5 @@ + /*To include altivec.h, GCC version must >= 4.8 */ + #include @@ -33 +33 @@ -@@ -18,4 +19,9 @@ extern "C" { +@@ -45,4 +46,9 @@ extern "C" { @@ -43 +43 @@ -@@ -193,4 +199,8 @@ rte_memcpy_func(void *dst, const void *src, size_t n) +@@ -220,4 +226,8 @@ rte_memcpy_func(void *dst, const void *src, size_t n)