patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	dev@dpdk.org, haiyue.wang@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] mbuf: remove unused next member
Date: Tue, 9 Jun 2020 09:17:29 +0200
Message-ID: <20200609071729.GP12564@platinum> (raw)
In-Reply-To: <20200609052955.59196-1-xiaolong.ye@intel.com>

Hi Xialong,

On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote:
> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and
> mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's
> next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te,
> next).
> 
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>

Good catch, I forgot to remove this field which was used in former
implementations. Thanks!

I suggest to update the title to highlight it's about dynamic mbuf:
  mbuf: remove unused next member in dyn flag/field

Apart from this:
Acked-by: Olivier Matz <olivier.matz@6wind.com>

> ---
> 
> I found this issue when reading the mbuf dynfiled/dynflag feature code,
> mbuf_autotest is passed with this change, though I may miss something or
> this filed has some special design purpose, please correct me if I am
> wrong.
> 
>  lib/librte_mbuf/rte_mbuf_dyn.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf_dyn.c b/lib/librte_mbuf/rte_mbuf_dyn.c
> index d6931f847..953e3ec31 100644
> --- a/lib/librte_mbuf/rte_mbuf_dyn.c
> +++ b/lib/librte_mbuf/rte_mbuf_dyn.c
> @@ -19,7 +19,6 @@
>  #define RTE_MBUF_DYN_MZNAME "rte_mbuf_dyn"
>  
>  struct mbuf_dynfield_elt {
> -	TAILQ_ENTRY(mbuf_dynfield_elt) next;
>  	struct rte_mbuf_dynfield params;
>  	size_t offset;
>  };
> @@ -31,7 +30,6 @@ static struct rte_tailq_elem mbuf_dynfield_tailq = {
>  EAL_REGISTER_TAILQ(mbuf_dynfield_tailq);
>  
>  struct mbuf_dynflag_elt {
> -	TAILQ_ENTRY(mbuf_dynflag_elt) next;
>  	struct rte_mbuf_dynflag params;
>  	unsigned int bitnum;
>  };
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2020-06-09  7:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  5:29 Xiaolong Ye
2020-06-09  7:12 ` [dpdk-stable] [PATCH v2] mbuf: remove unused next member in dyn flag/field Xiaolong Ye
2020-06-11  7:42   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-06-09  7:17 ` Olivier Matz [this message]
2020-06-09  7:15   ` [dpdk-stable] [PATCH] mbuf: remove unused next member Ye Xiaolong
2020-06-09 15:29     ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2020-06-10  0:54       ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609071729.GP12564@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git