From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D603A04A3 for ; Tue, 16 Jun 2020 15:33:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8249B1BF84; Tue, 16 Jun 2020 15:33:23 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id BA1CF1BF84 for ; Tue, 16 Jun 2020 15:33:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592314402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/mJiuRdE2EJXxwqbz/2+IsVvn+NCe45OV2wq1/VAocw=; b=Yp7UFL96DvBBZqtubAFLRt4xffo/YhhBWTYk1+6ONKxvdx/H/rAoXKwAdjBVu/sOtwWcTk /GzPPXKWP8x3fEQNkvXVq0VdZ/EDdkKMm4HmRBsfUb6jwnL3Z4ky+MzLoREAc5jGzXjkXi Tgj149ZVKCCKElaTZfmKNDvvXR6xqe4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-gtJDdYCWOheiM5IgaRMC2Q-1; Tue, 16 Jun 2020 09:33:14 -0400 X-MC-Unique: gtJDdYCWOheiM5IgaRMC2Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DFD29873429; Tue, 16 Jun 2020 13:33:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0AB3D5D9DA; Tue, 16 Jun 2020 13:33:09 +0000 (UTC) From: Kevin Traynor To: Timothy Redaelli Cc: Anoob Joseph , dpdk stable Date: Tue, 16 Jun 2020 14:33:03 +0100 Message-Id: <20200616133304.6812-3-ktraynor@redhat.com> In-Reply-To: <20200616133304.6812-1-ktraynor@redhat.com> References: <20200616133304.6812-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'crypto/octeontx: fix build with gcc 10' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/bb5bca6083c1f6fe7f2797e5e54dc67c7d2ca61d Thanks. Kevin. --- >From bb5bca6083c1f6fe7f2797e5e54dc67c7d2ca61d Mon Sep 17 00:00:00 2001 From: Timothy Redaelli Date: Tue, 16 Jun 2020 11:18:40 +0100 Subject: [PATCH] crypto/octeontx: fix build with gcc 10 [ upstream commit 983ab2b5d05c40a7b1a4da2200fd028e99796ee7 ] GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton") Signed-off-by: Timothy Redaelli Acked-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev.c | 2 ++ drivers/crypto/octeontx/otx_cryptodev.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c index c3076487f7..d48fd1971c 100644 --- a/drivers/crypto/octeontx/otx_cryptodev.c +++ b/drivers/crypto/octeontx/otx_cryptodev.c @@ -18,4 +18,6 @@ static int otx_cryptodev_logtype; +uint8_t otx_cryptodev_driver_id; + static struct rte_pci_id pci_id_cpt_table[] = { { diff --git a/drivers/crypto/octeontx/otx_cryptodev.h b/drivers/crypto/octeontx/otx_cryptodev.h index 6c2871d712..0b204320a2 100644 --- a/drivers/crypto/octeontx/otx_cryptodev.h +++ b/drivers/crypto/octeontx/otx_cryptodev.h @@ -16,5 +16,5 @@ * Crypto device driver ID */ -uint8_t otx_cryptodev_driver_id; +extern uint8_t otx_cryptodev_driver_id; #endif /* _OTX_CRYPTODEV_H_ */ -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-16 14:31:16.073361563 +0100 +++ 0003-crypto-octeontx-fix-build-with-gcc-10.patch 2020-06-16 14:31:15.915226629 +0100 @@ -1 +1 @@ -From 983ab2b5d05c40a7b1a4da2200fd028e99796ee7 Mon Sep 17 00:00:00 2001 +From bb5bca6083c1f6fe7f2797e5e54dc67c7d2ca61d Mon Sep 17 00:00:00 2001 @@ -3,2 +3,4 @@ -Date: Wed, 5 Feb 2020 13:50:41 +0100 -Subject: [PATCH] crypto/octeontx2: fix build with gcc 10 +Date: Tue, 16 Jun 2020 11:18:40 +0100 +Subject: [PATCH] crypto/octeontx: fix build with gcc 10 + +[ upstream commit 983ab2b5d05c40a7b1a4da2200fd028e99796ee7 ] @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -16,4 +17,3 @@ - drivers/crypto/octeontx2/otx2_cryptodev.c | 2 ++ - drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +- - drivers/crypto/octeontx2/otx2_cryptodev_ops.h | 2 +- - 3 files changed, 4 insertions(+), 2 deletions(-) + drivers/crypto/octeontx/otx_cryptodev.c | 2 ++ + drivers/crypto/octeontx/otx_cryptodev.h | 2 +- + 2 files changed, 3 insertions(+), 1 deletion(-) @@ -21,6 +21,6 @@ -diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c -index 7b8add1bfc..417eda6de6 100644 ---- a/drivers/crypto/octeontx2/otx2_cryptodev.c -+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c -@@ -25,4 +25,6 @@ - int otx2_cpt_logtype; +diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c +index c3076487f7..d48fd1971c 100644 +--- a/drivers/crypto/octeontx/otx_cryptodev.c ++++ b/drivers/crypto/octeontx/otx_cryptodev.c +@@ -18,4 +18,6 @@ + static int otx_cryptodev_logtype; @@ -28 +28 @@ -+uint8_t otx2_cryptodev_driver_id; ++uint8_t otx_cryptodev_driver_id; @@ -32,5 +32,5 @@ -diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h b/drivers/crypto/octeontx2/otx2_cryptodev.h -index 8e0ebc292a..c0aa661b3b 100644 ---- a/drivers/crypto/octeontx2/otx2_cryptodev.h -+++ b/drivers/crypto/octeontx2/otx2_cryptodev.h -@@ -39,5 +39,5 @@ extern int otx2_cpt_logtype; +diff --git a/drivers/crypto/octeontx/otx_cryptodev.h b/drivers/crypto/octeontx/otx_cryptodev.h +index 6c2871d712..0b204320a2 100644 +--- a/drivers/crypto/octeontx/otx_cryptodev.h ++++ b/drivers/crypto/octeontx/otx_cryptodev.h +@@ -16,5 +16,5 @@ @@ -39,13 +39,2 @@ --uint8_t otx2_cryptodev_driver_id; -+extern uint8_t otx2_cryptodev_driver_id; - - #endif /* _OTX2_CRYPTODEV_H_ */ -diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h -index a2724f7227..f83e36b486 100644 ---- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h -+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h -@@ -17,5 +17,5 @@ enum otx2_cpt_egrp { - }; - --struct rte_cryptodev_ops otx2_cpt_ops; -+extern struct rte_cryptodev_ops otx2_cpt_ops; +-uint8_t otx_cryptodev_driver_id; ++extern uint8_t otx_cryptodev_driver_id; @@ -53 +42 @@ - #endif /* _OTX2_CRYPTODEV_OPS_H_ */ + #endif /* _OTX_CRYPTODEV_H_ */