From: Fady Bader <fady@mellanox.com>
To: dev@dpdk.org
Cc: talshn@mellanox.com, fady@mellanox.com, thomasm@mellanox.com,
tbashar@mellanox.com, harini.ramakrishnan@microsoft.com,
ocardona@microsoft.com, pallavi.kadam@intel.com,
ranjit.menon@intel.com, cristian.dumitrescu@intel.com,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2] meter: remove inline functions from export list
Date: Wed, 17 Jun 2020 11:24:31 +0300 [thread overview]
Message-ID: <20200617082431.23156-1-fady@mellanox.com> (raw)
In-Reply-To: <20200617081507.22868-1-fady@mellanox.com>
The code didn't compile when using exported meter functions under windows.
error LNK2001: unresolved external symbol
rte_meter_srtcm_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_srtcm_color_blind_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_color_blind_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_blind_check
The cause was that there were some inline functions that were included in
the export list.
To solve this the functions were removed from rte_meter_version.map export
list which are implemented in the header and shouldn't be exported.
Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM")
Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning")
Cc: stable@dpdk.org
Signed-off-by: Fady Bader <fady@mellanox.com>
---
v2: fixed commit message style issue
---
lib/librte_meter/rte_meter_version.map | 6 ------
1 file changed, 6 deletions(-)
diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map
index b493bcebe9..58859d4d76 100644
--- a/lib/librte_meter/rte_meter_version.map
+++ b/lib/librte_meter/rte_meter_version.map
@@ -1,12 +1,8 @@
DPDK_20.0 {
global:
- rte_meter_srtcm_color_aware_check;
- rte_meter_srtcm_color_blind_check;
rte_meter_srtcm_config;
rte_meter_srtcm_profile_config;
- rte_meter_trtcm_color_aware_check;
- rte_meter_trtcm_color_blind_check;
rte_meter_trtcm_config;
rte_meter_trtcm_profile_config;
@@ -16,8 +12,6 @@ DPDK_20.0 {
DPDK_21 {
global:
- rte_meter_trtcm_rfc4115_color_aware_check;
- rte_meter_trtcm_rfc4115_color_blind_check;
rte_meter_trtcm_rfc4115_config;
rte_meter_trtcm_rfc4115_profile_config;
--
2.16.1.windows.4
next prev parent reply other threads:[~2020-06-17 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:15 [dpdk-stable] [PATCH] " Fady Bader
2020-06-17 8:24 ` Fady Bader [this message]
2020-06-23 17:36 ` [dpdk-stable] [PATCH v2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617082431.23156-1-fady@mellanox.com \
--to=fady@mellanox.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomasm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).