From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E438EA04F1 for ; Thu, 18 Jun 2020 03:46:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAC082BF4; Thu, 18 Jun 2020 03:46:01 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) by dpdk.org (Postfix) with ESMTP id 3FB741023; Thu, 18 Jun 2020 03:45:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dpUb+Xv3YYSSxrZ4Mj8rhDrc+iV5P6cFnPap3VGmjjqDx0r2ZsWw9vIXDtyhwLBJl4ab8ILtIEGqpx6KLKV9HDEQSdgmJfmWSvTcKTSGNxd5MtEZW16uepTowE6yi6F7tCCtz7VuVV/fCX4oYQyv8cFm95rGWAZifrcmjO3e43VKIWcYnAEri+NPIyuTyBN89OYcWFNBrZYX4rSyGoqbDBjsizD6Co/XxGkd1sk1l3dFy0xpBqZm67kdVvLgDKMCQTco3rUxo54YhXowCf933k4w+Hyu6tICWYykjRmx8CEy1m1LEaSHgWzgSgWW7EzWylTFa3Vhb4sKAsxm3A2rWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/a24qyqnoPALLSOukUl9NKSvRxNkKpfAqqgahCAE3uo=; b=FiuGA1t/Xwsbz40IGYltAGzCgb5lHKBX78+KpFXw+9W+zI2x2nF+49drXueEbhaERmk8aws29cbMsqCAd9Xuiud9xeDVcfQImfwoNluSBjLWUg/kUYB7vpmZjhj4FdKWs/CzKbnL7SaL4Eo6gJ7YR9aBagQavpTDvVMTEys1Aw9DsJZZh1k/nnP3YsqwH+ylq4/3n1lYIAgM0Hb/ZlgEmttDoyNkUhiFLcmjvHD/QBM6JZF2At+h82jfwXWL13Xqfmu19/hb0Ugpp8jxVFVQwyjUMIKbKsqNCmljilCfpbjAnxpZYLIxZ76fnvXjEcsPlAYRMbZhY6H44oRKl/TuJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/a24qyqnoPALLSOukUl9NKSvRxNkKpfAqqgahCAE3uo=; b=Cy4Jm04zxfXNDTEnw6/OHMIattPdI7VxPhzJZQRce0m1mr8f8OCXxYvbWwRCOEVAcaAw8VChraL574PacaWIYT0DGtfl18iBnMAbRTGt+ROocQl1EkYUoou9EvU7mx/N2+YgYRwk52oed38cDR6qFuxiPBpKOPI0mgAi1pZKpR0= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=mellanox.com; Received: from AM6PR05MB6567.eurprd05.prod.outlook.com (2603:10a6:20b:bc::23) by AM6PR05MB5670.eurprd05.prod.outlook.com (2603:10a6:20b:2b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Thu, 18 Jun 2020 01:45:57 +0000 Received: from AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::b086:817d:905b:e1d3]) by AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::b086:817d:905b:e1d3%7]) with mapi id 15.20.3088.029; Thu, 18 Jun 2020 01:45:57 +0000 Date: Thu, 18 Jun 2020 09:45:35 +0800 From: Xiaoyu Min To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Bing Zhao Message-ID: <20200618014535.ik4dsw7qpvf7nbjr@mellanox.com> References: <20200617135325.9998-1-david.marchand@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617135325.9998-1-david.marchand@redhat.com> User-Agent: NeoMutt/20180716 X-ClientProxiedBy: HK2PR03CA0045.apcprd03.prod.outlook.com (2603:1096:202:17::15) To AM6PR05MB6567.eurprd05.prod.outlook.com (2603:10a6:20b:bc::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (2408:8025:34e:fa0:4c79:37ab:a156:2a29) by HK2PR03CA0045.apcprd03.prod.outlook.com (2603:1096:202:17::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.10 via Frontend Transport; Thu, 18 Jun 2020 01:45:49 +0000 X-Originating-IP: [2408:8025:34e:fa0:4c79:37ab:a156:2a29] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 5245088b-2aa2-4009-de80-08d8132957f8 X-MS-TrafficTypeDiagnostic: AM6PR05MB5670: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:849; X-Forefront-PRVS: 0438F90F17 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HMfkP/jrkRqqA2E08Qy39aGzeIlx2V/zhGICd2X/8SBaTKOXkiPfafn00tQB5sALVX3E4KMHpU/01ZwMj2DVe1nU8x9qT3BqmeRsmyqLn/GmfJmQtyvX60osVIpErFvs48sYTHNCKYEoPXm6heNgjQFZ9ILmBu+qbSVs3JxZKI6e5PqDqlawAmmQK6zltFhfSoqYMr3KSoRVVhjdWNIuFY6aWMyXBxBPKC4emqcfW0YUYuPFxXxvLxLLtCQesfExMPxRpgohXbSK6Kbi6jzwVzrz4b7k6TPkbr2Vrd/Fb9kJQQjzifyFz3+W2rw1BDn0XLKuU4OOhfyn8NrUbosm0w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB6567.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(396003)(39860400002)(136003)(376002)(66476007)(66556008)(66946007)(54906003)(36756003)(1076003)(478600001)(316002)(2616005)(55016002)(6666004)(4326008)(86362001)(8936002)(186003)(5660300002)(2906002)(6916009)(7696005)(8886007)(107886003)(83380400001)(8676002)(52116002)(16526019); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: RIx9eETdqO2oIv2KEZUm5QMH/WvtTBYVxM5Pl3TpTFcLByuzZsKT7Sq85MTjpLWVQ8BUOU4UdVrt4jjs5wyyy9um26T0L03wSO5T4hEdsWTfMXlJX5RrJh1R2iv9N7gaYHi+TeOJve6nQyrWM+n8D+mZ8xZSPYfgiON6rUggQ9e+qIIO/cr8T2oGIL0X+mL8kgL15iWnnNY5OXkmmq8QMP+zSItnkDvAbACTFZQ4LqYpOAKVr3/OcIJIt+VLBwUmaoh6XDZMEq8/cQCWikHjRtsJcJoP9VhCOK/mXTKCLuHWyAehbUdkvQ+5NEXLPNt7DT5U74R+R/OqrwYQRTWzh/CDTfQI2RWEvNz7HOBRZ2ZdLJoxAAEu1+oY3Co+r74bo/5//5TgXyRZkU8rNRltLETkV1K8YYNQIcylGLBhelZcFI3mX4kWloFzCUh6bC2k5d4RCyFmpsZAHHfaHk4LJyI0/lZ1DGriaAWHOeabQWY/fR8JukS2YPvbOaqtDp7AGjPuwEjVZ94+8YBilwUwMBhHgkJiTGLqq1omMEL4T+g= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5245088b-2aa2-4009-de80-08d8132957f8 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2020 01:45:57.0885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jled/v7VyU6kK9zyod+tz9jO1auG/oULdgwgbdTX2j2wdB3cYmYoKtdNRSoWvCqAZ/kITuFdCozLHmRMCQ1hzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5670 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: remove redundant newline X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 20-06-17, 15:53, David Marchand wrote: > The DRV_LOG macro already appends a newline. > > Fixes: 46287eacc1b1 ("net/mlx5: introduce hash list") > Fixes: 860897d2895a ("net/mlx5: reorganize flow tables with hash list") > Fixes: e484e4032332 ("net/mlx5: optimize tag traversal with hash list") > Fixes: 6801116688fe ("net/mlx5: fix multiple flow table hash list") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Acked-by: Xiaoyu Min > --- > drivers/net/mlx5/mlx5.c | 6 +++--- > drivers/net/mlx5/mlx5_utils.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 95a0f337fe..fe7ed4899a 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1062,7 +1062,7 @@ mlx5_alloc_table_hash_list(struct mlx5_priv *priv) > snprintf(s, sizeof(s), "%s_flow_table", priv->sh->ibdev_name); > sh->flow_tbls = mlx5_hlist_create(s, MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE); > if (!sh->flow_tbls) { > - DRV_LOG(ERR, "flow tables with hash creation failed.\n"); > + DRV_LOG(ERR, "flow tables with hash creation failed."); > err = ENOMEM; > return err; > } > @@ -1146,7 +1146,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > if (!sh->flow_tbls) > err = mlx5_alloc_table_hash_list(priv); > else > - DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, reuse\n", > + DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, reuse", > (void *)sh->flow_tbls); > if (err) > return err; > @@ -1154,7 +1154,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > snprintf(s, sizeof(s), "%s_tags", sh->ibdev_name); > sh->tag_table = mlx5_hlist_create(s, MLX5_TAGS_HLIST_ARRAY_SIZE); > if (!sh->tag_table) { > - DRV_LOG(ERR, "tags with hash creation failed.\n"); > + DRV_LOG(ERR, "tags with hash creation failed."); > err = ENOMEM; > goto error; > } > diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c > index d29fbcbc83..6f3ba7ca49 100644 > --- a/drivers/net/mlx5/mlx5_utils.c > +++ b/drivers/net/mlx5/mlx5_utils.c > @@ -20,7 +20,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > if (!rte_is_power_of_2(size)) { > act_size = rte_align32pow2(size); > DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power of 2, will " > - "be aligned to 0x%" PRIX32 ".\n", size, act_size); > + "be aligned to 0x%" PRIX32 ".", size, act_size); > } else { > act_size = size; > } > @@ -29,7 +29,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > /* Using zmalloc, then no need to initialize the heads. */ > h = rte_zmalloc(name, alloc_size, RTE_CACHE_LINE_SIZE); > if (!h) { > - DRV_LOG(ERR, "No memory for hash list %s creation\n", > + DRV_LOG(ERR, "No memory for hash list %s creation", > name ? name : "None"); > return NULL; > } > @@ -37,7 +37,7 @@ mlx5_hlist_create(const char *name, uint32_t size) > snprintf(h->name, MLX5_HLIST_NAMESIZE, "%s", name); > h->table_sz = act_size; > h->mask = act_size - 1; > - DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is created.\n", > + DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is created.", > h->name, act_size); > return h; > } > -- > 2.23.0 >