From: Bruce Richardson <bruce.richardson@intel.com>
To: Timothy Redaelli <tredaelli@redhat.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] app/test: fix rpath for drivers in meson build
Date: Thu, 2 Jul 2020 12:01:54 +0100 [thread overview]
Message-ID: <20200702110154.GE611@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200702124206.76a2cbc2@aldebaran>
On Thu, Jul 02, 2020 at 12:42:06PM +0200, Timothy Redaelli wrote:
> On Thu, 2 Jul 2020 10:16:48 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > On Wed, Jul 01, 2020 at 07:16:38PM +0200, Timothy Redaelli wrote:
> > > This commit fixes the setting of relative rpath on dpdk-test for
> > > drivers ($libdir/dpdk/pmd-$abiver) to the correct absolute rpath
> > > ($prefix$libdir/dpdk/pmd-$abiver)
> > >
> > > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> > > Cc: harry.van.haaren@intel.com
> > > Cc: stable@dpdk.org
> > > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > > ---
> > > app/test/meson.build | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > I'm not sure I agree with this change. It's better to have a relative
> > rather than absolute rpath, I think. What problems is it causing to have a
> > relative vs absolute rpath?
> >
>
> I only backported the same fix done in app/meson.build since,
> currently, app/test/meson.build adds a rpath to "lib64/dpdk/pmd-20.0"
> that doesn't exists since, in this case, it should be
> "../lib64/dpdk/pmd-20.0" on Fedora, or
> "../lib/x86_64-linux-gnu/dpdk/pmds-20.0" on Debian.
>
> If we want relative paths we should change "install_rpath:" line on
> app/meson.build too.
>
> Debian workarounded that bug by stripping rpaths from dpdk-test [1],
> but I'd like to avoid doing that on Fedora/RHEL too, when we'll
> migrate to meson, since currently check-rpaths (invoked by rpmbuild) is
> complaining about the invalid rpath:
>
> ERROR 0002: file '/usr/bin/dpdk-test' contains an invalid rpath
> 'lib64/dpdk/pmds-20.0' in [lib64/dpdk/pmds-20.0]
>
> [1]
> https://salsa.debian.org/debian/dpdk/-/blob/unstable/debian/rules#L175
>
Ok, in that case no problem:
Acked-by: Bruce Richarson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2020-07-02 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 17:16 Timothy Redaelli
2020-07-02 9:16 ` Bruce Richardson
2020-07-02 10:42 ` Timothy Redaelli
2020-07-02 11:01 ` Bruce Richardson [this message]
2020-07-07 11:32 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702110154.GE611@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).