patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/i40e: fix getting eeprom information
@ 2020-07-02 12:37 Pavel Ivashchenko
  2020-07-05 13:24 ` [dpdk-stable] [dpdk-dev] " Igor Ryzhov
  2020-07-07  2:18 ` Zhang, Qi Z
  0 siblings, 2 replies; 3+ messages in thread
From: Pavel Ivashchenko @ 2020-07-02 12:37 UTC (permalink / raw)
  To: dev; +Cc: stable

Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 970a31cb2..5fdfadf7b 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct rte_eth_dev *dev,
 		}
 		status = i40e_aq_get_phy_register(hw,
 				I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
-				addr, offset, 1, &value, NULL);
+				addr, 1, offset, &value, NULL);
 		if (status)
 			return -EIO;
 		data[i] = (uint8_t)value;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix getting eeprom information
  2020-07-02 12:37 [dpdk-stable] [PATCH] net/i40e: fix getting eeprom information Pavel Ivashchenko
@ 2020-07-05 13:24 ` Igor Ryzhov
  2020-07-07  2:18 ` Zhang, Qi Z
  1 sibling, 0 replies; 3+ messages in thread
From: Igor Ryzhov @ 2020-07-05 13:24 UTC (permalink / raw)
  To: Pavel Ivashchenko; +Cc: dev, dpdk stable, Beilei Xing, jia.guo

CCing i40e maintainers.
This is a trivial fix without which getting module EEPROM doesn't work at
all.

On Thu, Jul 2, 2020 at 3:37 PM Pavel Ivashchenko <pivashchenko@nfware.com>
wrote:

> Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c
> b/drivers/net/i40e/i40e_ethdev.c
> index 970a31cb2..5fdfadf7b 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct
> rte_eth_dev *dev,
>                 }
>                 status = i40e_aq_get_phy_register(hw,
>                                 I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
> -                               addr, offset, 1, &value, NULL);
> +                               addr, 1, offset, &value, NULL);
>                 if (status)
>                         return -EIO;
>                 data[i] = (uint8_t)value;
> --
> 2.25.1
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix getting eeprom information
  2020-07-02 12:37 [dpdk-stable] [PATCH] net/i40e: fix getting eeprom information Pavel Ivashchenko
  2020-07-05 13:24 ` [dpdk-stable] [dpdk-dev] " Igor Ryzhov
@ 2020-07-07  2:18 ` Zhang, Qi Z
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2020-07-07  2:18 UTC (permalink / raw)
  To: Pavel Ivashchenko, dev; +Cc: stable



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Pavel Ivashchenko
> Sent: Thursday, July 2, 2020 8:37 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix getting eeprom information
> 
> Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-07  2:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 12:37 [dpdk-stable] [PATCH] net/i40e: fix getting eeprom information Pavel Ivashchenko
2020-07-05 13:24 ` [dpdk-stable] [dpdk-dev] " Igor Ryzhov
2020-07-07  2:18 ` Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git