patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: nipun.gupta@nxp.com, hemant.agrawal@nxp.com, dev@dpdk.org,
	stable@dpdk.org, bluca@debian.org, ktraynor@redhat.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/3] rawdev: allow calling info function for unknown rawdevs
Date: Tue, 7 Jul 2020 13:31:03 +0100
Message-ID: <20200707123103.GA651@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <227734353.nfkpUBtnmh@thomas>

On Tue, Jul 07, 2020 at 02:18:31PM +0200, Thomas Monjalon wrote:
> 06/07/2020 12:31, Bruce Richardson:
> > To call the rte_rawdev_info_get() function, the user currently has to
> > know the underlying type of the device in order to pass an appropriate
> > structure or buffer as the dev_private pointer in the info structure.
> > By allowing a NULL value for this field, we can skip getting the
> > device-specific info and just return the generic info - including the
> > device name and driver, which can be used to determine the device type
> > - to the user.
> > 
> > This ensures that basic info can be get for all rawdevs, without
> > knowing the type, and even if the info driver API call has not been
> > implemented for the device.
> > 
> > Cc: stable@dpdk.org
> 
> This is a new feature. Why should it be backported?
> 

I'd largely leave it up to the stable maintainers, but IMHO it should be
backported as its not a big change and I don't see the existing rawdev APIs
as very usable without it. I think the current API leaves the user in a bit
of a catch 22, since info_get() is the API you'd expect to call to find out
the actual type of a rawdev, but unfortunately, to call the info_get API
you need to know the type to pass in the appropriate type-specific
structure parameter. Therefore I see this as fixing a usability bug. :-)

Regards,
/Bruce

  reply	other threads:[~2020-07-07 12:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200706103132.7691-1-bruce.richardson@intel.com>
2020-07-06 10:31 ` [dpdk-stable] " Bruce Richardson
2020-07-07  3:40   ` Hemant Agrawal
2020-07-07 12:18   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-07-07 12:31     ` Bruce Richardson [this message]
2020-07-06 10:31 ` [dpdk-stable] [PATCH 2/3] rawdev: return NUMA socket id to the user Bruce Richardson
2020-07-07  3:40   ` Hemant Agrawal
2020-07-07 12:23   ` Thomas Monjalon
2020-07-07 12:33     ` Bruce Richardson
2020-07-06 10:31 ` [dpdk-stable] [PATCH 3/3] rawdev: fix missing dump function in map file Bruce Richardson
2020-07-07  3:40   ` Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707123103.GA651@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=ktraynor@redhat.com \
    --cc=nipun.gupta@nxp.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git