From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4C77A052A for ; Fri, 10 Jul 2020 16:27:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AADB91DAD2; Fri, 10 Jul 2020 16:27:31 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 6D1CB1DAD2 for ; Fri, 10 Jul 2020 16:27:30 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id g10so8587697wmc.1 for ; Fri, 10 Jul 2020 07:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gdes89iMVxZMcmLuBhTMjj2meOWpJztr8mGvaMpoJNo=; b=xW2if2vbsNYjKETQU30rXJX2aoKgEPD7ciTgHAnrBZb0paMLHeD25gBlxP3jfDA0vA 6VBOwjUucayjPVWU0F5pNjVpWvk7yMPDylt+qEA+88neAkZSZNG4Y95e6IcELrUqifTj 1wmmbCXPuHDYu86QTVlA+Pev0NMZdHIpNeaf6lxwQ9N4Og1RI3eDtasoCWkddhePw73X g/2wfnn+6fj4tJse02ei1n04DSDZwN90f/h8IUjPo0u+nYzn92mlEwtr26jTvgcDSMHV dIR8ZYa4MSZHrT9k78n4qe8rPxkc1aq7qVID4oOuzywg4ClBfJv/1iuu4RvV5sZRTcWi B7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gdes89iMVxZMcmLuBhTMjj2meOWpJztr8mGvaMpoJNo=; b=hZTVVuPZO+6f33bbrZNHw9fLQAOgkJjyoOHa5CQTjOzOZyEbAsXdZ8YTENhkLElWlY A0aQgJX3m/3NNXf/aOVymg3XcdIfk3QCHtDkCOLnv2o0ifVgnWRK+z9ZOqoYDNdNKrlK MFfbjV7c3bj9PYas2BCqZnFLYBIL8HjQnR1ddU9BbUYAVdkdvL3CveoAgUDnD+A3Y/Yf lrfYLhDtZvqeL4m4EV4HE9p52UHVgY6wmtsz3fQvrYlKu20x95fAkWJ7Tu09J2+tvXjQ buAsL+2I2rfiJwjMOguyF+05BdoLZ4Us6a6VfgEv/TnsVfEonOf7fqs/AAlvI7PAKa2e GrUQ== X-Gm-Message-State: AOAM53240YDg58BzK74YFz+wCPQ/qVfCH9hlJywZ2XozFhTnAYvpA/cl mM0uPGcevTSnb4kprB3lEw+U X-Google-Smtp-Source: ABdhPJx+I/pAyWMMwq7kadcHLxSZdJ5r6cMTTJVwhxXN3xb5ONBucRd03h5cARhbfqd/usIdGBZyYw== X-Received: by 2002:a1c:449:: with SMTP id 70mr5074010wme.149.1594391250105; Fri, 10 Jul 2020 07:27:30 -0700 (PDT) Received: from localhost.localdomain (dsl-197-245-84-180.voxdsl.co.za. [197.245.84.180]) by smtp.gmail.com with ESMTPSA id 63sm11309674wra.86.2020.07.10.07.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 07:27:29 -0700 (PDT) From: Heinrich Kuhn To: heinrich.kuhn@netronome.com Cc: stable@dpdk.org, Simon Horman Date: Fri, 10 Jul 2020 16:27:22 +0200 Message-Id: <20200710142722.13993-1-heinrich.kuhn@netronome.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH] net/nfp: fix RSS hash configuration reporting X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get callback did not propagate the current hardware state of rss_hf back up to the caller. Users of the hash_conf_get callback would receive an incorrect representation of what the RSS configuration currently is in hardware. Fixes: 934e4c60fbff ("nfp: add RSS") Cc: stable@dpdk.org Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/nfp_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 88e3f01d6..f47200cc4 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2626,6 +2626,9 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6) rss_hf |= ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP; + /* Propagate current RSS hash functions to caller */ + rss_conf->rss_hf = rss_hf; + /* Reading the key size */ rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ); -- 2.26.2