From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93CF6A053D for ; Fri, 17 Jul 2020 18:32:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2C231BF5B; Fri, 17 Jul 2020 18:32:55 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 6ECAD1BEC0 for ; Fri, 17 Jul 2020 18:32:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595003574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ntj9b6B2Xj7Bgf63/5Pkrmn44rCmlsQsxTsUWY52RQY=; b=eGKEtYyGtyQGNIvbpATGww9eM0hbEHR8hPLtCujhhxNwcxNrGZUsTPQl+MxN7W6gA1xYVt lCklLnRcuyXrAPgVsqMsBUWh9CHN7WH4gHP8/cT/OtwRhLMbHVOrMRQOCNAxe3g1l3KgHk Ried3yT0w+R/YzOkulp9/5tsiwxQvOU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-70UQueuXOA-tm-x88zOk2w-1; Fri, 17 Jul 2020 12:32:44 -0400 X-MC-Unique: 70UQueuXOA-tm-x88zOk2w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B69B1085; Fri, 17 Jul 2020 16:32:43 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6794A75559; Fri, 17 Jul 2020 16:32:42 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Liron Himi , dpdk stable Date: Fri, 17 Jul 2020 17:32:01 +0100 Message-Id: <20200717163214.4839-13-ktraynor@redhat.com> In-Reply-To: <20200717163214.4839-1-ktraynor@redhat.com> References: <20200717163214.4839-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mvpp2: fix non-EAL thread support' has been queued to LTS release 18.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/978be5abe162b5ebe1be3eb0d74fdfeedbbaa9bc Thanks. Kevin. --- >From 978be5abe162b5ebe1be3eb0d74fdfeedbbaa9bc Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 16 Jun 2020 11:47:00 +0200 Subject: [PATCH] net/mvpp2: fix non-EAL thread support [ upstream commit b52d25ae4b1bbe9adba0d9276b7771ec27e3d151 ] Caught by code inspection, for a non-EAL thread identified with rte_lcore_id() == LCORE_ID_ANY, the code currently arbitrarily uses lcore 0 while there is no guarantee this lcore is used. Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation") Signed-off-by: David Marchand Acked-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index ab4c14e513..97842fba76 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -813,5 +813,5 @@ mrvl_flush_bpool(struct rte_eth_dev *dev) if (core_id == LCORE_ID_ANY) - core_id = 0; + core_id = rte_get_master_lcore(); hif = mrvl_get_hif(priv, core_id); @@ -1565,5 +1565,5 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num) core_id = rte_lcore_id(); if (core_id == LCORE_ID_ANY) - core_id = 0; + core_id = rte_get_master_lcore(); hif = mrvl_get_hif(rxq->priv, core_id); @@ -1715,5 +1715,5 @@ mrvl_rx_queue_release(void *rxq) if (core_id == LCORE_ID_ANY) - core_id = 0; + core_id = rte_get_master_lcore(); if (!q) -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-17 17:17:00.725364479 +0100 +++ 0013-net-mvpp2-fix-non-EAL-thread-support.patch 2020-07-17 17:16:59.985771318 +0100 @@ -1 +1 @@ -From b52d25ae4b1bbe9adba0d9276b7771ec27e3d151 Mon Sep 17 00:00:00 2001 +From 978be5abe162b5ebe1be3eb0d74fdfeedbbaa9bc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b52d25ae4b1bbe9adba0d9276b7771ec27e3d151 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index b98b1fd667..9037274327 100644 +index ab4c14e513..97842fba76 100644 @@ -23 +24 @@ -@@ -817,5 +817,5 @@ mrvl_flush_bpool(struct rte_eth_dev *dev) +@@ -813,5 +813,5 @@ mrvl_flush_bpool(struct rte_eth_dev *dev) @@ -30 +31 @@ -@@ -1621,5 +1621,5 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num) +@@ -1565,5 +1565,5 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num) @@ -37 +38 @@ -@@ -1771,5 +1771,5 @@ mrvl_rx_queue_release(void *rxq) +@@ -1715,5 +1715,5 @@ mrvl_rx_queue_release(void *rxq)