From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83380A0518 for ; Fri, 24 Jul 2020 14:07:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 794221C134; Fri, 24 Jul 2020 14:07:33 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 4A6CE1C134 for ; Fri, 24 Jul 2020 14:07:32 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id 88so8093957wrh.3 for ; Fri, 24 Jul 2020 05:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8FZVJxgaDHdktRU4pV+oPpMm1UTLcqz1LGipZhkguwc=; b=oJ5iQJ9lL5pW+tf0MQo9imopw+MXT9RjdUZyoKqu/3NwPjeqV6NWIuevZgQQNE7MTo acxmS0M4j200s5TTnHXPfZMoLaxndFS8BokqCQ2jEANhT6rOfWlIPZ+6bp5/uFYK7A6y T1PzPJicpLDqaXYvsy/uNvthYsugn4LHl5Z7SdEFvLDgZvmeIaRaKCtEIbs7ays+uBS0 E/N+h57vl2GnchU99CPZQldi1ezpR16yp5/laGBBKMdxnCsIJ3+woFFKnfyyH3rZ0dNh pEmZL0eelWc+ggSiusSby483c3WMQpL+BuQ9KhQhouM1zmoY3Du6ad/A3rpxXdXiqfi5 Fr/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8FZVJxgaDHdktRU4pV+oPpMm1UTLcqz1LGipZhkguwc=; b=dJYZFUlSV690UxA3eaN/PoELV1HeeToZdOuGF7wjY8x4f8TXYgh3j6bTUM4qShO6UW 6w8rsMcqEa9+5nNDAV5gtbFtpnZAVKLgSaPrKBHxz0vPB2r4CixAfm3f31/LF78/oBhc d3EVdt0L1XLO4J/aK2RzrJqjMZFfrshvqjRts858EKj249jkXq9nNgGhHtR3NMWcJ0mN wNGCIDeu44pno1C7tjdGi9g5pFRz5qsuYIV5baPGbpoTqGZgMVRZ4RpCTI1g56PMsnAK xmP0vAh69+jS1v+UCdWcI4rJIUmPbE6pT41QR+4vfXRWIgJylNdNNbKaIzbTC+ammbxx rp+Q== X-Gm-Message-State: AOAM530DO9GUjJMYlv/kaYYSye05kVt70iGY7B7Z5OPhZNzLUDKv4dNj 2yewURDcgl0h2izbX/dUEVg= X-Google-Smtp-Source: ABdhPJxnIdJJLN0Vvim3ro2cvHUStYNmCMwhVOujCU5JluiZ0shMi79YE72lh//qetxxji8/UUKVKQ== X-Received: by 2002:a5d:4401:: with SMTP id z1mr8096774wrq.305.1595592451091; Fri, 24 Jul 2020 05:07:31 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s203sm7216425wms.32.2020.07.24.05.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:07:29 -0700 (PDT) From: luca.boccassi@gmail.com To: Phil Yang Cc: Dharmik Thakkar , dpdk stable Date: Fri, 24 Jul 2020 12:59:00 +0100 Message-Id: <20200724120030.1863487-102-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eventdev: remove redundant reset on timer cancel' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From d79a74d9bfe61030fbe46546f575d5028a839739 Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Tue, 7 Jul 2020 23:54:52 +0800 Subject: [PATCH] eventdev: remove redundant reset on timer cancel [ upstream commit e84d9c62c671a502022a3a81358cac702d6f3a15 ] There is no thread will access these impl_opaque data after timer canceled. When new timer armed, it got refilled. So the cleanup process is unnecessary. Signed-off-by: Phil Yang Reviewed-by: Dharmik Thakkar --- lib/librte_eventdev/rte_event_timer_adapter.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c index 678be9f0a..af5087132 100644 --- a/lib/librte_eventdev/rte_event_timer_adapter.c +++ b/lib/librte_eventdev/rte_event_timer_adapter.c @@ -1163,8 +1163,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter, rte_mempool_put(sw->tim_pool, (void **)timp); evtims[i]->state = RTE_EVENT_TIMER_CANCELED; - evtims[i]->impl_opaque[0] = 0; - evtims[i]->impl_opaque[1] = 0; rte_smp_wmb(); } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:52.480892713 +0100 +++ 0102-eventdev-remove-redundant-reset-on-timer-cancel.patch 2020-07-24 12:53:48.347007578 +0100 @@ -1,14 +1,14 @@ -From e84d9c62c671a502022a3a81358cac702d6f3a15 Mon Sep 17 00:00:00 2001 +From d79a74d9bfe61030fbe46546f575d5028a839739 Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Tue, 7 Jul 2020 23:54:52 +0800 Subject: [PATCH] eventdev: remove redundant reset on timer cancel +[ upstream commit e84d9c62c671a502022a3a81358cac702d6f3a15 ] + There is no thread will access these impl_opaque data after timer canceled. When new timer armed, it got refilled. So the cleanup process is unnecessary. -Cc: stable@dpdk.org - Signed-off-by: Phil Yang Reviewed-by: Dharmik Thakkar --- @@ -16,10 +16,10 @@ 1 file changed, 2 deletions(-) diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c -index 4ed301382..aa01b4d9f 100644 +index 678be9f0a..af5087132 100644 --- a/lib/librte_eventdev/rte_event_timer_adapter.c +++ b/lib/librte_eventdev/rte_event_timer_adapter.c -@@ -1167,8 +1167,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter, +@@ -1163,8 +1163,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter, rte_mempool_put(sw->tim_pool, (void **)timp); evtims[i]->state = RTE_EVENT_TIMER_CANCELED;