From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id C1533A0518
for <public@inbox.dpdk.org>; Fri, 24 Jul 2020 14:02:19 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B791F1C05C;
Fri, 24 Jul 2020 14:02:19 +0200 (CEST)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
[209.85.128.66]) by dpdk.org (Postfix) with ESMTP id D24F21C042
for <stable@dpdk.org>; Fri, 24 Jul 2020 14:02:17 +0200 (CEST)
Received: by mail-wm1-f66.google.com with SMTP id t142so1668527wmt.4
for <stable@dpdk.org>; Fri, 24 Jul 2020 05:02:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=57aeVETbE/Tv4iUVqrbyJd9slkoX+a1qPr43Vp51aZ8=;
b=lc51HYBVw9jiQl14ulgJPPAARwrHazwnocktAKJsRia1zITfn9mJ/PcILCSJPfwncR
UmQ/E+u7WOcPd8kCeu350j6dpPbUfY4Y5cHRdkdkJQchQIplJgZKP3i1hVU5oYuP+LA+
Avm7HoymZxUtxeDnAD4g95bFKKaAWVdUpRt0hWmG6ds30M9/ycWuxHXMfq+yQ1qRYCm4
6/WLB0+SVxdNYGibgj7yC0a7O8MEyCvoaPmn7DO871Fj2z/jgOignYakg4yI+P+lNYRK
23MehGJmmWUxtWIK9TY3Eu+q9xczg+mPz2ynlxZE7+VaLFvqlW8zRAkkbHqkLuJmoKlo
3GUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=57aeVETbE/Tv4iUVqrbyJd9slkoX+a1qPr43Vp51aZ8=;
b=Ukj9z2zipvr70kXg/A9unHzZIhvbYeafSwcqZEDTWXBoZ5rs/+U434lmk//YxhJapa
TrjbwAjfKq0AstzeghSFs8I4es5Qm1IOx7ehtk3tHF+gRMy0NaimPHgDoJ8KoKCPE75C
3SGSu7kJ4/ur/MvUV1sUqPXEavTRfN5iVxTAXoKSTFOqjparD+PBNozjEvLNU5nH1VRK
0n4RvTPTrzXibn864xg3ETcJmdFx4bqvsJZpWv5wlwzxxxmaf5iKCgj4i4nOlN5KvZIv
l3fEmT8Q3SlAmK9iIOjIcrbEBO4w3J72SMD5aGD0fiRc8yT2yGt0GQ5vOLpXTE3ztDx2
wY/Q==
X-Gm-Message-State: AOAM532fPn+J4B1z0+y4RVgxDYozdzfwsIJCUkEHXnbfy3bSKJ3uXzW/
34Y3O7fNtQ6+kHpssgE7urk=
X-Google-Smtp-Source: ABdhPJy4K/axCur8BM8ymM5GRy6mFqcnDD3Wsr3p8U94dwBvZYVRmKStG1GrcXTjqM4KjgfQqtWDLg==
X-Received: by 2002:a1c:1dcc:: with SMTP id d195mr5906470wmd.11.1595592137559;
Fri, 24 Jul 2020 05:02:17 -0700 (PDT)
Received: from localhost ([88.98.246.218])
by smtp.gmail.com with ESMTPSA id a123sm7503109wmd.28.2020.07.24.05.02.12
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 24 Jul 2020 05:02:14 -0700 (PDT)
From: luca.boccassi@gmail.com
To: Hongbo Zheng <zhenghongbo3@huawei.com>
Cc: Wei Hu <xavier.huwei@huawei.com>,
dpdk stable <stable@dpdk.org>
Date: Fri, 24 Jul 2020 12:57:48 +0100
Message-Id: <20200724120030.1863487-30-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com>
References: <20200724120030.1863487-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] patch 'net/hns3: fix unintended sign extension in
dump operation' has been queued to stable release 19.11.4
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi,
FYI, your patch has been queued to stable release 19.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/26/20. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Thanks.
Luca Boccassi
---
>From 54161c5e70e1a93e8abee37f0ddd5a8021954a70 Mon Sep 17 00:00:00 2001
From: Hongbo Zheng <zhenghongbo3@huawei.com>
Date: Tue, 9 Jun 2020 16:44:17 +0800
Subject: [PATCH] net/hns3: fix unintended sign extension in dump operation
[ upstream commit 5045e2b25ab1ce9ded4023b60fda7489a2b06663 ]
There are coverity defects related "Unintended sign extension" in the
internal static function named hns3_get_regs_length used for dumping reg
operation.
This patch fixes them by replacing the data type of cmdq_lines,
common_lines, ring_lines and tqp_intr_lines with uint32_t in the inner
static function named hns3_get_regs_length of hns3 PMD driver.
Coverity issue: 349917, 349914
Fixes: 936eda25e8da ("net/hns3: support dump register")
Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
---
drivers/net/hns3/hns3_regs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c
index a3f2a51f9..63c8602a8 100644
--- a/drivers/net/hns3/hns3_regs.c
+++ b/drivers/net/hns3/hns3_regs.c
@@ -116,7 +116,7 @@ static int
hns3_get_regs_length(struct hns3_hw *hw, uint32_t *length)
{
struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
- int cmdq_lines, common_lines, ring_lines, tqp_intr_lines;
+ uint32_t cmdq_lines, common_lines, ring_lines, tqp_intr_lines;
uint32_t regs_num_32_bit, regs_num_64_bit;
uint32_t len;
int ret;
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2020-07-24 12:53:49.767769770 +0100
+++ 0030-net-hns3-fix-unintended-sign-extension-in-dump-opera.patch 2020-07-24 12:53:48.219005193 +0100
@@ -1,8 +1,10 @@
-From 5045e2b25ab1ce9ded4023b60fda7489a2b06663 Mon Sep 17 00:00:00 2001
+From 54161c5e70e1a93e8abee37f0ddd5a8021954a70 Mon Sep 17 00:00:00 2001
From: Hongbo Zheng <zhenghongbo3@huawei.com>
Date: Tue, 9 Jun 2020 16:44:17 +0800
Subject: [PATCH] net/hns3: fix unintended sign extension in dump operation
+[ upstream commit 5045e2b25ab1ce9ded4023b60fda7489a2b06663 ]
+
There are coverity defects related "Unintended sign extension" in the
internal static function named hns3_get_regs_length used for dumping reg
operation.
@@ -13,7 +15,6 @@
Coverity issue: 349917, 349914
Fixes: 936eda25e8da ("net/hns3: support dump register")
-Cc: stable@dpdk.org
Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>