From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16D3FA0518 for ; Fri, 24 Jul 2020 14:00:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EE3D1BFE7; Fri, 24 Jul 2020 14:00:58 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 5BF491C02A for ; Fri, 24 Jul 2020 14:00:56 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id f1so7519214wro.2 for ; Fri, 24 Jul 2020 05:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q/GqvGlP21knPrAxCkSww32Y4dMxRxmI8XPm3cp/S58=; b=HJuU65tMTCUbSfDId/Wybyjj0qnJjHt9Da8we57yMQCAHxyvaYhO7950i22nBQmC3y mEmZ+EQJt89rGQ0+B39iSzdT9s7Jj7/+Rxi05TyADm4/Zxs2a6bV6uM2HEPtZS36ee9n LG/xtN0hitqKM1mBzed/FXGhMctkyjNLEzA8yYsDpBc8s2ak6vKz2AakSnqLnumEZSRr Pe464wsCTEdI+cSo2hSOiOChLGKIB1hed+2FxgmZXBw7UP3A49f+ASVJjnIQqebaVH+T lb3oJ+GjlzGXQk9WYOcg0ydOCd3rigTR0w+F1MrGfWk+CQwD4+gOXPhWx875OKORhIkQ Xn8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q/GqvGlP21knPrAxCkSww32Y4dMxRxmI8XPm3cp/S58=; b=hWcGDqmu1uNqKf2Vh0Iz+jMxsQf2KdQgOBl3xUPChx8DuMwskDf1lKIvZM3+lcgXbG ldlHpAfNWiuVrFOjxOaVY5aKOkqILoPoMiDzQAAc9D4WEstqW4Hn8JBnBYDXdnNEe1mu FE7f5z5XqTHHOeJ3dDFgIz8Sze+raLLzEgjKOHznXzBfzJj7yJEbQldhHR+lJxKqkgDV Pc863zdwPFjgDN64h5CZ9HfkFxZiGDjY/aKgHDD/z0QNJGv2WCBxhWhTWsUmbgHSLbFM y1Bswha/sM0U26p/+rM746+qcnGinqckPBgJSkOa3kNR1X526wWlFFuFW+Uyjyjwp/Cy 2i2Q== X-Gm-Message-State: AOAM531URwqNtgnrcs0pCsccQHHp5Z/ZRVVy3cjs6x20STAZKuw2QoNi 7aEnE/LJe9Uwi98KDcxjiYpaBIxrE50= X-Google-Smtp-Source: ABdhPJzCHAHYagQ3tXIRj+kCgoVLQR/raCpQ31lVsD026EvHsTQ7Zd3L07Z53Ox5d1In8gN2lveUwA== X-Received: by 2002:a5d:6692:: with SMTP id l18mr8233627wru.211.1595592056128; Fri, 24 Jul 2020 05:00:56 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id q3sm6754098wmq.22.2020.07.24.05.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:00:55 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Date: Fri, 24 Jul 2020 12:57:26 +0100 Message-Id: <20200724120030.1863487-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: fix warning when VF is removed' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 370b18ccd659b433b9ff7cde3ea7fd9eb800097b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 19 May 2020 09:52:27 -0700 Subject: [PATCH] net/netvsc: fix warning when VF is removed [ upstream commit c6854a41266a962d1f013065db7828517b246fef ] The code to unset owner of VF device was changing port to invalid value before calling unset. Fixes: 4a9efcddaddd ("net/netvsc: fix VF support with secondary process") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_vf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c index 1261b2e2e..97333b502 100644 --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c @@ -127,12 +127,12 @@ static void hn_vf_remove(struct hn_data *hv) /* Stop incoming packets from arriving on VF */ hn_nvs_set_datapath(hv, NVS_DATAPATH_SYNTHETIC); + /* Give back ownership */ + rte_eth_dev_owner_unset(hv->vf_port, hv->owner.id); + /* Stop transmission over VF */ hv->vf_port = HN_INVALID_PORT; rte_smp_wmb(); - - /* Give back ownership */ - rte_eth_dev_owner_unset(hv->vf_port, hv->owner.id); } rte_spinlock_unlock(&hv->vf_lock); } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:48.912396938 +0100 +++ 0008-net-netvsc-fix-warning-when-VF-is-removed.patch 2020-07-24 12:53:48.155004000 +0100 @@ -1,13 +1,14 @@ -From c6854a41266a962d1f013065db7828517b246fef Mon Sep 17 00:00:00 2001 +From 370b18ccd659b433b9ff7cde3ea7fd9eb800097b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 19 May 2020 09:52:27 -0700 Subject: [PATCH] net/netvsc: fix warning when VF is removed +[ upstream commit c6854a41266a962d1f013065db7828517b246fef ] + The code to unset owner of VF device was changing port to invalid value before calling unset. Fixes: 4a9efcddaddd ("net/netvsc: fix VF support with secondary process") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- @@ -15,24 +16,25 @@ 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c -index b7e3ba46b..a745c7c36 100644 +index 1261b2e2e..97333b502 100644 --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c -@@ -120,11 +120,11 @@ static void hn_vf_remove(struct hn_data *hv) +@@ -127,12 +127,12 @@ static void hn_vf_remove(struct hn_data *hv) /* Stop incoming packets from arriving on VF */ hn_nvs_set_datapath(hv, NVS_DATAPATH_SYNTHETIC); -- /* Stop transmission over VF */ -- hv->vf_port = HN_INVALID_PORT; -- - /* Give back ownership */ - rte_eth_dev_owner_unset(hv->vf_port, hv->owner.id); ++ /* Give back ownership */ ++ rte_eth_dev_owner_unset(hv->vf_port, hv->owner.id); + -+ /* Stop transmission over VF */ -+ hv->vf_port = HN_INVALID_PORT; + /* Stop transmission over VF */ + hv->vf_port = HN_INVALID_PORT; + rte_smp_wmb(); +- +- /* Give back ownership */ +- rte_eth_dev_owner_unset(hv->vf_port, hv->owner.id); } + rte_spinlock_unlock(&hv->vf_lock); } - -- 2.20.1