From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10889A034D for ; Thu, 6 Aug 2020 10:45:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D450D1C0AD; Thu, 6 Aug 2020 10:45:20 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2AF0F1C0AD; Thu, 6 Aug 2020 10:45:18 +0200 (CEST) IronPort-SDR: Qo0SVm1LcCUCgH/IKLGwWyQ1FA6b0uAmtcQ/0iSsptwoSrsY1YVxADhegHBOi8+s4KKrOA2hz1 VA3/Vl3ccnmw== X-IronPort-AV: E=McAfee;i="6000,8403,9704"; a="152715124" X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="152715124" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2020 01:45:18 -0700 IronPort-SDR: Zxjb1dRydWGchO/yZuUUicaIAnFLd1HW5yvFNNKxP7ujNosUhQp5OivP7H54c2UPSfPpZ25qKj //u+ruSlV0cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="306968479" Received: from intel.sh.intel.com ([10.239.255.20]) by orsmga002.jf.intel.com with ESMTP; 06 Aug 2020 01:45:16 -0700 From: Shougang Wang To: dev@dpdk.org Cc: qiming.yang@intel.com, qi.z.zhang@intel.com, Shougang Wang , stable@dpdk.org Date: Thu, 6 Aug 2020 08:25:19 +0000 Message-Id: <20200806082519.71727-1-shougangx.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Kernel driver shows firmware version as hex but ice PMD shows as decimal. This patch fixes the issue to make consistent with kernel driver. Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format") Cc: stable@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 8d435e889..88b8428b9 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size) build = hw->nvm.orom.build; ret = snprintf(fw_version, fw_size, - "%d.%d 0x%08x %d.%d.%d", + "%x.%02x 0x%08x %d.%d.%d", hw->nvm.major_ver, hw->nvm.minor_ver, hw->nvm.eetrack, -- 2.17.1