From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D0DCA0351 for ; Thu, 6 Aug 2020 11:58:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0593C1C0AE; Thu, 6 Aug 2020 11:58:47 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 0FA021C0AE for ; Thu, 6 Aug 2020 11:58:46 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id z18so39830019wrm.12 for ; Thu, 06 Aug 2020 02:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/XcqFw7UEcKv+MIM+S1ggAInCqVywM/HjJmSCZC9ylA=; b=Te903/VvVUm6NAF++39ElEBeW38xvEgqghJM3jpL3ULSQU4/4V5CTd1yOgp2xCBQe1 i9xr6WV/jPzKKIJJ9H017z5a2/McFS7k+UAdbycFPPJlp4SgiJRvuBX6y0KeMzP+MS8Y vWFHm77z6RE0aqF+RbZXqe7ck9/4p10jMdLv6cDiDpPEsgQpF3LHTjg/WHCJTcKdn9Mz ZFv/0fKvbo4NsfQfRBgMNmgqJBxcKQT1rVIWGBT+rt4XMUPPq6ms9Uf8Tk9esrqG+gfa W3F1pSlnwBfSyQentC3bNGH07+3I2LtkltiaCXMAujMqWfmVb/5tilkV6/IrkYUB+Pzv GoYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/XcqFw7UEcKv+MIM+S1ggAInCqVywM/HjJmSCZC9ylA=; b=XRJzgsJn1tECZUJ1mBP1mGBf3cTznCm60+LSDmBTPH5nox9458h0BXHDZwvddq3NvY iUvfSDyHmfD7mjSeg/ROzhpj/ApxFmUQdwodIjs6rvaSLnpi5PEdXfoL8XQkHMM2d/c3 6PQkknxbp1Xb8QpREXWyfDduHFv1zurz4WRnjhdH32EqHvNlLoDK3/BjCoMPYbUm02q3 s0L44Wyiy/1wRj5m5AzGfXi4zFLz45zhTD+/+6FwGq97dYyUKWdTd0uZJy19Xf7zapnL hQxIHGAYK+eshy4Eq9ak/rtcUc5q9vlQ7N41t/v99X+yP8UNRg1Upu24evsttdGVkSTG ochA== X-Gm-Message-State: AOAM531UuSXX5ycG2AR4aXJHFwG8Ik0jRg9k6rbltNMbQkKD2W2Q4JFP gasm63nPSKl3k6o4fYkqnK7e0K+vX2Y= X-Google-Smtp-Source: ABdhPJwF1B3S/bWkWywnjbTs5JHTv7XtVT9b7zl96CwtH+CzGqaoE3V6RHO2TCpyurHVqeaO6soZNQ== X-Received: by 2002:adf:b353:: with SMTP id k19mr6507392wrd.159.1596707925759; Thu, 06 Aug 2020 02:58:45 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y16sm5700254wrr.83.2020.08.06.02.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 02:58:45 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Rasesh Mody , dpdk stable Date: Thu, 6 Aug 2020 10:53:49 +0100 Message-Id: <20200806095411.774624-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200806095411.774624-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> <20200806095411.774624-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: remove dead code' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/08/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 491fd352e1351f40b7255e916b0ecac9d148105b Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 17 Jul 2020 19:16:23 +0800 Subject: [PATCH] net/qede: remove dead code [ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ] This patch removes logically dead code reported by coverity. Coverity issue: 261777, 261778 Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Signed-off-by: Yunjian Wang Acked-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 3c55c0efd..ab69cba17 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -647,8 +647,6 @@ int qede_alloc_fp_resc(struct qede_dev *qdev) for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { fp = &qdev->fp_array[sb_idx]; - if (!fp) - continue; fp->sb_info = rte_calloc("sb", 1, sizeof(struct ecore_sb_info), RTE_CACHE_LINE_SIZE); if (!fp->sb_info) { @@ -678,8 +676,6 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev) for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { fp = &qdev->fp_array[sb_idx]; - if (!fp) - continue; DP_INFO(edev, "Free sb_info index 0x%x\n", fp->sb_info->igu_sb_id); if (fp->sb_info) { -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-08-06 10:53:16.630642463 +0100 +++ 0021-net-qede-remove-dead-code.patch 2020-08-06 10:53:15.792597243 +0100 @@ -1,13 +1,14 @@ -From d123f83c43085d03e0c2e37f8174577189711fdb Mon Sep 17 00:00:00 2001 +From 491fd352e1351f40b7255e916b0ecac9d148105b Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 17 Jul 2020 19:16:23 +0800 Subject: [PATCH] net/qede: remove dead code +[ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ] + This patch removes logically dead code reported by coverity. Coverity issue: 261777, 261778 Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Rasesh Mody @@ -16,7 +17,7 @@ 1 file changed, 4 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c -index 9878ba50e..ea264f59d 100644 +index 3c55c0efd..ab69cba17 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -647,8 +647,6 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)