* [dpdk-stable] [PATCH 1/2] lpm: fix free of data structure
[not found] <20200907081518.46350-1-ruifeng.wang@arm.com>
@ 2020-09-07 8:15 ` Ruifeng Wang
2020-09-15 15:55 ` Bruce Richardson
2020-09-15 16:25 ` Medvedkin, Vladimir
[not found] ` <20201021030211.36381-1-ruifeng.wang@arm.com>
1 sibling, 2 replies; 4+ messages in thread
From: Ruifeng Wang @ 2020-09-07 8:15 UTC (permalink / raw)
To: Bruce Richardson, Vladimir Medvedkin, Ray Kinsella,
Honnappa Nagarahalli, Ruifeng Wang
Cc: dev, nd, stable
The container structure should be freed instead of rte_lpm structure
after wrapping rte_lpm into internal structure __rte_lpm.
Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
Cc: stable@dpdk.org
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
---
lib/librte_lpm/rte_lpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
index 757436f49..51a0ae578 100644
--- a/lib/librte_lpm/rte_lpm.c
+++ b/lib/librte_lpm/rte_lpm.c
@@ -268,7 +268,7 @@ rte_lpm_free(struct rte_lpm *lpm)
rte_rcu_qsbr_dq_delete(internal_lpm->dq);
rte_free(lpm->tbl8);
rte_free(lpm->rules_tbl);
- rte_free(lpm);
+ rte_free(internal_lpm);
rte_free(te);
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 1/2] lpm: fix free of data structure
2020-09-07 8:15 ` [dpdk-stable] [PATCH 1/2] lpm: fix free of data structure Ruifeng Wang
@ 2020-09-15 15:55 ` Bruce Richardson
2020-09-15 16:25 ` Medvedkin, Vladimir
1 sibling, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2020-09-15 15:55 UTC (permalink / raw)
To: Ruifeng Wang
Cc: Vladimir Medvedkin, Ray Kinsella, Honnappa Nagarahalli, dev, nd, stable
On Mon, Sep 07, 2020 at 04:15:16PM +0800, Ruifeng Wang wrote:
> The container structure should be freed instead of rte_lpm structure
> after wrapping rte_lpm into internal structure __rte_lpm.
>
> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> ---
> lib/librte_lpm/rte_lpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
> index 757436f49..51a0ae578 100644
> --- a/lib/librte_lpm/rte_lpm.c
> +++ b/lib/librte_lpm/rte_lpm.c
> @@ -268,7 +268,7 @@ rte_lpm_free(struct rte_lpm *lpm)
> rte_rcu_qsbr_dq_delete(internal_lpm->dq);
> rte_free(lpm->tbl8);
> rte_free(lpm->rules_tbl);
> - rte_free(lpm);
> + rte_free(internal_lpm);
> rte_free(te);
> }
>
> --
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 1/2] lpm: fix free of data structure
2020-09-07 8:15 ` [dpdk-stable] [PATCH 1/2] lpm: fix free of data structure Ruifeng Wang
2020-09-15 15:55 ` Bruce Richardson
@ 2020-09-15 16:25 ` Medvedkin, Vladimir
1 sibling, 0 replies; 4+ messages in thread
From: Medvedkin, Vladimir @ 2020-09-15 16:25 UTC (permalink / raw)
To: Ruifeng Wang, Bruce Richardson, Ray Kinsella, Honnappa Nagarahalli
Cc: dev, nd, stable
On 07/09/2020 09:15, Ruifeng Wang wrote:
> The container structure should be freed instead of rte_lpm structure
> after wrapping rte_lpm into internal structure __rte_lpm.
>
> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> ---
> lib/librte_lpm/rte_lpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
> index 757436f49..51a0ae578 100644
> --- a/lib/librte_lpm/rte_lpm.c
> +++ b/lib/librte_lpm/rte_lpm.c
> @@ -268,7 +268,7 @@ rte_lpm_free(struct rte_lpm *lpm)
> rte_rcu_qsbr_dq_delete(internal_lpm->dq);
> rte_free(lpm->tbl8);
> rte_free(lpm->rules_tbl);
> - rte_free(lpm);
> + rte_free(internal_lpm);
> rte_free(te);
> }
>
>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
--
Regards,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH v2 1/2] lpm: fix free of data structure
[not found] ` <20201021030211.36381-1-ruifeng.wang@arm.com>
@ 2020-10-21 3:02 ` Ruifeng Wang
0 siblings, 0 replies; 4+ messages in thread
From: Ruifeng Wang @ 2020-10-21 3:02 UTC (permalink / raw)
To: Bruce Richardson, Vladimir Medvedkin, Ruifeng Wang,
Honnappa Nagarahalli, Ray Kinsella
Cc: dev, nd, stable, Phil Yang, Kevin Traynor
The container structure should be freed instead of rte_lpm structure
after wrapping rte_lpm into internal structure __rte_lpm.
Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
Cc: stable@dpdk.org
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
---
lib/librte_lpm/rte_lpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
index 757436f49..51a0ae578 100644
--- a/lib/librte_lpm/rte_lpm.c
+++ b/lib/librte_lpm/rte_lpm.c
@@ -268,7 +268,7 @@ rte_lpm_free(struct rte_lpm *lpm)
rte_rcu_qsbr_dq_delete(internal_lpm->dq);
rte_free(lpm->tbl8);
rte_free(lpm->rules_tbl);
- rte_free(lpm);
+ rte_free(internal_lpm);
rte_free(te);
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-21 3:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200907081518.46350-1-ruifeng.wang@arm.com>
2020-09-07 8:15 ` [dpdk-stable] [PATCH 1/2] lpm: fix free of data structure Ruifeng Wang
2020-09-15 15:55 ` Bruce Richardson
2020-09-15 16:25 ` Medvedkin, Vladimir
[not found] ` <20201021030211.36381-1-ruifeng.wang@arm.com>
2020-10-21 3:02 ` [dpdk-stable] [PATCH v2 " Ruifeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).