patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
	Fan Zhang <roy.fan.zhang@intel.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson
Date: Thu, 17 Sep 2020 16:46:35 +0100
Message-ID: <20200917154635.GJ1568@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8wcfujv7QPv4Bb4rG0SG3Zi44ZNiMotDbAYe8_gqSY8hw@mail.gmail.com>

On Thu, Sep 17, 2020 at 05:33:23PM +0200, David Marchand wrote:
> On Thu, Sep 17, 2020 at 5:29 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote:
> > > The headers variable is only used in lib/meson.build context.
> > > For drivers, an explicit install_headers() is necessary.
> > >
> > > Reproduced while compiling the l2fwd-crypto example out of meson
> > > (which can be done by adding it in devtools/test-meson-builds.sh
> > > examples build test).
> > >
> > > Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > >  drivers/crypto/scheduler/meson.build | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Originally I only put the "headers" variable in the "lib" folder
> > meson.build because it was not expected that many drivers should have
> > private headers. However, perhaps it's worthwhile adding it now:
> > a) because private headers, while not common, are not unusual
> > b) for consistency and ease of use.
> >
> > Thoughts?
> 
> Yep, I can do it in a followup patch now, still looking at your RFC
> series though.. :-)
>
No rush, what we have now has worked reasonably well for the last few
years! :-)
If you don't get to it, I can always look at it post-19.11.

  reply	other threads:[~2020-09-17 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 15:09 [dpdk-stable] " David Marchand
2020-09-17 15:29 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2020-09-17 15:33   ` David Marchand
2020-09-17 15:46     ` Bruce Richardson [this message]
2020-09-17 15:29 ` Bruce Richardson
2020-10-22  7:55 ` [dpdk-stable] [PATCH v2 1/2] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917154635.GJ1568@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git