From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F60EA04C1 for ; Thu, 17 Sep 2020 17:46:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 793B81D6B1; Thu, 17 Sep 2020 17:46:52 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C60FF1D69C; Thu, 17 Sep 2020 17:46:48 +0200 (CEST) IronPort-SDR: YCtkiqGiS8IGgon2IexL8X3+9E7VPvVdz/yy5nYWLbKBHk3D3pTiW67nWPW/GpHajlkC5l99BZ LvqW7UdRuO9Q== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="157127809" X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="157127809" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 08:46:43 -0700 IronPort-SDR: MQtIQ1x+bgW1qwjGmPIsj8dMploYVST7Yq0/8LFcmvQRNJ7Uww7FS2d/s/lif1vtaRnC/KBYJU 8gob8oKaoQUw== X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="452361245" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.24.6]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Sep 2020 08:46:40 -0700 Date: Thu, 17 Sep 2020 16:46:35 +0100 From: Bruce Richardson To: David Marchand Cc: dev , dpdk stable , Fan Zhang , Luca Boccassi Message-ID: <20200917154635.GJ1568@bricha3-MOBL.ger.corp.intel.com> References: <20200917150917.22945-1-david.marchand@redhat.com> <20200917152920.GH1568@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Sep 17, 2020 at 05:33:23PM +0200, David Marchand wrote: > On Thu, Sep 17, 2020 at 5:29 PM Bruce Richardson > wrote: > > > > On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote: > > > The headers variable is only used in lib/meson.build context. > > > For drivers, an explicit install_headers() is necessary. > > > > > > Reproduced while compiling the l2fwd-crypto example out of meson > > > (which can be done by adding it in devtools/test-meson-builds.sh > > > examples build test). > > > > > > Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: David Marchand > > > --- > > > drivers/crypto/scheduler/meson.build | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > Originally I only put the "headers" variable in the "lib" folder > > meson.build because it was not expected that many drivers should have > > private headers. However, perhaps it's worthwhile adding it now: > > a) because private headers, while not common, are not unusual > > b) for consistency and ease of use. > > > > Thoughts? > > Yep, I can do it in a followup patch now, still looking at your RFC > series though.. :-) > No rush, what we have now has worked reasonably well for the last few years! :-) If you don't get to it, I can always look at it post-19.11.