patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Vipul Ashri <vipul.ashri@oracle.com>
To: dev@dpdk.org
Cc: chenbo.xia@intel.com, vipul.ashri@oracle.com,
	zhihong.wang@intel.com, maxime.coquelin@redhat.com,
	arybchenko@solarflare.com, makarov@kraftway.ru, stable@dpdk.org
Subject: [dpdk-stable] [PATCH v5] net/virtio: fix wrong variable assignment in helper macro
Date: Fri, 18 Sep 2020 15:25:04 +0530
Message-ID: <20200918095505.1619-1-vipul.ashri@oracle.com> (raw)
In-Reply-To: <20200813072837.1468-1-vipul.ashri@oracle.com>

Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always
failing as assignment done using var_ having local scope only.
This leads to TX packets not going out and found broken due to cleanup
malfunctioning. This patch fixes the wrong variable assignment.

Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions")
Cc: stable@dpdk.org

Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
---
 drivers/net/virtio/virtqueue.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 105a9c00c..6ed50648c 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -607,10 +607,10 @@ virtqueue_notify(struct virtqueue *vq)
 
 /* avoid write operation when necessary, to lessen cache issues */
 #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
-	typeof(var) var_ = (var);		\
-	typeof(val) val_ = (val);		\
-	if ((var_) != (val_))			\
-		(var_) = (val_);		\
+	typeof(var) *const var_ = &(var);	\
+	typeof(val)  const val_ = (val);	\
+	if (*var_ != val_)			\
+		*var_ = val_;			\
 } while (0)
 
 #define virtqueue_clear_net_hdr(hdr) do {		\
-- 
2.28.0.windows.1


  parent reply	other threads:[~2020-09-18  9:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200812092306.1345-1-vipul.ashri@oracle.com>
     [not found] ` <20200813072837.1468-1-vipul.ashri@oracle.com>
2020-08-13  7:35   ` [dpdk-stable] [PATCH v3] " Xia, Chenbo
2020-08-19  1:25   ` Xia, Chenbo
2020-09-16  5:57   ` [dpdk-stable] [PATCH v4] " Vipul Ashri
2020-09-17 15:54     ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2020-09-18  9:55   ` Vipul Ashri [this message]
2020-09-18 12:22     ` [dpdk-stable] [PATCH v5] " Maxime Coquelin
2020-09-18 12:30     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918095505.1619-1-vipul.ashri@oracle.com \
    --to=vipul.ashri@oracle.com \
    --cc=arybchenko@solarflare.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=makarov@kraftway.ru \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git