patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: dev@dpdk.org, honnappa.nagarahalli@arm.com, phil.yang@arm.com,
	jgrajcia@cisco.com, ferruh.yigit@intel.com
Cc: nd@arm.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH 2/4] net/memif: relax the load of ring tail pointer for M2S ring
Date: Mon, 21 Sep 2020 14:22:52 -0500	[thread overview]
Message-ID: <20200921192254.20560-2-honnappa.nagarahalli@arm.com> (raw)
In-Reply-To: <20200921192254.20560-1-honnappa.nagarahalli@arm.com>

For M2S rings, ring->tail is updated by the sender and eth_memif_tx
function is called in the context of sending thread. The loads in
the sender do not need to synchronize with its own stores.

Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier")
Cc: phil.yang@arm.com
Cc: stable@dpdk.org

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
---
 drivers/net/memif/rte_eth_memif.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index fd7dbc53e..0d064c8fa 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -573,7 +573,13 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 		n_free = ring_size - slot +
 				__atomic_load_n(&ring->tail, __ATOMIC_ACQUIRE);
 	} else {
-		slot = __atomic_load_n(&ring->tail, __ATOMIC_ACQUIRE);
+		/* For M2S queues ring->tail is updated by the sender and
+		 * this function is called in the context of sending thread.
+		 * The loads in the sender do not need to synchronize with
+		 * its own stores. Hence, the following load can be a
+		 * relaxed load.
+		 */
+		slot = __atomic_load_n(&ring->tail, __ATOMIC_RELAXED);
 		n_free = __atomic_load_n(&ring->head, __ATOMIC_ACQUIRE) - slot;
 	}
 
-- 
2.17.1


  reply	other threads:[~2020-09-21 19:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 19:22 [dpdk-stable] [PATCH 1/4] net/memif: do not update local copy of tail in tx function Honnappa Nagarahalli
2020-09-21 19:22 ` Honnappa Nagarahalli [this message]
2020-09-21 19:22 ` [dpdk-stable] [PATCH 3/4] net/memif: relax the load of ring head pointer for S2M ring Honnappa Nagarahalli
2020-09-21 19:22 ` [dpdk-stable] [PATCH 4/4] net/memif: relax the load of ring head pointer for M2S ring Honnappa Nagarahalli
2020-09-28 19:03 ` [dpdk-stable] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-stable] [PATCH v2 2/8] net/memif: relax the load of ring tail pointer for M2S ring Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-stable] [PATCH v2 3/8] net/memif: relax the load of ring head " Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-stable] [PATCH v2 4/8] net/memif: relax the load of ring head pointer for S2M ring Honnappa Nagarahalli
2020-09-28 20:53   ` [dpdk-stable] [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Stephen Hemminger
2020-09-29  5:24     ` Honnappa Nagarahalli
2020-10-07 17:08   ` [dpdk-stable] " Honnappa Nagarahalli
2020-10-09 11:23     ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2020-10-09 15:59       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921192254.20560-2-honnappa.nagarahalli@arm.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jgrajcia@cisco.com \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).