* [dpdk-stable] [PATCH 3/8] net/bnxt: fix to correct bad shift operation
[not found] <20200922070632.17706-1-somnath.kotur@broadcom.com>
@ 2020-09-22 7:06 ` Somnath Kotur
0 siblings, 0 replies; only message in thread
From: Somnath Kotur @ 2020-09-22 7:06 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, Somnath Kotur, stable, Venkat Duvvuru, Ajit Kumar Khaparde
In page_roundup() left shifting by more than 31 bits could have
undefined behavior as the return value is int and in page_getenum()
it is possible to return a value as high as 63.
Fix that to cap the return value to less than 32.
Coverity issue: 343463
Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF")
Cc: stable@dpdk.org
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 57d1026..04eb05e 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -52,7 +52,7 @@ static int page_getenum(size_t size)
if (size <= 1 << 30)
return 30;
PMD_DRV_LOG(ERR, "Page size %zu out of range\n", size);
- return sizeof(void *) * 8 - 1;
+ return sizeof(int) * 8 - 1;
}
static int page_roundup(size_t size)
--
2.7.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-22 7:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200922070632.17706-1-somnath.kotur@broadcom.com>
2020-09-22 7:06 ` [dpdk-stable] [PATCH 3/8] net/bnxt: fix to correct bad shift operation Somnath Kotur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).