From: Kevin Laatz <kevin.laatz@intel.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, bruce.richardson@intel.com,
Kevin Laatz <kevin.laatz@intel.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH] net/ring: fix unchecked return value
Date: Tue, 22 Sep 2020 18:20:15 +0100 [thread overview]
Message-ID: <20200922172015.266698-1-kevin.laatz@intel.com> (raw)
Add a check for the return value of the sscanf call in
parse_internal_args(), returning an error if we don't get the expected
result.
Coverity issue: 362049
Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
Cc: stable@dpdk.org
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
drivers/net/ring/rte_eth_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 40fe1ca4ba..62060e46ce 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -539,7 +539,8 @@ parse_internal_args(const char *key __rte_unused, const char *value,
struct ring_internal_args **internal_args = data;
void *args;
- sscanf(value, "%p", &args);
+ if (sscanf(value, "%p", &args) != 1)
+ return -1;
*internal_args = args;
--
2.25.1
next reply other threads:[~2020-09-22 17:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 17:20 Kevin Laatz [this message]
2020-09-23 8:06 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-09-23 9:39 ` Bruce Richardson
2020-09-23 9:43 ` David Marchand
2020-09-23 10:04 ` Kevin Laatz
2020-09-23 10:25 ` Bruce Richardson
2020-09-25 12:43 ` [dpdk-stable] " Ferruh Yigit
2020-10-01 14:14 ` Kevin Laatz
2020-10-01 14:51 ` Ferruh Yigit
2020-10-01 17:09 ` [dpdk-stable] [PATCH v2] " Kevin Laatz
2020-10-12 11:57 ` Ferruh Yigit
2020-10-12 12:45 ` Bruce Richardson
2020-10-12 13:04 ` Ferruh Yigit
2020-10-12 13:11 ` Bruce Richardson
2020-10-13 13:07 ` [dpdk-stable] [PATCH v3] " Kevin Laatz
2020-10-13 17:23 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922172015.266698-1-kevin.laatz@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).