* [dpdk-stable] [PATCH v3 01/25] doc/api: add ioat driver to index [not found] ` <20200925110910.284098-1-bruce.richardson@intel.com> @ 2020-09-25 11:08 ` Bruce Richardson 2020-09-25 11:08 ` [dpdk-stable] [PATCH v3 02/25] raw/ioat: fix missing close function Bruce Richardson 1 sibling, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2020-09-25 11:08 UTC (permalink / raw) To: dev; +Cc: patrick.fu, Bruce Richardson, stable, Kevin Laatz Add the ioat driver to the doxygen documentation. Cc: stable@dpdk.org Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Reviewed-by: Kevin Laatz <kevin.laatz@intel.com> --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index b855a8f3b..06e49f438 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md @@ -44,6 +44,7 @@ The public API headers are grouped by topics: [ixgbe] (@ref rte_pmd_ixgbe.h), [i40e] (@ref rte_pmd_i40e.h), [ice] (@ref rte_pmd_ice.h), + [ioat] (@ref rte_ioat_rawdev.h), [bnxt] (@ref rte_pmd_bnxt.h), [dpaa] (@ref rte_pmd_dpaa.h), [dpaa2] (@ref rte_pmd_dpaa2.h), diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index 42d38919d..f87336365 100644 --- a/doc/api/doxy-api.conf.in +++ b/doc/api/doxy-api.conf.in @@ -18,6 +18,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \ @TOPDIR@/drivers/net/softnic \ @TOPDIR@/drivers/raw/dpaa2_cmdif \ @TOPDIR@/drivers/raw/dpaa2_qdma \ + @TOPDIR@/drivers/raw/ioat \ @TOPDIR@/lib/librte_eal/include \ @TOPDIR@/lib/librte_eal/include/generic \ @TOPDIR@/lib/librte_acl \ -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-stable] [PATCH v3 02/25] raw/ioat: fix missing close function [not found] ` <20200925110910.284098-1-bruce.richardson@intel.com> 2020-09-25 11:08 ` [dpdk-stable] [PATCH v3 01/25] doc/api: add ioat driver to index Bruce Richardson @ 2020-09-25 11:08 ` Bruce Richardson 2020-09-25 11:12 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson 2020-09-25 11:12 ` [dpdk-stable] " Pai G, Sunil 1 sibling, 2 replies; 7+ messages in thread From: Bruce Richardson @ 2020-09-25 11:08 UTC (permalink / raw) To: dev; +Cc: patrick.fu, Kevin Laatz, stable, Sunil Pai G From: Kevin Laatz <kevin.laatz@intel.com> When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") Cc: stable@dpdk.org Reported-by: Sunil Pai G <sunil.pai.g@intel.com> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com> --- drivers/raw/ioat/ioat_rawdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c index 7f1a15436..0732b059f 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c @@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids) return 0; } +static int +ioat_dev_close(struct rte_rawdev *dev __rte_unused) +{ + return 0; +} + extern int ioat_rawdev_test(uint16_t dev_id); static int @@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev) .dev_configure = ioat_dev_configure, .dev_start = ioat_dev_start, .dev_stop = ioat_dev_stop, + .dev_close = ioat_dev_close, .dev_info_get = ioat_dev_info_get, .xstats_get = ioat_xstats_get, .xstats_get_names = ioat_xstats_get_names, -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 02/25] raw/ioat: fix missing close function 2020-09-25 11:08 ` [dpdk-stable] [PATCH v3 02/25] raw/ioat: fix missing close function Bruce Richardson @ 2020-09-25 11:12 ` Bruce Richardson 2020-09-25 11:12 ` [dpdk-stable] " Pai G, Sunil 1 sibling, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2020-09-25 11:12 UTC (permalink / raw) To: dev; +Cc: patrick.fu, Kevin Laatz, stable, Sunil Pai G On Fri, Sep 25, 2020 at 12:08:47PM +0100, Bruce Richardson wrote: > From: Kevin Laatz <kevin.laatz@intel.com> > > When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a > dev_close function for the device causing a segmentation fault when no > close() function is implemented for a driver. > > This patch resolves the issue by adding a stub function ioat_dev_close(). > > Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") > Cc: stable@dpdk.org > > Reported-by: Sunil Pai G <sunil.pai.g@intel.com> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com> > --- Forgot to add my own reviewed-by to this: Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH v3 02/25] raw/ioat: fix missing close function 2020-09-25 11:08 ` [dpdk-stable] [PATCH v3 02/25] raw/ioat: fix missing close function Bruce Richardson 2020-09-25 11:12 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson @ 2020-09-25 11:12 ` Pai G, Sunil 1 sibling, 0 replies; 7+ messages in thread From: Pai G, Sunil @ 2020-09-25 11:12 UTC (permalink / raw) To: Richardson, Bruce, dev; +Cc: Fu, Patrick, Laatz, Kevin, stable > -----Original Message----- > From: Richardson, Bruce <bruce.richardson@intel.com> > Sent: Friday, September 25, 2020 4:39 PM > To: dev@dpdk.org > Cc: Fu, Patrick <patrick.fu@intel.com>; Laatz, Kevin <kevin.laatz@intel.com>; > stable@dpdk.org; Pai G, Sunil <sunil.pai.g@intel.com> > Subject: [PATCH v3 02/25] raw/ioat: fix missing close function > > From: Kevin Laatz <kevin.laatz@intel.com> > > When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a > dev_close function for the device causing a segmentation fault when no > close() function is implemented for a driver. > > This patch resolves the issue by adding a stub function ioat_dev_close(). > > Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") > Cc: stable@dpdk.org > > Reported-by: Sunil Pai G <sunil.pai.g@intel.com> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com> > --- > drivers/raw/ioat/ioat_rawdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c > index 7f1a15436..0732b059f 100644 > --- a/drivers/raw/ioat/ioat_rawdev.c > +++ b/drivers/raw/ioat/ioat_rawdev.c > @@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const > uint32_t *ids, uint32_t nb_ids) > return 0; > } > > +static int > +ioat_dev_close(struct rte_rawdev *dev __rte_unused) { > + return 0; > +} > + > extern int ioat_rawdev_test(uint16_t dev_id); > > static int > @@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct > rte_pci_device *dev) > .dev_configure = ioat_dev_configure, > .dev_start = ioat_dev_start, > .dev_stop = ioat_dev_stop, > + .dev_close = ioat_dev_close, > .dev_info_get = ioat_dev_info_get, > .xstats_get = ioat_xstats_get, > .xstats_get_names = ioat_xstats_get_names, > -- > 2.25.1 Acked-by: Sunil Pai G <sunil.pai.g@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20200928164245.84997-1-bruce.richardson@intel.com>]
* [dpdk-stable] [PATCH v4 02/25] raw/ioat: fix missing close function [not found] ` <20200928164245.84997-1-bruce.richardson@intel.com> @ 2020-09-28 16:42 ` Bruce Richardson 0 siblings, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2020-09-28 16:42 UTC (permalink / raw) To: dev; +Cc: patrick.fu, Kevin Laatz, stable, Sunil Pai G, Bruce Richardson From: Kevin Laatz <kevin.laatz@intel.com> When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") Cc: stable@dpdk.org Reported-by: Sunil Pai G <sunil.pai.g@intel.com> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Sunil Pai G <sunil.pai.g@intel.com> --- drivers/raw/ioat/ioat_rawdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c index 7f1a154360..0732b059fe 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c @@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids) return 0; } +static int +ioat_dev_close(struct rte_rawdev *dev __rte_unused) +{ + return 0; +} + extern int ioat_rawdev_test(uint16_t dev_id); static int @@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev) .dev_configure = ioat_dev_configure, .dev_start = ioat_dev_start, .dev_stop = ioat_dev_stop, + .dev_close = ioat_dev_close, .dev_info_get = ioat_dev_info_get, .xstats_get = ioat_xstats_get, .xstats_get_names = ioat_xstats_get_names, -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20201007163023.2817-1-bruce.richardson@intel.com>]
* [dpdk-stable] [PATCH v5 02/25] raw/ioat: fix missing close function [not found] ` <20201007163023.2817-1-bruce.richardson@intel.com> @ 2020-10-07 16:30 ` Bruce Richardson 0 siblings, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2020-10-07 16:30 UTC (permalink / raw) To: dev Cc: patrick.fu, thomas, Kevin Laatz, stable, Sunil Pai G, Bruce Richardson, Radu Nicolau From: Kevin Laatz <kevin.laatz@intel.com> When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") Cc: stable@dpdk.org Reported-by: Sunil Pai G <sunil.pai.g@intel.com> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Sunil Pai G <sunil.pai.g@intel.com> Acked-by: Radu Nicolau <radu.nicolau@intel.com> --- drivers/raw/ioat/ioat_rawdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c index 7f1a15436..0732b059f 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c @@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids) return 0; } +static int +ioat_dev_close(struct rte_rawdev *dev __rte_unused) +{ + return 0; +} + extern int ioat_rawdev_test(uint16_t dev_id); static int @@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev) .dev_configure = ioat_dev_configure, .dev_start = ioat_dev_start, .dev_stop = ioat_dev_stop, + .dev_close = ioat_dev_close, .dev_info_get = ioat_dev_info_get, .xstats_get = ioat_xstats_get, .xstats_get_names = ioat_xstats_get_names, -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20201008095133.123014-1-bruce.richardson@intel.com>]
* [dpdk-stable] [PATCH v6 02/25] raw/ioat: fix missing close function [not found] ` <20201008095133.123014-1-bruce.richardson@intel.com> @ 2020-10-08 9:51 ` Bruce Richardson 0 siblings, 0 replies; 7+ messages in thread From: Bruce Richardson @ 2020-10-08 9:51 UTC (permalink / raw) To: dev Cc: patrick.fu, thomas, Kevin Laatz, stable, Sunil Pai G, Bruce Richardson, Radu Nicolau From: Kevin Laatz <kevin.laatz@intel.com> When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") Cc: stable@dpdk.org Reported-by: Sunil Pai G <sunil.pai.g@intel.com> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Sunil Pai G <sunil.pai.g@intel.com> Acked-by: Radu Nicolau <radu.nicolau@intel.com> --- drivers/raw/ioat/ioat_rawdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c index 7f1a15436..0732b059f 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c @@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids) return 0; } +static int +ioat_dev_close(struct rte_rawdev *dev __rte_unused) +{ + return 0; +} + extern int ioat_rawdev_test(uint16_t dev_id); static int @@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev) .dev_configure = ioat_dev_configure, .dev_start = ioat_dev_start, .dev_stop = ioat_dev_stop, + .dev_close = ioat_dev_close, .dev_info_get = ioat_dev_info_get, .xstats_get = ioat_xstats_get, .xstats_get_names = ioat_xstats_get_names, -- 2.25.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-08 9:51 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200721095140.719297-1-bruce.richardson@intel.com> [not found] ` <20200925110910.284098-1-bruce.richardson@intel.com> 2020-09-25 11:08 ` [dpdk-stable] [PATCH v3 01/25] doc/api: add ioat driver to index Bruce Richardson 2020-09-25 11:08 ` [dpdk-stable] [PATCH v3 02/25] raw/ioat: fix missing close function Bruce Richardson 2020-09-25 11:12 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson 2020-09-25 11:12 ` [dpdk-stable] " Pai G, Sunil [not found] ` <20200928164245.84997-1-bruce.richardson@intel.com> 2020-09-28 16:42 ` [dpdk-stable] [PATCH v4 " Bruce Richardson [not found] ` <20201007163023.2817-1-bruce.richardson@intel.com> 2020-10-07 16:30 ` [dpdk-stable] [PATCH v5 " Bruce Richardson [not found] ` <20201008095133.123014-1-bruce.richardson@intel.com> 2020-10-08 9:51 ` [dpdk-stable] [PATCH v6 " Bruce Richardson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).