* [dpdk-stable] [PATCH v2 4/5] lib/stack: reload head when pop fails
[not found] ` <20200925174340.10014-1-steven.lariau@arm.com>
@ 2020-09-25 17:43 ` Steven Lariau
0 siblings, 0 replies; only message in thread
From: Steven Lariau @ 2020-09-25 17:43 UTC (permalink / raw)
To: Gage Eads, Olivier Matz, Honnappa Nagarahalli
Cc: dev, nd, Steven Lariau, stable
List head must be loaded right before continue (when failed to
find the new head).
Without this, one thread might keep trying and failing to pop items
without ever loading the new correct head.
Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation")
Cc: gage.eads@intel.com
Cc: stable@dpdk.org
Signed-off-by: Steven Lariau <steven.lariau@arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Gage Eads <gage.eads@intel.com>
---
lib/librte_stack/rte_stack_lf_c11.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_stack/rte_stack_lf_c11.h b/lib/librte_stack/rte_stack_lf_c11.h
index 2bc639419..adb9f590d 100644
--- a/lib/librte_stack/rte_stack_lf_c11.h
+++ b/lib/librte_stack/rte_stack_lf_c11.h
@@ -133,8 +133,10 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,
/* If NULL was encountered, the list was modified while
* traversing it. Retry.
*/
- if (i != num)
+ if (i != num) {
+ old_head = list->head;
continue;
+ }
new_head.top = tmp;
new_head.cnt = old_head.cnt + 1;
--
2.17.1
^ permalink raw reply [flat|nested] only message in thread