From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42406A04BC for ; Thu, 1 Oct 2020 19:13:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14E961D587; Thu, 1 Oct 2020 19:13:39 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 171AB1C0CD; Thu, 1 Oct 2020 19:13:34 +0200 (CEST) IronPort-SDR: rerSx4iIOAuQekAt43SkEkiRC57bHAOKDlFpB0v/LTwLPmq8ssZzPdf/fiwK5kC2mnUvr8O/8K ILefXBzRHNXw== X-IronPort-AV: E=McAfee;i="6000,8403,9761"; a="180939427" X-IronPort-AV: E=Sophos;i="5.77,324,1596524400"; d="scan'208";a="180939427" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2020 10:13:30 -0700 IronPort-SDR: ijpsL6XgeEEPv7+8hRVI25aapFegGorX7D6PUaScbXll+So5j32X0JZkSwZdjDTGHdUMrac1+N G5KJ9g5vtQ2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,324,1596524400"; d="scan'208";a="458238147" Received: from silpixa00399838.ir.intel.com ([10.237.213.224]) by orsmga004.jf.intel.com with ESMTP; 01 Oct 2020 10:13:29 -0700 From: Kevin Laatz To: dev@dpdk.org Cc: ferruh.yigit@intel.com, bruce.richardson@intel.com, stephen@networkplumber.org, Kevin Laatz , stable@dpdk.org Date: Thu, 1 Oct 2020 18:09:02 +0100 Message-Id: <20201001170902.487111-1-kevin.laatz@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200922172015.266698-1-kevin.laatz@intel.com> References: <20200922172015.266698-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH v2] net/ring: fix unchecked return value X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Add a check for the return value of the sscanf call in parse_internal_args(), returning an error if we don't get the expected result. Coverity issue: 362049 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Cc: stable@dpdk.org Signed-off-by: Kevin Laatz --- v2: added consumed characters count check --- drivers/net/ring/rte_eth_ring.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 40fe1ca4ba..66367465fd 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -538,8 +538,13 @@ parse_internal_args(const char *key __rte_unused, const char *value, { struct ring_internal_args **internal_args = data; void *args; + int n; - sscanf(value, "%p", &args); + if (sscanf(value, "%p%n", &args, &n) != 1 || (size_t)n != strlen(value)) { + PMD_LOG(ERR, "Error parsing internal args"); + + return -1; + } *internal_args = args; -- 2.25.1