From: David Coyle <david.coyle@intel.com> To: david.coyle@intel.com, davidcoyle0@gmail.com Cc: stable@dpdk.org Subject: [dpdk-stable] [PATCH v2] crypto/aesni_mb: fix incorrect clearing of security session Date: Tue, 6 Oct 2020 12:23:47 +0100 Message-ID: <20201006112347.52351-1-david.coyle@intel.com> (raw) When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object. This patch fixes this issue by now clearing the private session object. Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") Cc: stable@dpdk.org Signed-off-by: David Coyle <david.coyle@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- v2: * CC'ing stable@dpdk.org drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c index 2362f0c3c..b11d7f12b 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c @@ -911,7 +911,7 @@ aesni_mb_pmd_sec_sess_destroy(void *dev __rte_unused, if (sess_priv) { struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv); - memset(sess, 0, sizeof(struct aesni_mb_session)); + memset(sess_priv, 0, sizeof(struct aesni_mb_session)); set_sec_session_private_data(sess, NULL); rte_mempool_put(sess_mp, sess_priv); } -- 2.17.1
next reply other threads:[~2020-10-06 11:23 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-06 11:23 David Coyle [this message] [not found] <20201006094215.49882-1-david.coyle@intel.com> 2020-10-06 11:40 ` David Coyle 2020-10-09 19:31 ` Akhil Goyal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201006112347.52351-1-david.coyle@intel.com \ --to=david.coyle@intel.com \ --cc=davidcoyle0@gmail.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git