From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AE29A04BA for ; Thu, 8 Oct 2020 00:56:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5032311A4; Thu, 8 Oct 2020 00:56:57 +0200 (CEST) Received: from smtp-fw-4101.amazon.com (smtp-fw-4101.amazon.com [72.21.198.25]) by dpdk.org (Postfix) with ESMTP id 4E24D11A4 for ; Thu, 8 Oct 2020 00:56:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1602111417; x=1633647417; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=cLbWe+RPWWvITDuzAUDW/EHseGWfZHVV0Cy+k08sZfk=; b=qQvL8YzB6wcjnhKbWmjIz+zNdKBPyp9kHRmJMQ5VjHMV+vgSW/nvpG+X HUAjomaiN+w21OEM9LecTFrMvIYirzhF/htnIwFW35UZDReYfccmH7Sbg 3dRJVGqbtaDbJGVqQTNSv3Qbvq7RHYkFeDvW4RnWwcKxWYeUeqnVGq2BL I=; X-IronPort-AV: E=Sophos;i="5.77,348,1596499200"; d="scan'208";a="58702538" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1e-a70de69e.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 07 Oct 2020 22:56:48 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1e-a70de69e.us-east-1.amazon.com (Postfix) with ESMTPS id F1C9FA1F2D; Wed, 7 Oct 2020 22:56:46 +0000 (UTC) Received: from EX13D02UWB002.ant.amazon.com (10.43.161.160) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Oct 2020 22:56:46 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D02UWB002.ant.amazon.com (10.43.161.160) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Oct 2020 22:56:45 +0000 Received: from dev-dsk-vcchunga-2a-c5-3b7a0bed.us-west-2.amazon.com (172.19.55.163) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 7 Oct 2020 22:56:46 +0000 Received: by dev-dsk-vcchunga-2a-c5-3b7a0bed.us-west-2.amazon.com (Postfix, from userid 6361087) id 31684A411B; Wed, 7 Oct 2020 15:56:46 -0700 (PDT) From: Vimal Chungath To: CC: , , , , , Date: Wed, 7 Oct 2020 15:56:38 -0700 Message-ID: <20201007225638.10517-1-vcchunga@amazon.com> X-Mailer: git-send-email 2.16.6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [dpdk-stable] [19.11] [PATCH 1/1] config: add Graviton2(arm64) defconfig X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/7/20 2:18 AM, Luca Boccassi wrote: > > On Tue, 2020-10-06 at 11:44 -0700, Vimal Chungath wrote: >> On 10/6/20 1:12 AM, Luca Boccassi wrote: >>> >>> On Mon, 2020-10-05 at 11:50 -0700, Vimal Chungath wrote: >>>> This patch adds make build configuration for AWS Graviton2 platform >>>> based on ARM Neoverse N1. Meson build works but uses configuration for >>>> N1 SDP that is not optimal. Rework in meson build system for ARM SoCs >>>> is planned so I have chosen not to add meson configuration for this >>>> 19.11 patch. >>>> >>>> Vimal Chungath (1): >>>> config: add Graviton2(arm64) defconfig >>>> >>>> config/defconfig_arm64-graviton2-linux-gcc | 1 + >>>> config/defconfig_arm64-graviton2-linuxapp-gcc | 13 +++++++++++ >>>> config/defconfig_graviton2 | 1 + >>>> mk/machine/graviton2/rte.vars.mk | 33 +++++++++++++++++++++++++++ >>>> 4 files changed, 48 insertions(+) >>>> create mode 120000 config/defconfig_arm64-graviton2-linux-gcc >>>> create mode 100644 config/defconfig_arm64-graviton2-linuxapp-gcc >>>> create mode 120000 config/defconfig_graviton2 >>>> create mode 100644 mk/machine/graviton2/rte.vars.mk >>> >>> Hi, >>> >>> Is this adding support for a new driver for 19.11? I don't see it in >>> the main branch? >> >> Hi Luca, >> >> This patch is adding optimal build flags for Graviton2 SoC. >> No new driver is being added. Main branch is no longer accepting make build >> patches as it is deprecated. For 19.11, I assume make is still the default. >> >> This is the meson patch in review for main branch: >> https://patches.dpdk.org/patch/76981/ >> >> Regards, >> Vimal > > I see - normally we are careful with new feature/support in LTS > branches, but this seems self-contained enough to be very low risk so > it seems acceptable to me. But Meson is fully supported, so please > update the patchset so that it applies to both build systems. Meson build works as Neoverse N1 configuration already exists so I chose to not add an explicit patch for it. Unfortunately, getting meson to choose the same flags as make is currently not possible as meson does not accept choosing the exact Arm SoC. More details in the patchwork link above. Meson rework is being planned on main branch to bridge this gap but I'm not sure if it will be backported to 19.11. Honnappa, let us know what you think? > > -- > Kind regards, > Luca Boccassi