From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1542A04BC for ; Sat, 10 Oct 2020 00:03:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0311E1D679; Sat, 10 Oct 2020 00:03:15 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id B20591D65B for ; Sat, 10 Oct 2020 00:03:04 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20201009220254euoutp021b88c580a68e9ffe9412ab65d6e48ef9~8cg6dWSHb2500425004euoutp02D for ; Fri, 9 Oct 2020 22:02:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20201009220254euoutp021b88c580a68e9ffe9412ab65d6e48ef9~8cg6dWSHb2500425004euoutp02D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1602280974; bh=faTZS3uOROPHkE9n9BxhsWOgeJZpgrOtfleCwr1/fg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N2ROe+JdUIAN+Wgsc/hlp5XnXLXyhXCK2RWxJ6Lfhkp3q9akw9DTBS8NJ+Rad9ReI iVG+I9tIvnTYK8n23w1AWBoOUEhP/fJ8Rkaatu3hvoCAsDrSAm7XM5M77kBSqamOdF lbpsq0vD8gDmTBsm90mTmdRKPKWZpsoWSwpxroc4= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201009220248eucas1p25090e0b04a0e234a90740fcfe7dbe9ae~8cg0wuy-q1926719267eucas1p2j; Fri, 9 Oct 2020 22:02:48 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 4F.77.06456.80ED08F5; Fri, 9 Oct 2020 23:02:48 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20201009220247eucas1p1a783663e586127cbfd406a61e13c40eb~8cgz_eH3S0993409934eucas1p1c; Fri, 9 Oct 2020 22:02:47 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201009220247eusmtrp240f9f8f5f3986dbf8691be90abd645bd~8cgz97xtZ1642116421eusmtrp2h; Fri, 9 Oct 2020 22:02:47 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-12-5f80de08b372 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F3.5F.06017.70ED08F5; Fri, 9 Oct 2020 23:02:47 +0100 (BST) Received: from Padamandas.fritz.box (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201009220246eusmtip1a78229ccacaaf34e4a3b32888d1863f1~8cgzRoikl1334813348eusmtip1y; Fri, 9 Oct 2020 22:02:46 +0000 (GMT) From: Lukasz Wojciechowski To: David Hunt , Bruce Richardson Cc: dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org Date: Sat, 10 Oct 2020 00:01:56 +0200 Message-Id: <20201009220202.20834-10-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201009220202.20834-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsWy7djPc7oc9xriDR6/FLa4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoLpuU1JzMstQifbsErowvt5uY Cl7wVLw7fJ6pgfEVVxcjJ4eEgInEtzVHmbsYuTiEBFYwSlxe/oIFwvnCKPF75URGkCohgc+M Eu//18J0TNvYzAZRtJxR4tiG7awQzidGiRufJ4N1sAnYShyZ+ZUVxBYRCJNobt4LNJaDg1nA WeLJVzaQsLCAg8SeaevBbBYBVYm/B7vBynkF3CQ+bdzJBrFMXmL1hgPMIDYnULx11zKw6yQE LrNJbFx2lRWiyEViSsNLKFtY4tXxLewQtozE/53zmSAatjFKXP39kxHC2c8ocb13BVSVtcTh f7/ZIK7TlFi/Sx8i7Chx/d8ZsLCEAJ/EjbeCIGFmIHPStunMEGFeiY42IYhqPYmnPVMZYdb+ WfuEBcL2kNg7fzo0sK4ySixef4VpAqP8LIRlCxgZVzGKp5YW56anFhvmpZbrFSfmFpfmpesl 5+duYgRG/+l/xz/tYPx6KekQowAHoxIPb0NyQ7wQa2JZcWXuIUYJDmYlEV6ns6fjhHhTEiur Uovy44tKc1KLDzFKc7AoifMaL3oZKySQnliSmp2aWpBaBJNl4uCUamBsWBUWYfddVGA249Nr wksmnTlzVkw1XOjnZ5sL/q9SDm6U7NQM3/Fo9UeOxbdj7EqXl1z9+cLZtCL/RNqxbfs3h3W+ j06f/t/Tiu+70lPvuXqy1xIvzzH9LGv2onZqldZe68+yX2+sv5givfrlNMUzp1bOWH6/1GiL 04agU7br3J4/908W/sR1UYmlOCPRUIu5qDgRAFKsMe36AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t/xu7rs9xriDRaukLG4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoPZui/NKSVIWM/OISW6VoQwsj PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYwvt5uYCl7wVLw7fJ6pgfEVVxcjJ4eE gInEtI3NbCC2kMBSRom3rw27GDmA4jISHy4JQJQIS/y51gVUwgVU8oFRYt/q5awgCTYBW4kj M7+ygtSLCIRJnFjpDxJmFnCX2LJ4KjOILSzgILFn2nqw8SwCqhJ/D3aDtfIKuEl82riTDWK+ vMTqDQfA6jmB4q27lrFA7GpklNhy4CXzBEa+BYwMqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3 MQIDcduxn1t2MHa9Cz7EKMDBqMTDq5HYEC/EmlhWXJl7iFGCg1lJhNfp7Ok4Id6UxMqq1KL8 +KLSnNTiQ4ymQFdNZJYSTc4HRkleSbyhqaG5haWhubG5sZmFkjhvh8DBGCGB9MSS1OzU1ILU Ipg+Jg5OqQbGWHO/b4plgitKCn7zbou7rrnVNyJ6b5qE4vnkqhq3xVzFlx61KD7ZPW3d1wkq oRMYnSbZ3ze7bDkvS2hpikf9x2+dXSLx0xb2rXOszN5pyF4wkenyqUDd6JOMPvOnzFKav+Kp x/KJXls8H+7jsWPVXhJapahupPN2YozliUSRyqU2D36c7ClQYinOSDTUYi4qTgQAO7lH5loC AAA= X-CMS-MailID: 20201009220247eucas1p1a783663e586127cbfd406a61e13c40eb X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201009220247eucas1p1a783663e586127cbfd406a61e13c40eb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201009220247eucas1p1a783663e586127cbfd406a61e13c40eb References: <20201008052323.11547-1-l.wojciechow@partner.samsung.com> <20201009220202.20834-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-stable] [PATCH v6 09/15] test/distributor: collect return mbufs X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" During quit_workers function distributor's main core processes some packets to wake up pending worker cores so they can quit. As quit_workers acts also as a cleanup procedure for next test case it should also collect these packages returned by workers' handlers, so the cyclic buffer with returned packets in distributor remains empty. Fixes: c3eabff124e6 ("distributor: add unit tests") Cc: bruce.richardson@intel.com Fixes: c0de0eb82e40 ("distributor: switch over to new API") Cc: david.hunt@intel.com Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski Acked-by: David Hunt --- app/test/test_distributor.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 06e01ff9d..ed03040d1 100644 --- a/app/test/test_distributor.c +++ b/app/test/test_distributor.c @@ -590,6 +590,7 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) const unsigned num_workers = rte_lcore_count() - 1; unsigned i; struct rte_mbuf *bufs[RTE_MAX_LCORE]; + struct rte_mbuf *returns[RTE_MAX_LCORE]; if (rte_mempool_get_bulk(p, (void *)bufs, num_workers) != 0) { printf("line %d: Error getting mbufs from pool\n", __LINE__); return; @@ -605,6 +606,10 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) rte_distributor_flush(d); rte_eal_mp_wait_lcore(); + while (rte_distributor_returned_pkts(d, returns, RTE_MAX_LCORE)) + ; + + rte_distributor_clear_returns(d); rte_mempool_put_bulk(p, (void *)bufs, num_workers); quit = 0; -- 2.17.1