From: Junyu Jiang <junyux.jiang@intel.com> To: shougangx.wang@intel.com Cc: Junyu Jiang <junyux.jiang@intel.com>, stable@dpdk.org Subject: [dpdk-stable] [PATCH] app/testpmd: fix flow flush with invalid port Date: Thu, 15 Oct 2020 06:15:36 +0000 Message-ID: <20201015061536.17639-1-junyux.jiang@intel.com> (raw) There is no error info displayed when running flow flush command with invalid port. This patch fixed the issue. Fixes: 2a449871a12d ("app/testpmd: align behaviour of multi-port detach") Cc: stable@dpdk.org Signed-off-by: Junyu Jiang <junyux.jiang@intel.com> --- app/test-pmd/config.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index fe31a9d52..cc4527386 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1775,16 +1775,17 @@ port_flow_flush(portid_t port_id) struct rte_port *port = &ports[port_id]; int ret = 0; + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) + return -EINVAL; + if (port->flow_list == NULL) return ret; /* Poisoning to make sure PMDs update it in case of error. */ memset(&error, 0x44, sizeof(error)); if (rte_flow_flush(port_id, &error)) { - ret = port_flow_complain(&error); - if (port_id_is_invalid(port_id, DISABLED_WARN) || - port_id == (portid_t)RTE_PORT_ALL) - return ret; + port_flow_complain(&error); } while (port->flow_list) { -- 2.17.1
next reply other threads:[~2020-10-15 6:23 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-15 6:15 Junyu Jiang [this message] -- strict thread matches above, loose matches on Subject: below -- 2020-10-14 8:30 Junyu Jiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201015061536.17639-1-junyux.jiang@intel.com \ --to=junyux.jiang@intel.com \ --cc=shougangx.wang@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git