From: Bruce Richardson <bruce.richardson@intel.com>
To: Luca Boccassi <bluca@debian.org>
Cc: dev@dpdk.org, david.marchand@redhat.com,
arybchenko@solarflare.com, ferruh.yigit@intel.com,
thomas@monjalon.net, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 3/7] build: add defines for compatibility with make build
Date: Thu, 15 Oct 2020 12:20:00 +0100 [thread overview]
Message-ID: <20201015112000.GC554@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <9d06a3d9eb1792c02e909d44fdcfd527531c4848.camel@debian.org>
On Thu, Oct 15, 2020 at 11:31:18AM +0100, Luca Boccassi wrote:
> On Wed, 2020-10-14 at 15:13 +0100, Bruce Richardson wrote:
> > The defines used to indicate what crypto, compression and eventdev drivers
> > were being built were different to those used in the make build, with meson
> > defining them with "_PMD" at the end, while make defined them with "_PMD"
> > in the middle and the specific driver name at the end. This might cause
> > compatibility issues for applications which used the older defines, which
> > switching to build against new DPDK releases.
> >
> > As well as changing the default to match that of make, meson also
> > special-cases the crypto/compression/event drivers to have both defines
> > provided. This ensures compatibility for these macros with both meson and
> > make from older versions.
> >
> > For a selection of other libraries and drivers, there were other
> > incompatibilities between the meson and make-defined macros which were not
> > previously highlighted in a deprecation notice, so we add per-macro
> > compatibility defines for these to ease the transition from make to meson.
> >
> > Fixes: 5b9656b157d3 ("lib: build with meson")
> > Fixes: 9314afb68a53 ("drivers: add infrastructure for meson build")
> > Fixes: dcadbbde8e61 ("crypto/null: build with meson")
> > Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD")
> > Fixes: eca504f318db ("drivers/event: build skeleton and SW drivers with meson")
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > app/test/meson.build | 1 +
> > config/meson.build | 3 +-
> > config/rte_compatibility_defines.h | 129 +++++++++++++++++++++++++++++
> > config/rte_config.h | 1 +
> > drivers/compress/meson.build | 2 +-
> > drivers/crypto/meson.build | 2 +-
> > drivers/event/meson.build | 2 +-
> > drivers/meson.build | 15 ++++
> > 8 files changed, 151 insertions(+), 4 deletions(-)
> > create mode 100644 config/rte_compatibility_defines.h
> >
> > diff --git a/app/test/meson.build b/app/test/meson.build
> > index dedf29dd7..fc90a1909 100644
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> > @@ -415,6 +415,7 @@ endif
> >
> > if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
> > driver_test_names += 'cryptodev_scheduler_autotest'
> > + test_deps += 'pmd_crypto_scheduler'
> > endif
> >
> > foreach d:test_deps
>
> This change looks out of place in this patch? Was it supposed to be
> part of one of the previous commits maybe?
>
> Other than that,
>
> Acked-by: Luca Boccassi <bluca@debian.org>
>
Yes, it looks like it probably should be. I'll investigate and do a v5
(since I had v4 already done before I saw this comment!)
/Bruce
next prev parent reply other threads:[~2020-10-15 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200916164429.244847-1-bruce.richardson@intel.com>
2020-09-16 16:44 ` [dpdk-stable] [RFC PATCH 1/5] app: fix missing dependencies Bruce Richardson
2020-09-16 16:44 ` [dpdk-stable] [RFC PATCH 2/5] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-09-16 16:44 ` [dpdk-stable] [RFC PATCH 3/5] meson: fix compatibility with make build defines Bruce Richardson
2020-09-16 16:44 ` [dpdk-stable] [RFC PATCH 4/5] build: add defines for compatibility with make build Bruce Richardson
[not found] ` <20201002155855.622456-1-bruce.richardson@intel.com>
2020-10-02 15:58 ` [dpdk-stable] [RFC PATCH v2 1/8] app: fix missing dependencies Bruce Richardson
2020-10-02 15:58 ` [dpdk-stable] [RFC PATCH v2 2/8] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-02 15:58 ` [dpdk-stable] [RFC PATCH v2 3/8] build: add defines for compatibility with make build Bruce Richardson
[not found] ` <20201014141304.632120-1-bruce.richardson@intel.com>
2020-10-14 14:12 ` [dpdk-stable] [PATCH v3 1/7] app: fix missing dependencies Bruce Richardson
2020-10-15 10:32 ` Luca Boccassi
2020-10-14 14:12 ` [dpdk-stable] [PATCH v3 2/7] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-15 10:32 ` Luca Boccassi
2020-10-14 14:13 ` [dpdk-stable] [PATCH v3 3/7] build: add defines for compatibility with make build Bruce Richardson
2020-10-15 10:31 ` Luca Boccassi
2020-10-15 11:20 ` Bruce Richardson [this message]
[not found] ` <20201015110359.706644-1-bruce.richardson@intel.com>
2020-10-15 11:03 ` [dpdk-stable] [PATCH v4 1/8] app: fix missing dependencies Bruce Richardson
2020-10-15 11:03 ` [dpdk-stable] [PATCH v4 2/8] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-15 11:03 ` [dpdk-stable] [PATCH v4 3/8] build: add defines for compatibility with make build Bruce Richardson
[not found] ` <20201015150554.950838-1-bruce.richardson@intel.com>
2020-10-15 15:05 ` [dpdk-stable] [PATCH v5 1/8] app: fix missing dependencies Bruce Richardson
2020-10-15 15:05 ` [dpdk-stable] [PATCH v5 2/8] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-15 15:05 ` [dpdk-stable] [PATCH v5 3/8] build: add defines for compatibility with make build Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015112000.GC554@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).