patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com,
	ranjit.menon@intel.com, navasile@linux.microsoft.com,
	dmitrym@microsoft.com, ophirmu@nvidia.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] eal/windows: fix missing header inclusion
Date: Tue, 20 Oct 2020 12:37:52 +0300
Message-ID: <20201020123752.6e266990@sovereign> (raw)
In-Reply-To: <20201020084815.13796-1-talshn@nvidia.com>

On Tue, 20 Oct 2020 11:48:15 +0300, Tal Shnaiderman wrote:
> Following the addition of the in_addr/in6_addr structs
> to in.h the header file must have stdint.h included
> for the definitions of the uint8_t/uint32_t types used
> within the new structs.
> 
> Not having it could results in the following errors
> in places where in.h is included:
> 
> in.h:30:2: error: unknown type name 'uint32_t'
>         uint32_t s_addr;
> 
> in.h:34:2: error: unknown type name 'uint8_t'
>         uint8_t s6_addr[16];
> 
> Fixes: f40a74cfcf0 ("eal/windows: improve compatibility networking headers")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>  lib/librte_eal/windows/include/netinet/in.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/windows/include/netinet/in.h b/lib/librte_eal/windows/include/netinet/in.h
> index be1469ec11..6455b9ba51 100644
> --- a/lib/librte_eal/windows/include/netinet/in.h
> +++ b/lib/librte_eal/windows/include/netinet/in.h
> @@ -5,6 +5,7 @@
>  #ifndef _IN_H_
>  #define _IN_H_
>  
> +#include <stdint.h>
>  #include <sys/socket.h>
>  
>  #define IPPROTO_IP         0

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

      reply	other threads:[~2020-10-20  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  8:48 Tal Shnaiderman
2020-10-20  9:37 ` Dmitry Kozlyuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201020123752.6e266990@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=ophirmu@nvidia.com \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git