From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9466FA04DD for ; Wed, 28 Oct 2020 11:52:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CED6C96E; Wed, 28 Oct 2020 11:52:08 +0100 (CET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by dpdk.org (Postfix) with ESMTP id 65E042C2A for ; Wed, 28 Oct 2020 11:52:07 +0100 (CET) Received: by mail-wm1-f49.google.com with SMTP id d3so4303062wma.4 for ; Wed, 28 Oct 2020 03:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KsAHfs3aD7zI7FiK9jmSq4pP1vshAqHzOapSARt+5Ok=; b=ltYWRkLPbymCR0P5YDBv44wol87+IeIHIrINkdpGU+FzD+IuiFqQgR1aao6cCQIM3N fvDlj5+C32IOOIANLdxOW3gJH6mX7Hpz1wuiRYNjew9HJzfRQmRcKjLV2b2pOySIQ3Ak TWkwNrmhtaT6SVZK20UaQ9b7B2TlDCa2j9lxlkAEso7Es6uJHv8/h5bB1hvpA4jDXCS4 zWpKT5VOtKahR1tuo6gffP89lgFoEMk7pqWq4ayAyl5rrKzdYcFOxcDn/Vndy412s5Bq Ei22tinOW74YnnPAK1E8ByTbmZZYTBlirprUzQFYjGUZCsmkEYIB2hY3OA1jiP73Ec5/ wLAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KsAHfs3aD7zI7FiK9jmSq4pP1vshAqHzOapSARt+5Ok=; b=JlihJhArJXIN9bmsTbNM9VDhw6W9B7hmNYgdaMxxykk1xQac10TwhGNvujEdAihrh/ 2SCliJ3Pb4r0oGuMMoKz90HSGQICqNw/UY3wbo/SUtsYmWPexUtSfBJdGQQqe3I7dRLm ekHFFjcTH+hIKC3MQgnhGAVd8NHe0UfNjUfxySDJYcoAjN8AKpJH3Q0nubmNmTbh1g/y oV2uczGoLv4zeIldPI+e6JdIsUnBX1AZd1figI4yu8FE1agDdxFxA8k1LWinU740OwUo pAHnbhvANmWgFUklLdBEHx265sQV5t6yKyf9MMw01kOJhY5WxEMEzmCBsyfJF7QA3HvL cRZw== X-Gm-Message-State: AOAM531kykxGTH9Y0kdyPj/qFRRZ9jdTZD53jv1Wa1KIsdopmObsEaFd QYQ+o2eMD7JneuumVZUr5Kc= X-Google-Smtp-Source: ABdhPJy9sZmqYGxqFFBJSab2d6ID1AwOES7kmo3jZWXnjmDcywKJAuj7xffW1IwJp88PdCU4QvIHMQ== X-Received: by 2002:a7b:c0d3:: with SMTP id s19mr7613630wmh.102.1603882326149; Wed, 28 Oct 2020 03:52:06 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id o7sm6426995wrp.23.2020.10.28.03.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:52:05 -0700 (PDT) From: luca.boccassi@gmail.com To: Lukasz Wojciechowski Cc: dpdk stable Date: Wed, 28 Oct 2020 10:44:30 +0000 Message-Id: <20201028104606.3504127-111-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'raw/skeleton: allow closing already closed device' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 8a53e82ec4504863795134649ac80ad2f230bcd8 Mon Sep 17 00:00:00 2001 From: Lukasz Wojciechowski Date: Mon, 21 Sep 2020 23:44:20 +0200 Subject: [PATCH] raw/skeleton: allow closing already closed device [ upstream commit e640362b34e868b82bfb047761e05056ba77e58e ] This patch return OK code (0) from skeleton_rawdev_close function if firmware is in SKELETON_FW_READY state. Formerly it returned -EINVAL error code. Returning an error here is troublesome as it disallows proper release of the rawdev. The rte_rawdev_pmd_release function from librte_rawdev library calls drivers' rawdev_close handler and continues execution only in case of errorless call. (see lib/librte_rawdev/rte_rawdev.c:540) The SKELETON_FW_READY state is reached after creation, reset, unload or close of the device. The device should be ok to be released in such situations. To reproduce issue fixed by this patch, call rawdev_autotest from dpdk-test app for few times. As the device is not properly released, the next calls will fail. Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") Signed-off-by: Lukasz Wojciechowski --- drivers/raw/skeleton/skeleton_rawdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c index 586183a5b8..1daf0fecd2 100644 --- a/drivers/raw/skeleton/skeleton_rawdev.c +++ b/drivers/raw/skeleton/skeleton_rawdev.c @@ -189,9 +189,11 @@ static int skeleton_rawdev_close(struct rte_rawdev *dev) } break; case SKELETON_FW_READY: + SKELETON_PMD_DEBUG("Device already in stopped state"); + break; case SKELETON_FW_ERROR: default: - SKELETON_PMD_DEBUG("Device already in stopped state"); + SKELETON_PMD_DEBUG("Device in impossible state"); ret = -EINVAL; break; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:15.210176241 +0000 +++ 0111-raw-skeleton-allow-closing-already-closed-device.patch 2020-10-28 10:35:11.664832379 +0000 @@ -1,8 +1,10 @@ -From e640362b34e868b82bfb047761e05056ba77e58e Mon Sep 17 00:00:00 2001 +From 8a53e82ec4504863795134649ac80ad2f230bcd8 Mon Sep 17 00:00:00 2001 From: Lukasz Wojciechowski Date: Mon, 21 Sep 2020 23:44:20 +0200 Subject: [PATCH] raw/skeleton: allow closing already closed device +[ upstream commit e640362b34e868b82bfb047761e05056ba77e58e ] + This patch return OK code (0) from skeleton_rawdev_close function if firmware is in SKELETON_FW_READY state. Formerly it returned -EINVAL error code. @@ -22,7 +24,6 @@ released, the next calls will fail. Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") -Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski --- @@ -30,10 +31,10 @@ 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c -index f8b47a391a..aa3beaad18 100644 +index 586183a5b8..1daf0fecd2 100644 --- a/drivers/raw/skeleton/skeleton_rawdev.c +++ b/drivers/raw/skeleton/skeleton_rawdev.c -@@ -190,9 +190,11 @@ static int skeleton_rawdev_close(struct rte_rawdev *dev) +@@ -189,9 +189,11 @@ static int skeleton_rawdev_close(struct rte_rawdev *dev) } break; case SKELETON_FW_READY: