From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C822A04DD for ; Wed, 28 Oct 2020 11:52:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 244CFC9C0; Wed, 28 Oct 2020 11:52:27 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by dpdk.org (Postfix) with ESMTP id 59ED249E0 for ; Wed, 28 Oct 2020 11:52:23 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id e2so4306188wme.1 for ; Wed, 28 Oct 2020 03:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JJAEY1Li/uy6ZnSECZ8ELpRHxGC8FwWsReI5KyoKw90=; b=ji+tDJAUL4uc5m0UUkr0Pl+IOUOz2irAC6aT8wOpa5euchNRJBhqribtSJZldlHQOq W6z6oGz2W4deqQjfS3KDBA+hd++GmaXwrEzaw3DvKEKSjD54XsRetjHvvazmkA//SezA ZXJLYKtL36+wEZKvv2KCaEydtGHIR9DStUHM3fzgJS+1mKzpzLbiLNN/wTTE6wmNtKjg nn69YPbHJtkKLCXzydwf5ENZtheroo7AETlatAq9MXUoynFSN/tIG0bDHiYVduFww9k0 r179+ORzy2htRFE8fKjuU9qY3aB6WKxOKxnxOElEoNx1K4Tol6RcTNQCWx7OeTNcdslN D0fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JJAEY1Li/uy6ZnSECZ8ELpRHxGC8FwWsReI5KyoKw90=; b=HK480zxza2HK0ICR347NhqQtHErUl5HlEmeAR6LN6W495KvrVdwnY4PZiJGkKqdMHv SVqwlXZdtwLJjliwqEjg2ObC9qQoyDvqOqgBEhEF20K2B31DlY2Zi7LTazOyUYbsYXLN XHZEmAukgNJ1OtAf4u4v+ovIaHZqVxBWfesHkw+q+HOrP2yFzLvYtk1VElA3IUMZeRI/ qwVUAq1c5wwjEvl5tuaEY9UQGCTPzmpMHJgTM+Uobm1ez5X4D8jH3kNCDkh+TPREGOd8 lT3aDEMT+dpgevLOUueafDt7RsQzC7ZUgezutAEyWWBO2e1qXXe7lJEIqpkUTZEnmFHI lRAw== X-Gm-Message-State: AOAM533wGF9VARUxB/PY0idBVAEaJaLXZsQ5+CuYKx1Dgn+TnAnybeDi yakOX6G2sEBsEO7HUXNRC1Osw6+FwexudClK X-Google-Smtp-Source: ABdhPJwCp1quw9DDGtp2Q8AvWfG5HCJP1R82NvUEkSZkTDNFePj2Na7ZBdWvmREr1JeY/uW+/XDv1Q== X-Received: by 2002:a1c:1fd1:: with SMTP id f200mr4588369wmf.68.1603882343153; Wed, 28 Oct 2020 03:52:23 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u3sm7304170wme.0.2020.10.28.03.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:52:22 -0700 (PDT) From: luca.boccassi@gmail.com To: Kevin Laatz Cc: Sunil Pai G , Bruce Richardson , Radu Nicolau , dpdk stable Date: Wed, 28 Oct 2020 10:44:36 +0000 Message-Id: <20201028104606.3504127-117-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'raw/ioat: fix missing close function' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From b0e37c91df43873f22c843875accceb1e11fa83f Mon Sep 17 00:00:00 2001 From: Kevin Laatz Date: Thu, 8 Oct 2020 10:51:10 +0100 Subject: [PATCH] raw/ioat: fix missing close function [ upstream commit 8c6cedee761c7abd8c3d451bffa7c70747ab7629 ] When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") Reported-by: Sunil Pai G Signed-off-by: Kevin Laatz Reviewed-by: Bruce Richardson Acked-by: Sunil Pai G Acked-by: Radu Nicolau --- drivers/raw/ioat/ioat_rawdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c index af8414b34c..a9b762330a 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c @@ -198,6 +198,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids) return 0; } +static int +ioat_dev_close(struct rte_rawdev *dev __rte_unused) +{ + return 0; +} + extern int ioat_rawdev_test(uint16_t dev_id); static int @@ -207,6 +213,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev) .dev_configure = ioat_dev_configure, .dev_start = ioat_dev_start, .dev_stop = ioat_dev_stop, + .dev_close = ioat_dev_close, .dev_info_get = ioat_dev_info_get, .xstats_get = ioat_xstats_get, .xstats_get_names = ioat_xstats_get_names, -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:15.386270719 +0000 +++ 0117-raw-ioat-fix-missing-close-function.patch 2020-10-28 10:35:11.672832496 +0000 @@ -1,8 +1,10 @@ -From 8c6cedee761c7abd8c3d451bffa7c70747ab7629 Mon Sep 17 00:00:00 2001 +From b0e37c91df43873f22c843875accceb1e11fa83f Mon Sep 17 00:00:00 2001 From: Kevin Laatz Date: Thu, 8 Oct 2020 10:51:10 +0100 Subject: [PATCH] raw/ioat: fix missing close function +[ upstream commit 8c6cedee761c7abd8c3d451bffa7c70747ab7629 ] + When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. @@ -10,7 +12,6 @@ This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e842e328 ("raw/ioat: introduce IOAT driver") -Cc: stable@dpdk.org Reported-by: Sunil Pai G Signed-off-by: Kevin Laatz @@ -22,10 +23,10 @@ 1 file changed, 7 insertions(+) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c -index 7f1a154360..0732b059fe 100644 +index af8414b34c..a9b762330a 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c -@@ -203,6 +203,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids) +@@ -198,6 +198,12 @@ ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids, uint32_t nb_ids) return 0; } @@ -38,7 +39,7 @@ extern int ioat_rawdev_test(uint16_t dev_id); static int -@@ -212,6 +218,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev) +@@ -207,6 +213,7 @@ ioat_rawdev_create(const char *name, struct rte_pci_device *dev) .dev_configure = ioat_dev_configure, .dev_start = ioat_dev_start, .dev_stop = ioat_dev_stop,