From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E4F4A04DD for ; Wed, 28 Oct 2020 11:46:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51D6FC9FE; Wed, 28 Oct 2020 11:46:49 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by dpdk.org (Postfix) with ESMTP id 9049FC9D6 for ; Wed, 28 Oct 2020 11:46:46 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id c194so4075408wme.2 for ; Wed, 28 Oct 2020 03:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vwBd/skCwE1VijHR6oEvNFpgqA/Dm9uJl+h7Yh5otQU=; b=SN6vGIEzkflobfPcCRQ+4taWdIMTrD4YqA/7CxCfbAucexjruD21v3t3tYWGzfJ6nV 9BJOWXsIxxZY06aug4g0O9hq8n0y2qdufNA+vTyRM/SZ2hD3xUWpi6ZV7rhFGvsJzJ2D BTimJ/uNCfl7aR2nbUi4LaVGqE+3/nMAxdxemsS6iQd66h2neikScSJ7AaGOEIM5JVqP MWt7EiaY+F0DyshElqWWQv3Lqueb6Zq3I98hwJZtTLPeM4wGPaISf99kWq8imYel4c7M R2l6skkXcy3F8y8tOPNMmT64+wCt14ohugj+c4v11jyRB9fopNCJMcvcRZWOYvyGln4V lK1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vwBd/skCwE1VijHR6oEvNFpgqA/Dm9uJl+h7Yh5otQU=; b=RYXXr7qBkv3si7a6+nlVUK7rhEhMEHZJiHRU4ZtcC78rxi3Jlw/0jsO+b5zsnwvrAT Kr/U6cNuMzfh3JyQ/8lWqNY5RVKAkTxaRvGr4t4bYe8mVp3yjgjiviQBWsdZtgiLKg9b COLcjgO3RgkJpPn8GNGSluWtEFACHPjWRjE9e+ah/e0VwVo+OS/KzLKu4262NWWfFlfM Nhf/Nr8b2xeCDhV4SVNUd9JX/NDvB4PvaNRJAusOP4Rzan4/UJ3KUAO1pTIwQdDtagVB 60Y6nIjFIm6bCyMUa863/Ew8KlJvgBPKLHQAmdxfYVLpJepTN0BvziMrGn6emZKtAZru BRWg== X-Gm-Message-State: AOAM533hO0iKiRiEHOEiZh/XKBKRkpK7P7CD0Jd1kbitjkYIIppfyjAW YCiChuXpWTCw4GpZxNWc8vlkt3tE9f05dg== X-Google-Smtp-Source: ABdhPJwrMHEHq3JaqjPuINDciFny47gWaJys6PScjHnoaNXTMvbKdsvOF93x5zr663MGXwHNzTXesA== X-Received: by 2002:a1c:2283:: with SMTP id i125mr7338589wmi.41.1603882006303; Wed, 28 Oct 2020 03:46:46 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b7sm6460250wrp.16.2020.10.28.03.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:46:45 -0700 (PDT) From: luca.boccassi@gmail.com To: Venkat Duvvuru Cc: Kalesh AP , Somnath Kotur , Ajit Khaparde , dpdk stable Date: Wed, 28 Oct 2020 10:42:51 +0000 Message-Id: <20201028104606.3504127-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix LRO configuration' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 0322383d4d264aa6f14e2d43772f5457bcee559d Mon Sep 17 00:00:00 2001 From: Venkat Duvvuru Date: Fri, 28 Aug 2020 10:31:08 +0530 Subject: [PATCH] net/bnxt: fix LRO configuration [ upstream commit 349355141cfe5823cd60d75e5e2f8b2acf3f8b17 ] The maximum number of TCP segments that can be aggregated & the maximum number of aggregations the VNIC supports are configured incorrectly during LRO configuration. This patch fixes these values. Fixes: b150a7e7ee66 ("net/bnxt: support LRO on Thor adapters") Signed-off-by: Venkat Duvvuru Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index f78563e944..ddcb81f29c 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2127,8 +2127,8 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp, HWRM_VNIC_TPA_CFG_INPUT_FLAGS_GRO | HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_ECN | HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_SAME_GRE_SEQ); - req.max_agg_segs = rte_cpu_to_le_16(BNXT_TPA_MAX_AGGS(bp)); - req.max_aggs = rte_cpu_to_le_16(BNXT_TPA_MAX_SEGS(bp)); + req.max_aggs = rte_cpu_to_le_16(BNXT_TPA_MAX_AGGS(bp)); + req.max_agg_segs = rte_cpu_to_le_16(BNXT_TPA_MAX_SEGS(bp)); req.min_agg_len = rte_cpu_to_le_32(512); } req.vnic_id = rte_cpu_to_le_16(vnic->fw_vnic_id); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:12.166086957 +0000 +++ 0012-net-bnxt-fix-LRO-configuration.patch 2020-10-28 10:35:11.416828728 +0000 @@ -1,8 +1,10 @@ -From 349355141cfe5823cd60d75e5e2f8b2acf3f8b17 Mon Sep 17 00:00:00 2001 +From 0322383d4d264aa6f14e2d43772f5457bcee559d Mon Sep 17 00:00:00 2001 From: Venkat Duvvuru Date: Fri, 28 Aug 2020 10:31:08 +0530 Subject: [PATCH] net/bnxt: fix LRO configuration +[ upstream commit 349355141cfe5823cd60d75e5e2f8b2acf3f8b17 ] + The maximum number of TCP segments that can be aggregated & the maximum number of aggregations the VNIC supports are configured incorrectly during LRO configuration. @@ -10,7 +12,6 @@ This patch fixes these values. Fixes: b150a7e7ee66 ("net/bnxt: support LRO on Thor adapters") -Cc: stable@dpdk.org Signed-off-by: Venkat Duvvuru Reviewed-by: Kalesh AP @@ -21,10 +22,10 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c -index c1af814040..f326f842b6 100644 +index f78563e944..ddcb81f29c 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c -@@ -2264,8 +2264,8 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp, +@@ -2127,8 +2127,8 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp, HWRM_VNIC_TPA_CFG_INPUT_FLAGS_GRO | HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_ECN | HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_SAME_GRE_SEQ);