From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EAECA04DD for ; Wed, 28 Oct 2020 11:52:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE240CA18; Wed, 28 Oct 2020 11:52:43 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id E9654CA18 for ; Wed, 28 Oct 2020 11:52:42 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id i1so5197216wro.1 for ; Wed, 28 Oct 2020 03:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3GE1weNW5aHx9lXCZPrMi42wTIX1WiY7pHusF2QaAFQ=; b=ZuT8iAALxaLSn+cIkjz0zvJwZMd/KJMnyU4pSkEkPnmU4uX4lZS4WM+pt1r4V8HRXu gOn+n6Ym2dLlM6ElSJhY71+o6Ve1xahEHudzODtin1lc1Pq5XxSXb0stCHblCHkQdwWc 0Q8Haj5Q5pPzgKo9xuqg3S7KaFJB3cRE8PIeP2Pae1cbYtE7qrtZnI+O3NySrlhYXcW6 OyKjWHZyaDyqzqpEbF3sr1ELaFZ5ZShDX2FxZdu/gHgLaxLBrzbiYGGn2eCRfNRDnK7x sCVireMoPCLUT7JLCekuxiQGzKhfYX1oC4zfpLP6NwfwGElXOodBHJbm+aF7u4cMG4FO Ac/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3GE1weNW5aHx9lXCZPrMi42wTIX1WiY7pHusF2QaAFQ=; b=KKzNSsmQ19iY0zgnzhabIYbFR8xc9lDG91ucBWMhkAXqMwAgJBHMS81fSsuNDPZGwL b5UckbcJr8e0OEKHgTO11dnakqgZDGsc6nuvStmPXwc66DIuhSKGV/SbAl0s334HmEiS EGy2VQ5V6yV+rwbODk00nPrKCz0s3fU9GSaQa8FWjhplRZrev+6FohqFZz1xCqrCvdrR G4kAkHyenku8P91yvK2Nx5OIiturYvrnE7P5VV38LRfFUkZwstv5GeaN6FbXudQ3rsgU PpcihLVl+BBmmxjLUnKGhF6+qt+YGQIfi+84U9r6PwK+owHSKrBkJO4cyyl4wNcBHrtc Fowg== X-Gm-Message-State: AOAM5302I4+IlHbeDlc1cWWh7o0tKOV+m1i1l+WTivB0/WKBbbMYt2d/ yPDxReNO/+StOYo5yD6uMFQ= X-Google-Smtp-Source: ABdhPJyrO3Eh8CNWF6riPTNGrWy4Nb29usnii8GxA0xWqdhD8pHk/LCM9vnb3b5TWdg+H5NoM14CXQ== X-Received: by 2002:adf:eb4d:: with SMTP id u13mr7781955wrn.146.1603882361698; Wed, 28 Oct 2020 03:52:41 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g17sm6606144wrw.37.2020.10.28.03.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:52:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Rasesh Mody Cc: Ferruh Yigit , Igor Russkikh , dpdk stable Date: Wed, 28 Oct 2020 10:44:43 +0000 Message-Id: <20201028104606.3504127-124-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix getting link details' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 6efa54e3430982b3f868a023e76b5dc95b40c481 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Fri, 2 Oct 2020 12:59:45 -0700 Subject: [PATCH] net/qede: fix getting link details [ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ] This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler") Reported-by: Ferruh Yigit Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index 8580cbcd7f..67392d6aa4 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -575,13 +575,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link) hwfn = &edev->hwfns[0]; if (IS_PF(edev)) { ptt = ecore_ptt_acquire(hwfn); - if (!ptt) - DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n"); - + if (ptt) { qed_fill_link(hwfn, ptt, if_link); - - if (ptt) ecore_ptt_release(hwfn, ptt); + } else { + DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n"); + } } else { qed_fill_link(hwfn, NULL, if_link); } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:15.600550906 +0000 +++ 0124-net-qede-fix-getting-link-details.patch 2020-10-28 10:35:11.684832673 +0000 @@ -1,13 +1,14 @@ -From effb1d0b9527815a7cd5422bce5defbc0884cea0 Mon Sep 17 00:00:00 2001 +From 6efa54e3430982b3f868a023e76b5dc95b40c481 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Fri, 2 Oct 2020 12:59:45 -0700 Subject: [PATCH] net/qede: fix getting link details +[ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ] + This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler") -Cc: stable@dpdk.org Reported-by: Ferruh Yigit Signed-off-by: Rasesh Mody @@ -17,10 +18,10 @@ 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c -index 0d3cea6e42..caa9d1d4f6 100644 +index 8580cbcd7f..67392d6aa4 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c -@@ -587,13 +587,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link) +@@ -575,13 +575,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link) hwfn = &edev->hwfns[0]; if (IS_PF(edev)) { ptt = ecore_ptt_acquire(hwfn);