From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4A85A04DD for ; Wed, 28 Oct 2020 11:53:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB68149E0; Wed, 28 Oct 2020 11:53:11 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 5D4AD49E0 for ; Wed, 28 Oct 2020 11:53:11 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id y12so5153826wrp.6 for ; Wed, 28 Oct 2020 03:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LQ18sczX6TTqhedryacvLClZ3YbR1XBtkY7TN66AiU0=; b=S5Lm8bqJeXWGQt3ZhErRGXnlR8sGVYkHTkrN2sroJfNcGQrO/2DuaJvSF0tDfSe4K5 hngA0e+Ogfw0Nf22wkMWw3RyoaR7js6TyvSr2qcGjdHziXWbVOR1uf5TOjH/sxIhzSyz ccf4963hSp+EppbqejbZChw20IcnuNiSC0NpRwx9CB86cDsmhMdlnyhZkURP/rk77NQA jQFCG4Lg4qK7lg+c1PMhAOHv1AD3cI0uhCWA4kLOXDl+1uWj3wTQxGHv2MGIXNqNrQ+R MpSq4/PAQ4CI9H5OMeBSv4Pe41kE834CmozWQJTRRfygh++jtFrRhU0zIdJsTVqPUKRb 2+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LQ18sczX6TTqhedryacvLClZ3YbR1XBtkY7TN66AiU0=; b=bXPhXgbiizXjEMFSbI9mw9gahMm3js1ecw7++Fkj+5qTXDoxwA/y7Z1x8LaHbf5ESA Vw+UORcxpkoNBOIJd/NiIl5ErhKE1tOMtfWQgiD1VhYjyHLhZMLaXr2CE5SLxMXzPXCx qhkAuiGM1EG+zM8YHuNW0pIlKKMEkjxEEwhn7SEwQuls4kSdfN5nIMfgiiRWyRzDbnu5 1ChSpKJZf1QZdhXbe3n7lw88989GkMQOOI1Qh2rEnn9N/nMDIvziv5QgMJTMbPZfOo+i 50loepU4UCxy1R9D4Zgntp8UfiCDvuaCGJNaz4cbrMqsLJUQt3ZVN13txUP6DHD06njX fmjQ== X-Gm-Message-State: AOAM532OivG6+AfIXYoYm2B+1xojyb4n5XbYAb/+Kqhz+FXqo/Va1GAk bVEyoPxHTZKGElTKBkLTOR4= X-Google-Smtp-Source: ABdhPJzMIzPYCB0zrYWW4EtWmnbDC6Xyh0wWRc8gNDPrcv0juoJboucnYMFbo3M60gX1bzCKdqvYgw== X-Received: by 2002:adf:914c:: with SMTP id j70mr8575331wrj.170.1603882390079; Wed, 28 Oct 2020 03:53:10 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c10sm5589744wmb.20.2020.10.28.03.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:53:09 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Nipun Gupta , dpdk stable Date: Wed, 28 Oct 2020 10:44:50 +0000 Message-Id: <20201028104606.3504127-131-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'raw/dpaa2_qdma: fix reset' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From d4a043f08be87f7ddb97c4969e3fd2f6beef5cda Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Wed, 9 Sep 2020 09:11:46 +0800 Subject: [PATCH] raw/dpaa2_qdma: fix reset [ upstream commit f4eb44f81d8c47d157523f893fbab9baeb38f9c1 ] This issue detected by coverity, CID#279443(Structurally dead code). Coverity issue: 279443 Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") Signed-off-by: Yunjian Wang Acked-by: Nipun Gupta --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c index c905954004..b31d7aacb3 100644 --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c @@ -455,9 +455,10 @@ rte_qdma_reset(void) /* In case there are pending jobs on any VQ, return -EBUSY */ for (i = 0; i < qdma_dev.max_vqs; i++) { if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues != - qdma_vqs[i].num_dequeues)) + qdma_vqs[i].num_dequeues)) { DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i); return -EBUSY; + } } /* Reset HW queues */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:15.817124946 +0000 +++ 0131-raw-dpaa2_qdma-fix-reset.patch 2020-10-28 10:35:11.704832968 +0000 @@ -1,13 +1,14 @@ -From f4eb44f81d8c47d157523f893fbab9baeb38f9c1 Mon Sep 17 00:00:00 2001 +From d4a043f08be87f7ddb97c4969e3fd2f6beef5cda Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Wed, 9 Sep 2020 09:11:46 +0800 Subject: [PATCH] raw/dpaa2_qdma: fix reset +[ upstream commit f4eb44f81d8c47d157523f893fbab9baeb38f9c1 ] + This issue detected by coverity, CID#279443(Structurally dead code). Coverity issue: 279443 Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Nipun Gupta @@ -16,10 +17,10 @@ 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c -index 0b9c4e3d72..4b8474951e 100644 +index c905954004..b31d7aacb3 100644 --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c -@@ -452,9 +452,10 @@ rte_qdma_reset(void) +@@ -455,9 +455,10 @@ rte_qdma_reset(void) /* In case there are pending jobs on any VQ, return -EBUSY */ for (i = 0; i < qdma_dev.max_vqs; i++) { if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=