From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D729A04DD for ; Wed, 28 Oct 2020 11:54:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07826C9C0; Wed, 28 Oct 2020 11:54:02 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by dpdk.org (Postfix) with ESMTP id 8A45149E0 for ; Wed, 28 Oct 2020 11:54:00 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id l8so2635087wmg.3 for ; Wed, 28 Oct 2020 03:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tgG/gtBXXNx8/eXcCkfE0WR39Y2SQcQHXTKst4enpDc=; b=S9J5kD6pYnXUCXyEPNDVTdtLkzRzhD68plmELonUov6cBzn1ovhsYIcqdj5bDgQ7uE pdePP2Xwqye1kFgzB7IoexaW4EpEMFEoj3AC/mToifyNIGNrdIhiS/nGcLxxW6Co7PyM UtXErVbdjlSQSY8l1yrJ8Et08ctOWT/lArSz84a3iUPLq75co07KgcNuGTpe6Se4Rz2A IA5FjD3xDDWOvaU2DoTBaPt2J8+FfB9OT/H4cVgaQBKeLGXcqkBso9qlu0+sMzJDfGd+ J0jRCA5EFcVzclGwtTrPrehtPY9VeFQX27niquzJ2bfXEINR+ieHnztEwh3TjvrLihN3 zLxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tgG/gtBXXNx8/eXcCkfE0WR39Y2SQcQHXTKst4enpDc=; b=RcIn7z/xw0VAeQT3FMnJ6omKfV1ofb/Zfzf5LLVbI52zYJ5MgOAKpTwPyzmPMN/l2V AVmQQY8B3F5am5OaGeHnZhq+pz6np91VqmIKM0zmoz8BXvgRnF8hcXQ8Rw3NX8dL98UC X+U7/5tUJ5vM2GFW50RzpBTeZzriEcGTxFm5fNUjbgPDFQhfTt16Vwn7Ned4O5wXklpX QDvnz+qskqutpFlkn6+4a2ATSXOlg4Q58PKv0U+jBAA3FH7mNM08Gpdd2UAI6PM5NCIm iS2S7swgygTrf5/Z2i44fZGPimX3bbK4LK7yCA6QD4asUj0z4nIx2OgqpuHjcC7ZNn84 7vbA== X-Gm-Message-State: AOAM531T0stoxOWSrMX+rbF9TEHT7H/ZPU2QAiN0H2R3Fq6UVIfbu4JN xh160qRtpIgCXmce3Hl3hK0= X-Google-Smtp-Source: ABdhPJzNA/+tv6e1hqScEXk1WmorfItz415zJZUR2w5w4SlsmPpuMW9LfToQvaqb0LH1SsivNAeZVA== X-Received: by 2002:a1c:9910:: with SMTP id b16mr7160901wme.64.1603882439290; Wed, 28 Oct 2020 03:53:59 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p11sm6478779wrm.44.2020.10.28.03.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:53:58 -0700 (PDT) From: luca.boccassi@gmail.com To: Ruifeng Wang Cc: Adam Dybkowski , dpdk stable Date: Wed, 28 Oct 2020 10:45:06 +0000 Message-Id: <20201028104606.3504127-147-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/crypto: fix stats test' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 1efe9f0924ec1b1000df11834f974fe2a5c14db9 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Mon, 31 Aug 2020 16:51:43 +0800 Subject: [PATCH] test/crypto: fix stats test [ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ] ut_setup / ut_teardown are invoked for each test case by test framework. The call inside test_stats is unnecessary and even incorrect. This caused double free of objects such as crypto operation structure. Trapped the issue when RTE_LIBRTE_MEMPOOL_DEBUG was enabled. Fix issue by removing ut_setup / ut_teardown from test case implementation. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Signed-off-by: Ruifeng Wang Tested-by: Adam Dybkowski --- app/test/test_cryptodev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 75d35c6582..a852040ec2 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -9425,9 +9425,7 @@ test_stats(void) "rte_cryptodev_stats_get invalid Param failed"); /* Test expected values */ - ut_setup(); test_AES_CBC_HMAC_SHA1_encrypt_digest(); - ut_teardown(); TEST_ASSERT_SUCCESS(rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats), "rte_cryptodev_stats_get failed"); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:16.301208099 +0000 +++ 0147-test-crypto-fix-stats-test.patch 2020-10-28 10:35:11.740833497 +0000 @@ -1,8 +1,10 @@ -From b450503612eebc59de96aa3f20ec5ea0e3ceb400 Mon Sep 17 00:00:00 2001 +From 1efe9f0924ec1b1000df11834f974fe2a5c14db9 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Mon, 31 Aug 2020 16:51:43 +0800 Subject: [PATCH] test/crypto: fix stats test +[ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ] + ut_setup / ut_teardown are invoked for each test case by test framework. The call inside test_stats is unnecessary and even incorrect. This caused double free of objects such as crypto operation structure. @@ -10,7 +12,6 @@ Fix issue by removing ut_setup / ut_teardown from test case implementation. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") -Cc: stable@dpdk.org Signed-off-by: Ruifeng Wang Tested-by: Adam Dybkowski @@ -19,10 +20,10 @@ 1 file changed, 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c -index 704aa7c414..d702cb91a3 100644 +index 75d35c6582..a852040ec2 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c -@@ -9326,9 +9326,7 @@ test_stats(void) +@@ -9425,9 +9425,7 @@ test_stats(void) "rte_cryptodev_stats_get invalid Param failed"); /* Test expected values */