From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DCB1A04DD for ; Wed, 28 Oct 2020 11:54:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3223CCA10; Wed, 28 Oct 2020 11:54:05 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by dpdk.org (Postfix) with ESMTP id EF628C9F6 for ; Wed, 28 Oct 2020 11:54:01 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id l8so2635199wmg.3 for ; Wed, 28 Oct 2020 03:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YvSoJv3cLfgCQeLdUz0WwNVCRNoLkpQMuVJ5r2UhNtU=; b=H4EktOPa1komT9PFfu3X+0Cu6vOZ3GNXDXPeSRDUybfu04d8RW/YQ+TuRwcuFlfTNo zdwTQNHutHblebIs5iFvHi6fc1yXFI2ZTMSm+UrHKcBlteDTpCf/8++gTMi68POITsfv CmF4Ah+B1LBwBZMF9ffx6NM0rRKhxUEspNSY6t6XEoQcfHPfCaSZbCAp4JV5ELbjSC/E whnRkle1+NUt34n1K7BbxkaOFSsYESsm+UxbxJcoKv0g7DKWLet3/uRQAOew5DcNp4hE xWqZ5tvU16RKGvprHPYJdbdYoSsgOk6+ECFJ0nj5Tx3eGaZ9BRSKCEhNdfVkpnjHr0n7 /AVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YvSoJv3cLfgCQeLdUz0WwNVCRNoLkpQMuVJ5r2UhNtU=; b=McHtEXIMFBYS1x83PT4AxnIZopjs3ayd4m0MysAnyov+/F3umEM7KYPaN+OEPNDOnq az9HuiGrplche+2Sy+SgEtPdo+aj9STRgYv56P0U/tli3vK+YewHxnPyUu3fSnlP6F7m jobJurwVqUfdAJP7uRsPin6QP+UHO4gC7SCLRaL9RPV1IFBXZ7jkccG4GJ+DC6LtvqrB IQ59ZbWN5VQFdEA9i+AIccXobSvLcYIzP1i/fUJaEeRnGJ/E3vd9ehAsV8d43S9u3GpQ LOkllUQnQsl9wIt2bi0NZ/ON3HAEGf34+nZgIVfqUrEr3nL9L4qZip2R1hARubWD/TzY XffA== X-Gm-Message-State: AOAM5334PMADRILn23vIb5xQ94eC3NECROJ4ZLmeAnf4pyF1R7o7f/hE 7M+w0tTx4Adcv2ca/UItdj8= X-Google-Smtp-Source: ABdhPJz4Sf4ZYMbmFJZKTFqjcqK4OMlyofgP+W8KOS5hbczRAs5lZDeRW6zNKmzpP64/jEYrTJy4kg== X-Received: by 2002:a7b:c4c3:: with SMTP id g3mr5556953wmk.65.1603882441746; Wed, 28 Oct 2020 03:54:01 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y7sm5867806wmg.40.2020.10.28.03.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:54:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Haggai Eran Cc: Akhil Goyal , dpdk stable Date: Wed, 28 Oct 2020 10:45:08 +0000 Message-Id: <20201028104606.3504127-149-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'cryptodev: fix parameter parsing' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 1d8fa909f9b5ea6eba8da1dcba3de63e39b2c6c5 Mon Sep 17 00:00:00 2001 From: Haggai Eran Date: Thu, 8 Oct 2020 22:42:14 +0300 Subject: [PATCH] cryptodev: fix parameter parsing [ upstream commit 784fb396f72d98070f3afaf309a7addb4c0d8da1 ] The rte_cryptodev_pmd_parse_input_args function crashes with a segmentation fault when passing a non-empty argument string. The function passes cryptodev_pmd_valid_params to rte_kvargs_parse, which accepts a NULL-terminated list of valid keys, yet cryptodev_pmd_valid_params does not end with NULL. The patch adds the missing NULL pointer. Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation") Signed-off-by: Haggai Eran Acked-by: Akhil Goyal --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index fba14f2fa0..c4935b3307 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -41,7 +41,8 @@ extern "C" { static const char * const cryptodev_pmd_valid_params[] = { RTE_CRYPTODEV_PMD_NAME_ARG, RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG, - RTE_CRYPTODEV_PMD_SOCKET_ID_ARG + RTE_CRYPTODEV_PMD_SOCKET_ID_ARG, + NULL }; /** -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:16.368510271 +0000 +++ 0149-cryptodev-fix-parameter-parsing.patch 2020-10-28 10:35:11.740833497 +0000 @@ -1,8 +1,10 @@ -From 784fb396f72d98070f3afaf309a7addb4c0d8da1 Mon Sep 17 00:00:00 2001 +From 1d8fa909f9b5ea6eba8da1dcba3de63e39b2c6c5 Mon Sep 17 00:00:00 2001 From: Haggai Eran Date: Thu, 8 Oct 2020 22:42:14 +0300 Subject: [PATCH] cryptodev: fix parameter parsing +[ upstream commit 784fb396f72d98070f3afaf309a7addb4c0d8da1 ] + The rte_cryptodev_pmd_parse_input_args function crashes with a segmentation fault when passing a non-empty argument string. @@ -12,7 +14,6 @@ missing NULL pointer. Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation") -Cc: stable@dpdk.org Signed-off-by: Haggai Eran Acked-by: Akhil Goyal @@ -21,7 +22,7 @@ 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h -index 81975d72b4..1367222f73 100644 +index fba14f2fa0..c4935b3307 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -41,7 +41,8 @@ extern "C" {