From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CA90A04DD for ; Wed, 28 Oct 2020 11:54:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03A90CA4E; Wed, 28 Oct 2020 11:54:36 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id C329CCA4E for ; Wed, 28 Oct 2020 11:54:33 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id x7so5181046wrl.3 for ; Wed, 28 Oct 2020 03:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NxGv9MfjQ81rGSAWyGJ4/UCskdtFzhxG0bPmbpDKytY=; b=spEsKLnxei8HaB3XuN/iNVWqRnN4Px8vEbqMjrazeP4uvCtPyGg+A4tBeY7lpRv3Wo XWCVXOn5jtZlJYTKsQT/HyQhjruQ8GF55MNKNCFLMBIoHW9HtYnpvs/7gJBKhum2EQEZ /lAzcrcTi3wM5EcQMVAtDdqbUOykL9rFgGTtlWzXJk2rh+mqf3qTOudjlMGs021nK227 RLqUAPWqNdkUkKQca6DUkWkrC4mP74TMfU0qxPXz7n7NCkNSwKuTCXWkQ2W7zcnDfIDA mHFhbUB4a9SljPkkKOTG5GC7MVmf/dQAUJG+OtG7/5fL52emNozdTQGgp3tV6YTEJeBW W/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NxGv9MfjQ81rGSAWyGJ4/UCskdtFzhxG0bPmbpDKytY=; b=jt/596pNkMCXKBp/gQNDh8SUP6b1ljTaeRmiTKwIlCiHOipa1FTJ/Jeg0WBHU9YITG s5IEAuaN1iYgzyNNU1sNXPznDQO6fBv7sGyzXJoVMrEk/1z3c3SQZ1X+LHtalI3NkgKV UR55mJr+pKgveN96PDZ/TJeRn9fkoGLJ/18BufZLKgAcJoh5DRDOd4lI08DKyKs604dl PWCAxq8muk4GtOBtDMMFVHY+x8GoTk1sF/4kH5Rasmxt0u8VQDSl3Yoi/gk+QQRtsG43 75+9RN1+UJijtG8kg71u+46DMXJunuzTiq7NPZEVwEoUJgJkgt3+rq0W43DNsjHfz0xs facg== X-Gm-Message-State: AOAM531BmDK4iTgCJpTaja+Sxu8TVeqPXZAHI6yjAF1By2d/HvAL8eFd qudiqJvo94vLHqJfnOdK/KY= X-Google-Smtp-Source: ABdhPJygammxxiwwfHgf2WUZTZStniD0uYXEEeOCTbYt1S+qgkLblAJMXhMqttkvtWUlx93iKj31PQ== X-Received: by 2002:a5d:63cb:: with SMTP id c11mr5323330wrw.243.1603882473540; Wed, 28 Oct 2020 03:54:33 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y201sm5793666wmd.27.2020.10.28.03.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:54:32 -0700 (PDT) From: luca.boccassi@gmail.com To: Ankur Dwivedi Cc: Abhinandan Gujjar , dpdk stable Date: Wed, 28 Oct 2020 10:45:18 +0000 Message-Id: <20201028104606.3504127-159-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/event: fix function arguments for crypto adapter' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From cf95edefbd899fa494b6467736078d7c49ab3342 Mon Sep 17 00:00:00 2001 From: Ankur Dwivedi Date: Thu, 8 Oct 2020 18:22:33 +0530 Subject: [PATCH] test/event: fix function arguments for crypto adapter [ upstream commit 45eb85e9bff1c03cf72fb2ff9722757b64d47735 ] The arguments passed to rte_event_crypto_adapter_caps_get() and rte_event_crypto_adapter_create() are incorrect. In the rte_event_crypto_adapter_caps_get(), event device id should be the first argument and cryptodev id should be the second argument. In the rte_event_crypto_adapter_create(), the event device id should be the second argument. Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test") Signed-off-by: Ankur Dwivedi Acked-by: Abhinandan Gujjar --- app/test/test_event_crypto_adapter.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c index 530ce96f1a..1a9aa06c7d 100644 --- a/app/test/test_event_crypto_adapter.c +++ b/app/test/test_event_crypto_adapter.c @@ -201,8 +201,8 @@ test_op_forward_mode(uint8_t session_less) &cipher_xform, params.session_priv_mpool); TEST_ASSERT_SUCCESS(ret, "Failed to init session\n"); - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, - evdev, &cap); + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, + &cap); TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -288,7 +288,7 @@ test_sessionless_with_op_forward_mode(void) uint32_t cap; int ret; - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap); + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap); TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -313,7 +313,7 @@ test_session_with_op_forward_mode(void) uint32_t cap; int ret; - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap); + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap); TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -394,8 +394,8 @@ test_op_new_mode(uint8_t session_less) params.session_mpool); TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n"); - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, - evdev, &cap); + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, + &cap); TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -444,7 +444,7 @@ test_sessionless_with_op_new_mode(void) uint32_t cap; int ret; - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap); + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap); TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -470,7 +470,7 @@ test_session_with_op_new_mode(void) uint32_t cap; int ret; - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap); + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap); TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -692,7 +692,7 @@ test_crypto_adapter_create(void) /* Create adapter with default port creation callback */ ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID, - TEST_CDEV_ID, + evdev, &conf, 0); TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n"); @@ -705,7 +705,7 @@ test_crypto_adapter_qp_add_del(void) uint32_t cap; int ret; - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap); + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap); TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:16.667822401 +0000 +++ 0159-test-event-fix-function-arguments-for-crypto-adapter.patch 2020-10-28 10:35:11.756833733 +0000 @@ -1,8 +1,10 @@ -From 45eb85e9bff1c03cf72fb2ff9722757b64d47735 Mon Sep 17 00:00:00 2001 +From cf95edefbd899fa494b6467736078d7c49ab3342 Mon Sep 17 00:00:00 2001 From: Ankur Dwivedi Date: Thu, 8 Oct 2020 18:22:33 +0530 Subject: [PATCH] test/event: fix function arguments for crypto adapter +[ upstream commit 45eb85e9bff1c03cf72fb2ff9722757b64d47735 ] + The arguments passed to rte_event_crypto_adapter_caps_get() and rte_event_crypto_adapter_create() are incorrect. @@ -12,7 +14,6 @@ be the second argument. Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test") -Cc: stable@dpdk.org Signed-off-by: Ankur Dwivedi Acked-by: Abhinandan Gujjar @@ -21,7 +22,7 @@ 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c -index db9d75d3ff..37bcbecd47 100644 +index 530ce96f1a..1a9aa06c7d 100644 --- a/app/test/test_event_crypto_adapter.c +++ b/app/test/test_event_crypto_adapter.c @@ -201,8 +201,8 @@ test_op_forward_mode(uint8_t session_less)