From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C57E7A04DD for ; Wed, 28 Oct 2020 11:47:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5A7CC9C2; Wed, 28 Oct 2020 11:47:03 +0100 (CET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by dpdk.org (Postfix) with ESMTP id 555C5C8F8 for ; Wed, 28 Oct 2020 11:47:02 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id 13so4088886wmf.0 for ; Wed, 28 Oct 2020 03:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P4eYAzRG/FHuBR7+wQ3MeYw9hMd7OOuUhD0ocZAfXIM=; b=OZ5uh981zqUDpcUCQPYfMewc+cNoEDvVnzgt1ipfDGIEjm9E/94qrIFIfCI+RJbTDk fXsLzP1UbQ9FWfwEVfAnmmJMkF8qgluVT//QjgSd26ovWBmdwQTKAUhJySlijw61GFB3 sT/yq1itBoZUIssckEe0TAlKcUHDy68I2rpTGygK/NJQVS6Hf2EHpN+Kw99r5WLQN6Ah hq9UddgwPvGV6ZShoeXhnJeoCai8zg23z0lOtCoj7dwPfyoCxW3buxsVu6otId+7pxzE JVGKNWGSn6hHsoCVpX9Y4M4307ecdOLTBqW2FgoZBwREPiVFE8AJR8ZfwqeaoHfOTdaV j80w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P4eYAzRG/FHuBR7+wQ3MeYw9hMd7OOuUhD0ocZAfXIM=; b=oz3Br4WAH2d0HAxC+UbzfyLPeOTZ0Xz5obN7gOX5VDFa+Tf5k6tII635WOKKEjWN/7 BdU3L5yHEHHJz3amOX2sTLG8r54c654KccyWQbVaYThIeJ26GHZzelh1L4youyx6Z1wO dflDP20aJYVvQU2csw+z1QweEq1R0OL7YtktRFqcF7FER3770yNbBsnVFjOUfQtRaPS6 UtUmm3L6of+CtVad9fBVda1uJD44hegq6mxLgWJPjnLvp3P/jmKHUNjr48lGSbchxkwf 0YTDzLT6VCsJCWgM25ga+1SznJCn8n1DLW2fuX2dYFYmsJ+KUDfA5yftrdAEY+J95b5f NReA== X-Gm-Message-State: AOAM533sbR+5b1QzKh5WfRTFZmwOAY+77RrcVHE3OHueAzXA1Netx6WJ oVjQJvazWZG84vPh5NLaJBU= X-Google-Smtp-Source: ABdhPJztZkVYE7IJNcUF+8xQ6GecuUc+ghewiydXFiifv3IXf8fSpQHlMcwPMwGWo4p2gkHNInSPeQ== X-Received: by 2002:a1c:4442:: with SMTP id r63mr2844279wma.109.1603882021103; Wed, 28 Oct 2020 03:47:01 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 4sm6329218wrn.48.2020.10.28.03.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:47:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Ferruh Yigit , dpdk stable Date: Wed, 28 Oct 2020 10:42:55 +0000 Message-Id: <20201028104606.3504127-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'bus/dpaa: remove logically dead code' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 760665e988f1d6334ed7b69807276b4c0bf92ad3 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Mon, 24 Aug 2020 21:02:39 +0800 Subject: [PATCH] bus/dpaa: remove logically dead code [ upstream commit 126a2c485c8012ff47bfd4825b9f71d2e606e3b8 ] This patch removes logically dead code reported by coverity. Coverity issue: 349930 Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init") Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit --- drivers/bus/dpaa/base/qbman/qman_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c index 69244ef701..464998fe91 100644 --- a/drivers/bus/dpaa/base/qbman/qman_driver.c +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c @@ -179,8 +179,6 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd) *fd = q_fd; return portal; err: - if (portal) - qman_free_global_portal(portal); if (q_fd) close(q_fd); process_portal_unmap(&q_map.addr); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:12.291699244 +0000 +++ 0016-bus-dpaa-remove-logically-dead-code.patch 2020-10-28 10:35:11.424828846 +0000 @@ -1,13 +1,14 @@ -From 126a2c485c8012ff47bfd4825b9f71d2e606e3b8 Mon Sep 17 00:00:00 2001 +From 760665e988f1d6334ed7b69807276b4c0bf92ad3 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Mon, 24 Aug 2020 21:02:39 +0800 Subject: [PATCH] bus/dpaa: remove logically dead code +[ upstream commit 126a2c485c8012ff47bfd4825b9f71d2e606e3b8 ] + This patch removes logically dead code reported by coverity. Coverity issue: 349930 Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit @@ -16,10 +17,10 @@ 1 file changed, 2 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c -index 1166d68e21..a466c698fc 100644 +index 69244ef701..464998fe91 100644 --- a/drivers/bus/dpaa/base/qbman/qman_driver.c +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c -@@ -189,8 +189,6 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd) +@@ -179,8 +179,6 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd) *fd = q_fd; return portal; err: