From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91E3CA04DD for ; Wed, 28 Oct 2020 11:55:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A864CAA1; Wed, 28 Oct 2020 11:55:09 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by dpdk.org (Postfix) with ESMTP id D8BA5CA8F for ; Wed, 28 Oct 2020 11:55:06 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id v5so4118095wmh.1 for ; Wed, 28 Oct 2020 03:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=26SrW9s27MrFQ5K7FiF+wVRetQCH1Ut0Ffa3qf7E+0c=; b=KSJU2etuUn8XALwIOt3IEmNdoB2gku/zTfPawJruywg06xS7Un87JIYMiqMrcNOa8n JqOuxLMjhCpHvje82Tajbi+CVNb2j/d6YaFBpAxLMRoKLbLgVU/lCaugC9TZMorUeT/4 iLTgotI95GmrhIpJ1f9KORfJ0wJJIlPVNg3RPb7Q/5wxnlRLr/I+FIC6WoADiQuxgf4o Qz7OgrFtjDP2KMvV+taiSl23rXQGSD9zIYEz2uzoWAD7NjYlRzIxWK7Cwds1AeqehnYD 07vhUd4eBSx8u6xqarpmznJeHKE09ld0yBBHZ+WwtyW8Wr36qsK4U5gBMDcG5mm1pr3o h/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=26SrW9s27MrFQ5K7FiF+wVRetQCH1Ut0Ffa3qf7E+0c=; b=UhPhF7c2wCnKDg1PGEtQBvf4ctq6teYY/HQc6k+MQAE9OoItE878gp+/WTHFmRsQCj Duc8LQOAoGPWHxJTpgq0sqf4jtvt6s5Vn5WUxy49a+h06mpc+vLZoeKXZAEswUcJLsPl JzsbLeSFuT/OvyjQqWBLl3gP5dBHtJ627ixqjtW1uorTPufiQxEDi1/8J0RXDlNFCuOP /LBnmMVR2uQj2zC/TioGpkIVa6YEvtFFXd2Fje4abw5jj+93fWA67jgzYvUBiwGUahBW f//UYtW5kt/VMcYWP1he9bMTmJfVoS3HlFVkKlmvT+CjlZI44PWCwSLZo0LKsNqJBjLo AL5g== X-Gm-Message-State: AOAM53355MkHB1Hd/k3DXpN/lxS4UztwfshDnG22Z1jB3KYgnzk/Y3Hd Sju+1akTLYqZJC5MQ0rAWo8= X-Google-Smtp-Source: ABdhPJyC5+F5avBrWJp3eW2O3sfMb2Noz77to10zwb4SnisPABqy5UwACqN1LgfeCKKeZgkTb43KHQ== X-Received: by 2002:a1c:7c1a:: with SMTP id x26mr7506035wmc.4.1603882506652; Wed, 28 Oct 2020 03:55:06 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g17sm6617698wrw.37.2020.10.28.03.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:55:06 -0700 (PDT) From: luca.boccassi@gmail.com To: Honnappa Nagarahalli Cc: Phil Yang , Ruifeng Wang , Jakub Grajciar , dpdk stable Date: Wed, 28 Oct 2020 10:45:29 +0000 Message-Id: <20201028104606.3504127-170-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/memif: relax load of ring head for M2S ring' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From bac91cd3440496b6692b8442941ff5d78f13ff54 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Mon, 28 Sep 2020 14:03:29 -0500 Subject: [PATCH] net/memif: relax load of ring head for M2S ring [ upstream commit 562fc6ef142c706b15136b80070dec84bb641d8b ] For M2S rings, ring->head is updated by the receiver and eth_memif_rx function is called in the context of receiving thread. The loads in the receiver do not need to synchronize with its own stores. Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier") Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Jakub Grajciar --- drivers/net/memif/rte_eth_memif.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 3b377bc54c..26c06d9055 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -398,7 +398,11 @@ no_free_bufs: refill: if (type == MEMIF_RING_M2S) { - head = __atomic_load_n(&ring->head, __ATOMIC_ACQUIRE); + /* ring->head is updated by the receiver and this function + * is called in the context of receiver thread. The loads in + * the receiver do not need to synchronize with its own stores. + */ + head = __atomic_load_n(&ring->head, __ATOMIC_RELAXED); n_slots = ring_size - head + mq->last_tail; while (n_slots--) { -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:17.002396335 +0000 +++ 0170-net-memif-relax-load-of-ring-head-for-M2S-ring.patch 2020-10-28 10:35:11.776834028 +0000 @@ -1,14 +1,15 @@ -From 562fc6ef142c706b15136b80070dec84bb641d8b Mon Sep 17 00:00:00 2001 +From bac91cd3440496b6692b8442941ff5d78f13ff54 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Mon, 28 Sep 2020 14:03:29 -0500 Subject: [PATCH] net/memif: relax load of ring head for M2S ring +[ upstream commit 562fc6ef142c706b15136b80070dec84bb641d8b ] + For M2S rings, ring->head is updated by the receiver and eth_memif_rx function is called in the context of receiving thread. The loads in the receiver do not need to synchronize with its own stores. Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier") -Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang @@ -19,10 +20,10 @@ 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c -index b72e24932e..6deab098b5 100644 +index 3b377bc54c..26c06d9055 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c -@@ -410,7 +410,11 @@ no_free_bufs: +@@ -398,7 +398,11 @@ no_free_bufs: refill: if (type == MEMIF_RING_M2S) {