From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A188FA04DD for ; Wed, 28 Oct 2020 11:47:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 989D0C9C0; Wed, 28 Oct 2020 11:47:22 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id BAB7749E0 for ; Wed, 28 Oct 2020 11:47:19 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id m13so867048wrj.7 for ; Wed, 28 Oct 2020 03:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QN7Ic1wXsLaGtKyOU78qGNSQqD1krGvrT9PdUhvnl2o=; b=TDyJ3BGy8qC5tW8gdIe4QCQ6oePVq8Rn7L/cLjXdvRx/skUbb400t8umBuSlIY37OR 9Kisn1ddlPzcP8CwPaQZHg9thJbvhnMIYnpqjb12eeIs4+fyWFvQUl0tc42YLeN9oqrl jFZNvzsmKDwCseLK3paOMT9opvL6FQ5c7Sz6RGqC5ftvoe9ytQaND6ExCWIXFGK0PT09 wFXVT6t3qMTKmR5T4SMWMSTgUE2TbgR8OFqe+4DFVepGBzj9hnYZA2N/Mw/9lIbLCW3Q JBEC2eRlB+VwDD2gqwuMnpDiG+ymxQ70d/B55x4aJDefwPuJoXA4uzx/Q6CXQd8IemyN sq7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QN7Ic1wXsLaGtKyOU78qGNSQqD1krGvrT9PdUhvnl2o=; b=d0YpJQ7/fvi6y8vy1IMvv9wVg0mq1/0oZvlEp8etmX3Feu8hYFGKWJfxD2RNd6Yobu Rjpwmy7GZaIWYokrv3Z2n3sWnYU+GkgulE1dkqwNDtJ5pdAs5C+0xU3hE1ZfCKsPPdbt elzMEVRPUKZG2fyEEGOkHxYmVc/gMj0DNdRZl/uFCeP19Drz3XB66fDNzn7EihiglahE Hj6sNMSWFqnULGbMCXadkdRpJy2/ZWo+Zfoj7eghTwTVJbRc/ucsGlKp4qB3kUi4o/9P xDHm6qN3E+6fU31c4VTRKmXxM5mxwN5f+5IeETvMblk7bA1TJ4MZB1O6vssTcaZjzE8t APAA== X-Gm-Message-State: AOAM533A6wlJxUdJFpCV+Ak16jqIpLBTMw7/l5BWJP9aYoLFdcYTns/a ZZi2ZUr/kerpnGyLRYf5uVUdLAKVa18xPGQ8 X-Google-Smtp-Source: ABdhPJzM5I2l0LHpZ09WDkqg+bb3otW+tC2/lIQY/4wG08BXDDJlXqPlohvK7/U+Snqb8prAywcBLQ== X-Received: by 2002:adf:f2c1:: with SMTP id d1mr8573319wrp.179.1603882038531; Wed, 28 Oct 2020 03:47:18 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id n5sm6219160wrm.2.2020.10.28.03.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:47:17 -0700 (PDT) From: luca.boccassi@gmail.com To: Steve Yang Cc: Beilei Xing , dpdk stable Date: Wed, 28 Oct 2020 10:43:01 +0000 Message-Id: <20201028104606.3504127-22-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/iavf: fix setting of MAC address' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 45120d61c2a497396d638cdae6c458f97d897b82 Mon Sep 17 00:00:00 2001 From: Steve Yang Date: Fri, 4 Sep 2020 07:29:05 +0000 Subject: [PATCH] net/iavf: fix setting of MAC address [ upstream commit dd52fa0bade3d9e8bbb2229309c9f020cbe6872f ] When setting the MAC address, the ethdev layer copies the new mac address in dev->data->mac_addrs[0] before calling the dev_ops. Therefore, is_same_ether_addr(mac_addr, dev->data->mac_addrs) was always true, and the MAC was never set. Remove this test to fix the issue. Fixes: 538da7a1cad2 ("net: add rte prefix to ether functions") Signed-off-by: Steve Yang Acked-by: Beilei Xing --- drivers/net/iavf/iavf_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index d65412ae94..a60b04ddd5 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -987,9 +987,6 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev, old_addr = (struct rte_ether_addr *)hw->mac.addr; perm_addr = (struct rte_ether_addr *)hw->mac.perm_addr; - if (rte_is_same_ether_addr(mac_addr, old_addr)) - return 0; - /* If the MAC address is configured by host, skip the setting */ if (rte_is_valid_assigned_ether_addr(perm_addr)) return -EPERM; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:12.479276588 +0000 +++ 0022-net-iavf-fix-setting-of-MAC-address.patch 2020-10-28 10:35:11.444829140 +0000 @@ -1,8 +1,10 @@ -From dd52fa0bade3d9e8bbb2229309c9f020cbe6872f Mon Sep 17 00:00:00 2001 +From 45120d61c2a497396d638cdae6c458f97d897b82 Mon Sep 17 00:00:00 2001 From: Steve Yang Date: Fri, 4 Sep 2020 07:29:05 +0000 Subject: [PATCH] net/iavf: fix setting of MAC address +[ upstream commit dd52fa0bade3d9e8bbb2229309c9f020cbe6872f ] + When setting the MAC address, the ethdev layer copies the new mac address in dev->data->mac_addrs[0] before calling the dev_ops. @@ -11,7 +13,6 @@ issue. Fixes: 538da7a1cad2 ("net: add rte prefix to ether functions") -Cc: stable@dpdk.org Signed-off-by: Steve Yang Acked-by: Beilei Xing @@ -20,10 +21,10 @@ 1 file changed, 3 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c -index 5f3aea8a04..8e1d8a8d3e 100644 +index d65412ae94..a60b04ddd5 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c -@@ -1020,9 +1020,6 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev, +@@ -987,9 +987,6 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev, old_addr = (struct rte_ether_addr *)hw->mac.addr; perm_addr = (struct rte_ether_addr *)hw->mac.perm_addr;