From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0ABB5A04DD for ; Wed, 28 Oct 2020 11:50:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 046492C2A; Wed, 28 Oct 2020 11:50:32 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 7CEFA2C2A for ; Wed, 28 Oct 2020 11:50:30 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id g12so5124793wrp.10 for ; Wed, 28 Oct 2020 03:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y9vrLkbtvnrqRicRrorMLmXn7LHRHylpTUChWI6ui+c=; b=nIs8SnUUDQNq+ASQigH+E5LTUKDJpEa3bJ0gP3uM54kwQhTW2lKWvr+VsaCQtsbW9O oXOIbn7xCXcarj8Q7n/VqnXBk+J2xwmmGQYaQVIi2E7q4UwKaS3csMZjc1QSH9cuiqjq Ogq3Wb3281kyhaQ063n3/HGRV9zOaLUKaN4GBMVXX9zGuKlxAvz2m1FijwhNSqb3ZOR0 K2HQe3jRZDZ+R9xkjrmrWPKIBcsx2CVx+yEkW3wsE34leMvA0SZkCHeMP+0drYvSxwHx lHKZf8uVMWX7JVy0xeqDw7H6H4p5WQ86pLuIsG5kP+iVPlMrf3ncthYkMKSm+n9uBSnB Ic9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y9vrLkbtvnrqRicRrorMLmXn7LHRHylpTUChWI6ui+c=; b=miF2l2UIEbCpkXN19D7dCmwj9P4QqQzhFui10R48qvQy/7cx9+XrxG/KK+/oAL2ylc hAXZNf8pYJnbdhIjCo4P/6ktPyWxSEtOuJlzS7i+PBFoyyRuKqrQbZdFeyfsXjq/0lPw FzP1WxonFrRQJ/Mkw3YaULBjMwBwswgHk2xAr4RYxhySDisRaTq+PsiFx3rVx1zx/6S9 2sN0EKh3NqMSfxcjCN5UbbExRG7U7hGU20m4jbULy/O4W4CV41uYzhK1Pb/bCYVwY2as UIT3psG7W8Wxjgh1JFCiQw9oRF1EUwj7KilUzd0Be4esfgRFu799OtufNSAljTmc31vL W4dA== X-Gm-Message-State: AOAM532ubKxSZUGGENUeURVPEev77mp8vCN+TG00EmwjsWtPrXRKCJfg pzyGZ0n7V2nBff33t8Sc9B2XfrpW98tOroNU X-Google-Smtp-Source: ABdhPJyrarpeiZw6bV9+9WcCAJtHEZ0CJrNteZVBpv2/2TyOTyIn5zdkXJOObVXUc5bb6+mw0jak0A== X-Received: by 2002:adf:f246:: with SMTP id b6mr8061789wrp.111.1603882229168; Wed, 28 Oct 2020 03:50:29 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c64sm4374569wme.29.2020.10.28.03.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:50:28 -0700 (PDT) From: luca.boccassi@gmail.com To: "Wei Hu (Xavier)" Cc: Lijun Ou , dpdk stable Date: Wed, 28 Oct 2020 10:44:00 +0000 Message-Id: <20201028104606.3504127-81-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/hns3: fix storing RSS info when creating flow action' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From a041d47269e61a15a224ed3ac258a3e75344aafd Mon Sep 17 00:00:00 2001 From: "Wei Hu (Xavier)" Date: Tue, 22 Sep 2020 20:03:29 +0800 Subject: [PATCH] net/hns3: fix storing RSS info when creating flow action [ upstream commit 81f04b9c20d802972c1c9e3aa0cd4a491f66eb25 ] Currently, when calling the rte_flow_query API function to query the RSS information, the queue related information is not as expected. The root cause is that when application call the rte_flow_create API function to create RSS action, the operation of storing the data whose typs is struct rte_flow_action_rss is incorrect in the '.create' ops implementation function named hns3_flow_create. This patch fixes it by replacing memcpy with hns3_rss_conf_copy function to store the RSS information in the hns3_flow_create. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index a53d5ed2b1..4bc6812283 100644 --- a/drivers/net/hns3/hns3_flow.c +++ b/drivers/net/hns3/hns3_flow.c @@ -1752,8 +1752,8 @@ hns3_flow_create(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, ret = -ENOMEM; goto err; } - memcpy(&rss_filter_ptr->filter_info, rss_conf, - sizeof(struct hns3_rss_conf)); + hns3_rss_conf_copy(&rss_filter_ptr->filter_info, + &rss_conf->conf); rss_filter_ptr->filter_info.valid = true; TAILQ_INSERT_TAIL(&process_list->filter_rss_list, rss_filter_ptr, entries); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:14.289580247 +0000 +++ 0081-net-hns3-fix-storing-RSS-info-when-creating-flow-act.patch 2020-10-28 10:35:11.596831378 +0000 @@ -1,8 +1,10 @@ -From 81f04b9c20d802972c1c9e3aa0cd4a491f66eb25 Mon Sep 17 00:00:00 2001 +From a041d47269e61a15a224ed3ac258a3e75344aafd Mon Sep 17 00:00:00 2001 From: "Wei Hu (Xavier)" Date: Tue, 22 Sep 2020 20:03:29 +0800 Subject: [PATCH] net/hns3: fix storing RSS info when creating flow action +[ upstream commit 81f04b9c20d802972c1c9e3aa0cd4a491f66eb25 ] + Currently, when calling the rte_flow_query API function to query the RSS information, the queue related information is not as expected. @@ -15,7 +17,6 @@ store the RSS information in the hns3_flow_create. Fixes: c37ca66f2b27 ("net/hns3: support RSS") -Cc: stable@dpdk.org Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) @@ -24,10 +25,10 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c -index 05cc95e3cf..2cdfb6872b 100644 +index a53d5ed2b1..4bc6812283 100644 --- a/drivers/net/hns3/hns3_flow.c +++ b/drivers/net/hns3/hns3_flow.c -@@ -1839,8 +1839,8 @@ hns3_flow_create(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, +@@ -1752,8 +1752,8 @@ hns3_flow_create(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, ret = -ENOMEM; goto err; }