From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3FBBA04DD for ; Wed, 28 Oct 2020 11:51:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCFDF2C2A; Wed, 28 Oct 2020 11:51:02 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by dpdk.org (Postfix) with ESMTP id 5AC522C2A for ; Wed, 28 Oct 2020 11:51:02 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id c194so4087632wme.2 for ; Wed, 28 Oct 2020 03:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4YJtMZuoxhdoq+cjiGFxfkHjtUOAqxU7S9JKJRETzP0=; b=DrQq44vLiMKtSKhIyyHrYUhTE66ZtiGMCoXKl5HQdz873wAVXHYYIQn17vXE9hp/+u hTXy/B9xfTIB2cCS5qImWtEJvf9yFbpSHY0kpPJINaCxE8pxMM3RMkNYsCmsNKmHj30n VrCftIuoj35CkbJwqGXLi3aaD1D8+qISmS0Sq5crG0TKZdScrOmK0Dl9idiNmWHozQTb XoC1r0zYY1k1sDaS0uMcV1x06iwo8ywEeOXFYVUkk4JbqGaqJiOu0SX2dOCe6yfBKcdd xt0eHc82ow6LOjRH0+b1auE/sNMgdeOLLLzGOqS9iwTUbOt4Xsscli8bfppLz+d+E2VI ZSxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4YJtMZuoxhdoq+cjiGFxfkHjtUOAqxU7S9JKJRETzP0=; b=P+CLtcDxHrxo0Xjs3b7qBIkyDUB+0BlW0CIcgRfHU1HPG14+eucN8/NngeQwtQiZEO PWdtTG9dp+KKB5PcxpA3P2j/VpcAeSoNh9c9EWuLzU0GfqlK0wNiL0covzcpClGmVNwL BedCp4fDkchpboJhQU9jCVBNE7oeLRkUTXB8xzXyVgaCB21L0PD+/gSfQzsGtFEc0Czc 1sNBfz8ZUUJf144G5OX86JqjjjmDgvL6Fwk4vMOKvek+ikZQzl6GMBvtPZ+On6PRWy/4 6mJlxgIqWb2t6AyBaoPbMRJgkj7+NGYonzL8jezq9NQ8WSrU7Hzxk83YejQ44XfPZ/Vz Diww== X-Gm-Message-State: AOAM530bUNwIZdL91s/tVlJ3eYk4XAnVSblf148huL72+hsFYKTRxi72 7EmdcwohR5R7bEFGWQPyVbymV98+VdlJ/hdg X-Google-Smtp-Source: ABdhPJwZ0Y2aarQpD2zLxTQ29Ydx0OzwdOt39EtdDGhe5/ye/YzLPQKPkWh6FCjqXJ6HWRM506boOw== X-Received: by 2002:a7b:c20d:: with SMTP id x13mr7959217wmi.83.1603882261146; Wed, 28 Oct 2020 03:51:01 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d129sm5766166wmf.19.2020.10.28.03.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 03:51:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Ferruh Yigit , dpdk stable Date: Wed, 28 Oct 2020 10:44:10 +0000 Message-Id: <20201028104606.3504127-91-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028104606.3504127-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix dereference before null check' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/30/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From cb7e37a0b5c7001a8e000cefa21aecfcf499ab67 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Mon, 24 Aug 2020 19:46:53 +0800 Subject: [PATCH] net/qede: fix dereference before null check [ upstream commit b5c2f5a0ba7b2f7c21be167d5ea418c46552a299 ] Coverity flags that 'fp->sb_info' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 260413 Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation") Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit --- drivers/net/qede/qede_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index ab69cba179..64e6de4743 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -676,9 +676,9 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev) for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { fp = &qdev->fp_array[sb_idx]; - DP_INFO(edev, "Free sb_info index 0x%x\n", - fp->sb_info->igu_sb_id); if (fp->sb_info) { + DP_INFO(edev, "Free sb_info index 0x%x\n", + fp->sb_info->igu_sb_id); OSAL_DMA_FREE_COHERENT(edev, fp->sb_info->sb_virt, fp->sb_info->sb_phys, sizeof(struct status_block)); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-10-28 10:35:14.610484606 +0000 +++ 0091-net-qede-fix-dereference-before-null-check.patch 2020-10-28 10:35:11.636831967 +0000 @@ -1,14 +1,15 @@ -From b5c2f5a0ba7b2f7c21be167d5ea418c46552a299 Mon Sep 17 00:00:00 2001 +From cb7e37a0b5c7001a8e000cefa21aecfcf499ab67 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Mon, 24 Aug 2020 19:46:53 +0800 Subject: [PATCH] net/qede: fix dereference before null check +[ upstream commit b5c2f5a0ba7b2f7c21be167d5ea418c46552a299 ] + Coverity flags that 'fp->sb_info' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 260413 Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit @@ -17,7 +18,7 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c -index ea264f59d7..75d78cebb5 100644 +index ab69cba179..64e6de4743 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -676,9 +676,9 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev)